48 lines
1.7 KiB
Diff
48 lines
1.7 KiB
Diff
From b25bbfcad4a3df94555f6b5f238910314a5d17ea Mon Sep 17 00:00:00 2001
|
|
From: Kevin Wolf <kwolf@redhat.com>
|
|
Date: Wed, 25 Jun 2025 10:27:51 +0200
|
|
Subject: [PATCH 02/57] hw/s390x/ccw-device: Fix memory leak in loadparm setter
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
RH-MergeRequest: 387: s390x: Fix memory leaks related to loadparm [rhel-9]
|
|
RH-Jira: RHEL-98554
|
|
RH-Acked-by: Cédric Le Goater <clg@redhat.com>
|
|
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
RH-Commit: [2/2] d85cf8b3c93ede47b51c4aa1336dc54f58b8cc3f (thuth/qemu-kvm-cs)
|
|
|
|
Commit bdf12f2a fixed the setter for the "loadparm" machine property,
|
|
which gets a string from a visitor, passes it to s390_ipl_fmt_loadparm()
|
|
and then forgot to free it. It left another instance of the same problem
|
|
unfixed in the "loadparm" device property. Fix it.
|
|
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
Message-ID: <20250625082751.24896-1-kwolf@redhat.com>
|
|
Reviewed-by: Eric Farman <farman@linux.ibm.com>
|
|
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
|
|
Tested-by: Thomas Huth <thuth@redhat.com>
|
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
(cherry picked from commit 78e3781541209b3dcd6f4bb66adf3a3e504b88a4)
|
|
---
|
|
hw/s390x/ccw-device.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/s390x/ccw-device.c b/hw/s390x/ccw-device.c
|
|
index 30f2fb486f..63e937401e 100644
|
|
--- a/hw/s390x/ccw-device.c
|
|
+++ b/hw/s390x/ccw-device.c
|
|
@@ -57,7 +57,7 @@ static void ccw_device_set_loadparm(Object *obj, Visitor *v,
|
|
Error **errp)
|
|
{
|
|
CcwDevice *dev = CCW_DEVICE(obj);
|
|
- char *val;
|
|
+ g_autofree char *val = NULL;
|
|
int index;
|
|
|
|
index = object_property_get_int(obj, "bootindex", NULL);
|
|
--
|
|
2.39.3
|
|
|