From ba82420d04b2e2ca69d5ff4720e37dd0748936ea Mon Sep 17 00:00:00 2001 From: Stefano Garzarella Date: Wed, 16 Sep 2020 11:40:25 -0400 Subject: [PATCH 4/4] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[] RH-Author: Stefano Garzarella Message-id: <20200916114025.47973-2-sgarzare@redhat.com> Patchwork-id: 98399 O-Subject: [RHEL-AV-8.3.0 qemu-kvm PATCH 1/1] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[] Bugzilla: 1821528 RH-Acked-by: Danilo de Paula RH-Acked-by: Stefan Hajnoczi RH-Acked-by: Max Reitz Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") introduced namespace support for RBD, but we forgot to add the new 'namespace' options to qemu_rbd_strong_runtime_opts[]. The 'namespace' is used to identify the image, so it is a strong option since it can changes the data of a BDS. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1821528 Fixes: 19ae9ae014 ("block/rbd: Add support for ceph namespaces") Cc: Florian Florensa Signed-off-by: Stefano Garzarella Message-Id: <20200914190553.74871-1-sgarzare@redhat.com> Reviewed-by: Jason Dillaman Signed-off-by: Max Reitz (cherry picked from commit 7bae7c805d82675eb3a02c744093703d84ada2d6) Signed-off-by: Stefano Garzarella Signed-off-by: Danilo C. L. de Paula --- block/rbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/rbd.c b/block/rbd.c index 688074c64b..5356753fbe 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -1289,6 +1289,7 @@ static QemuOptsList qemu_rbd_create_opts = { static const char *const qemu_rbd_strong_runtime_opts[] = { "pool", + "namespace", "image", "conf", "snapshot", -- 2.27.0