57 lines
1.9 KiB
Diff
57 lines
1.9 KiB
Diff
|
From 6749a16ae2e3d5aa51012bed0d9a910be8de004e Mon Sep 17 00:00:00 2001
|
||
|
From: John Snow <jsnow@redhat.com>
|
||
|
Date: Tue, 20 Nov 2018 18:18:22 +0000
|
||
|
Subject: [PATCH 28/35] bitmap: Update count after a merge
|
||
|
|
||
|
RH-Author: John Snow <jsnow@redhat.com>
|
||
|
Message-id: <20181120181828.15132-19-jsnow@redhat.com>
|
||
|
Patchwork-id: 83073
|
||
|
O-Subject: [RHEL8/rhel qemu-kvm PATCH 18/24] bitmap: Update count after a merge
|
||
|
Bugzilla: 1518989
|
||
|
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
||
|
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
||
|
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
||
|
|
||
|
From: Eric Blake <eblake@redhat.com>
|
||
|
|
||
|
We need an accurate count of the number of bits set in a bitmap
|
||
|
after a merge. In particular, since the merge operation short-circuits
|
||
|
a merge from an empty source, if you have bitmaps A, B, and C where
|
||
|
B started empty, then merge C into B, and B into A, an inaccurate
|
||
|
count meant that A did not get the contents of C.
|
||
|
|
||
|
In the worst case, we may falsely regard the bitmap as empty when
|
||
|
it has had new writes merged into it.
|
||
|
|
||
|
Fixes: be58721db
|
||
|
CC: qemu-stable@nongnu.org
|
||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||
|
Signed-off-by: John Snow <jsnow@redhat.com>
|
||
|
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
Message-id: 20181002233314.30159-1-jsnow@redhat.com
|
||
|
Signed-off-by: John Snow <jsnow@redhat.com>
|
||
|
(cherry picked from commit d1dde7149e376d72b422a529ec4bf3ed47f3ba30)
|
||
|
Signed-off-by: John Snow <jsnow@redhat.com>
|
||
|
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
||
|
---
|
||
|
util/hbitmap.c | 3 +++
|
||
|
1 file changed, 3 insertions(+)
|
||
|
|
||
|
diff --git a/util/hbitmap.c b/util/hbitmap.c
|
||
|
index d5aca51..8d402c5 100644
|
||
|
--- a/util/hbitmap.c
|
||
|
+++ b/util/hbitmap.c
|
||
|
@@ -759,6 +759,9 @@ bool hbitmap_merge(const HBitmap *a, const HBitmap *b, HBitmap *result)
|
||
|
}
|
||
|
}
|
||
|
|
||
|
+ /* Recompute the dirty count */
|
||
|
+ result->count = hb_count_between(result, 0, result->size - 1);
|
||
|
+
|
||
|
return true;
|
||
|
}
|
||
|
|
||
|
--
|
||
|
1.8.3.1
|
||
|
|