rpms/python3.11-pip
6
0
Fork 0
Code Issues Pull Requests Releases Activity

rpminspect: Disable the unicode inspection

Browse Source 
rpminspect reported:

    A forbidden code point, 0x202E, was found in the pip-23.2.1/AUTHORS.txt source file on line 482 at column 10.
    A forbidden code point, 0x202E, was found in the pip-23.2.1/AUTHORS.txt source file on line 738 at column 0.

This issue was already found and fixed upstream
when pip was added to CentOS Stream for Python 3.11.

https://github.com/pypa/pip/pull/12046

However, the fix got overridden by upstream automation (which creates the file from git log).

The regression was reported upstream in https://github.com/pypa/pip/issues/12467

The patch still applies, so we could reuse it again.
However, rpminspect then not only does not stop reporting this,
but it starts reporting the same problem for the patch:

    A forbidden code point, 0x202E, was found in the 12046.patch source file on line 19 at column 11. This source file is used by (null).
    A forbidden code point, 0x202E, was found in the 12046.patch source file on line 28 at column 1. This source file is used by (null).
    A forbidden code point, 0x202E, was found in the pip-23.2.1/AUTHORS.txt source file on line 482 at column 10. This source file is used by python3.12-pip.spec.
    A forbidden code point, 0x202E, was found in the pip-23.2.1/AUTHORS.txt source file on line 738 at column 0. This source file is used by python3.12-pip.spec.

The file is fine. It's not code.

Note that ideally, we would only exclude AUTHORS.txt, somehow like this:

    unicode:
        exclude: ^AUTHORS\.txt$

However, it does not work (at least on CentOS Zuul CI).

(cherry picked from python3.12-pip commit fd85d3c16a1de425ebb1b8973dd5777ddbc71f48)
This commit is contained in:
Miro Hrončok 2024-01-09 23:13:16 +01:00
parent 5045013e96
commit e0427e3604
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rpminspect.yaml Normal file
View File

@ -0,0 +1,5 @@
# completely disabled inspections:
inspections:
# we know about RIGHT-TO-LEFT OVERRIDE in AUTHORS.txt
# (fine tuning of this inspection does not seem to work)
unicode: off