From 7346dbcc19dbdc397f17d0f46e905d2c9fef3714 Mon Sep 17 00:00:00 2001 From: Major Hayden Date: Tue, 3 May 2022 14:15:12 -0500 Subject: [PATCH] Remove nose dependency We won't see python3-nose in epel9 and it's deprecated upstream, so remove the dependency and skip the single file that contains a few remaining nose imports. The majority of the remaining tests run without nose. Signed-off-by: Major Hayden --- python-jmespath.spec | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/python-jmespath.spec b/python-jmespath.spec index 00c9611..3631f15 100644 --- a/python-jmespath.spec +++ b/python-jmespath.spec @@ -2,7 +2,7 @@ Name: python-%{pypi_name} Version: 1.0.0 -Release: 2%{?dist} +Release: 3%{?dist} Summary: JSON Matching Expressions License: MIT @@ -26,7 +26,6 @@ BuildRequires: python3-devel BuildRequires: python3-setuptools # The tests unfortunately still import from nose, but we use pytest as test runner: -BuildRequires: python3-nose BuildRequires: python3-pytest BuildRequires: python3-hypothesis @@ -48,7 +47,10 @@ rm -rf %{pypi_name}.egg-info %py3_install %check -%pytest +# epel9 does not have python3-nose since nose is deprecated upstream. Only one file +# in the upstream repo still depends on nose, so we can omit this dependency for epel9. +# See upstream issue: https://github.com/jmespath/jmespath.py/issues/261%if 0%{?el9} +%pytest --ignore=extra/test_hypothesis.py %files -n python3-%{pypi_name} %doc README.rst @@ -58,6 +60,9 @@ rm -rf %{pypi_name}.egg-info %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info %changelog +* Tue May 03 2022 Major Hayden - 1.0.0-3 +- Remove python3-nose from BuildRequires and skip single test file that requires nose. + * Wed Apr 06 2022 Kevin Fenzi - 1.0.0-2 - Rebuild to deal with update snafu.