From f6f6766eb4715375441b95ff44fa077863ad662d Mon Sep 17 00:00:00 2001
From: Packit <hello@packit.dev>
Date: Sat, 23 Dec 2023 21:14:42 +0000
Subject: [PATCH] [packit] 0.30.1 upstream release

Upstream tag: 0.30.1
Upstream commit: 63264e18
---
 .gitignore           |  1 +
 README.packit        |  2 +-
 packit.yaml          |  2 +-
 python-dbusmock.spec | 26 +++++++++++++++++++++++++-
 sources              |  2 +-
 5 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/.gitignore b/.gitignore
index a558c08..c703413 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,3 +33,4 @@
 /python-dbusmock-0.29.0.tar.gz
 /python-dbusmock-0.29.1.tar.gz
 /python-dbusmock-0.30.0.tar.gz
+/python-dbusmock-0.30.1.tar.gz
diff --git a/README.packit b/README.packit
index ef95206..f27b296 100644
--- a/README.packit
+++ b/README.packit
@@ -1,3 +1,3 @@
 This repository is maintained by packit.
 https://packit.dev/
-The file was generated using packit 0.87.0.
+The file was generated using packit 0.87.1.post1.dev11+gd1f7091b.
diff --git a/packit.yaml b/packit.yaml
index 9c24b67..9a1cbef 100644
--- a/packit.yaml
+++ b/packit.yaml
@@ -25,7 +25,7 @@ jobs:
     - fedora-all
     - centos-stream-8-x86_64
     - centos-stream-9-x86_64
-  
+
   - job: tests
     trigger: pull_request
     targets:
diff --git a/python-dbusmock.spec b/python-dbusmock.spec
index 772af60..99b5765 100644
--- a/python-dbusmock.spec
+++ b/python-dbusmock.spec
@@ -1,7 +1,7 @@
 %global modname dbusmock
 
 Name:             python-%{modname}
-Version:          0.30.0
+Version:          0.30.1
 Release:          1%{?dist}
 Summary:          Mock D-Bus objects
 
@@ -52,6 +52,30 @@ rm -rf python-%{modname}.egg-info
 %{python3_sitelib}/*%{modname}*
 
 %changelog
+* Sat Dec 23 2023 Packit <hello@packit.dev> - 0.30.1-1
+Over the years, this template has accumulated some hacks and bad API
+which made PairDevice()'s handling of the Modalias/Class/Icon properties
+buggy and hard to understand:
+ * These are *static* device properties, they are not supposed to change
+   during pairing.
+ * Commit ee29a4403359b6a added these as some kind of "dynamic fallback
+   default" when they were not initialized by the caller after
+   AddDevice().
+ * Commit 59d6af0dca3e silently broke that fallback default by changing
+   AddDevice() to set these device properties to empty strings.
+ * Commit fae4be7f49c0861 added another really bad API for setting Class
+   in PairDevice()(). That API didn't fit into D-Bus (see commit
+   8968284e8b which had to make it a non-default parameter) and also
+   broke the API, and moreover it is totally unintuitive -- the device
+   class has nothing to do with pairing.
+Clean up all of these: Set the static property defaults in AddDevice()
+right away, so that the caller can adjust them afterwards. Re-drop the
+`class_` argument in PairDevice(). Adjust the documentation of
+AddDevice() to point out that properties should be changed after calling
+that.
+Consequently, PairDevice() will stop claiming that the static properties
+changed. This also gets rid of some redundant code.
+
 * Thu Nov 30 2023 Packit <hello@packit.dev> - 0.30.0-1
 - api: Add pytest support and helpers
 - api: Factor the server spawning into a new SpawnedMock object (thanks Peter Hutterer)
diff --git a/sources b/sources
index 98d5e1c..0b41649 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-SHA512 (python-dbusmock-0.30.0.tar.gz) = 280a8ebfe12a0f5b309d5b807547ed521c80c9899fdc89abaaee238621cf94d05f8413ab2908ca331f9d3ef1c610234dafbd912f8590f18c7d9cafe470beece6
+SHA512 (python-dbusmock-0.30.1.tar.gz) = dfa27c94d71e132ef56615cc02f2f9733ca55366b5e88f023ddc594b39c2239b460389e4b53981493d627e8c117542fa5ec82f0f4ec407ed6e825e30f5d206ae