From 99d9596d7ca30bc2cf534c283a1162ae66d915f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Thu, 6 Aug 2020 14:27:30 +0200 Subject: [PATCH] Make sure to put * in '' in %pyproject_save_files Otherwise, it may be expanded by Shell in random cases. --- README.md | 6 +++--- tests/python-ldap.spec | 2 +- tests/python-pytest.spec | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 2e64d3e..d44c3f0 100644 --- a/README.md +++ b/README.md @@ -153,15 +153,15 @@ You can use globs in the module names if listing them explicitly would be too te %install %pyproject_install - %pyproject_save_files *requests + %pyproject_save_files '*requests' -In fully automated environmets, you can use the `*` glob to include all modules. In Fedora however, you should always use a more specific glob to avoid accidentally packaging unwanted files (for example, a top level module named `test`). +In fully automated environmets, you can use the `*` glob to include all modules (put it in single quotes to prevent Shell from expanding it). In Fedora however, you should always use a more specific glob to avoid accidentally packaging unwanted files (for example, a top level module named `test`). Speaking about automated environments, some files cannot be classified with `%pyproject_save_files`, but it is possible to list all unclassified files by adding a special `+auto` argument. %install %pyproject_install - %pyproject_save_files * +auto + %pyproject_save_files '*' +auto %files -n python3-requests -f %{pyproject_files} diff --git a/tests/python-ldap.spec b/tests/python-ldap.spec index 5728c47..40a24a6 100644 --- a/tests/python-ldap.spec +++ b/tests/python-ldap.spec @@ -46,7 +46,7 @@ Summary: %{summary} %install %pyproject_install # We can pass multiple globs -%pyproject_save_files ldap* *ldap +%pyproject_save_files 'ldap*' '*ldap' %check diff --git a/tests/python-pytest.spec b/tests/python-pytest.spec index ca3c426..77e1585 100644 --- a/tests/python-pytest.spec +++ b/tests/python-pytest.spec @@ -38,7 +38,8 @@ Summary: %{summary} %install %pyproject_install -%pyproject_save_files *pytest +auto +%pyproject_save_files '*pytest' +auto + %check # Only run one test (which uses a test-only dependency, hypothesis)