import procps-ng-3.3.17-8.el9
This commit is contained in:
parent
dda5ffdb33
commit
2653bfe3f9
38
SOURCES/free-new-used-calc.patch
Normal file
38
SOURCES/free-new-used-calc.patch
Normal file
@ -0,0 +1,38 @@
|
|||||||
|
diff -up ./proc/sysinfo.c.ori ./proc/sysinfo.c
|
||||||
|
--- ./proc/sysinfo.c.ori 2021-02-09 11:11:25.000000000 +0100
|
||||||
|
+++ ./proc/sysinfo.c 2022-07-29 14:08:42.093322509 +0200
|
||||||
|
@@ -786,10 +786,8 @@ nextline:
|
||||||
|
where such values will be dramatically distorted over those of the host. */
|
||||||
|
if (kb_main_available > kb_main_total)
|
||||||
|
kb_main_available = kb_main_free;
|
||||||
|
- mem_used = kb_main_total - kb_main_free - kb_main_cached - kb_main_buffers;
|
||||||
|
- if (mem_used < 0)
|
||||||
|
- mem_used = kb_main_total - kb_main_free;
|
||||||
|
- kb_main_used = (unsigned long)mem_used;
|
||||||
|
+ mem_used = kb_main_total - kb_main_available;
|
||||||
|
+ kb_main_used = mem_used < 0 ? 0 : (unsigned long) mem_used;
|
||||||
|
|
||||||
|
/* zero? might need fallback for 2.6.27 <= kernel <? 3.14 */
|
||||||
|
if (!kb_main_available) {
|
||||||
|
diff -up ./top/top.c.ori ./top/top.c
|
||||||
|
--- ./top/top.c.ori 2021-02-09 11:11:25.000000000 +0100
|
||||||
|
+++ ./top/top.c 2022-07-29 13:59:04.681966019 +0200
|
||||||
|
@@ -6076,12 +6076,16 @@ numa_nope:
|
||||||
|
char used[SMLBUFSIZ], util[SMLBUFSIZ], dual[MEDBUFSIZ];
|
||||||
|
float pct_used, pct_misc, pct_swap;
|
||||||
|
int ix, num_used, num_misc;
|
||||||
|
+ unsigned long my_used;
|
||||||
|
|
||||||
|
- pct_used = (float)kb_main_used * (100.0 / (float)kb_main_total);
|
||||||
|
+ // upstream kept old calculation of 'used' here for some reason
|
||||||
|
+ // https://gitlab.com/procps-ng/procps/-/commit/047d16ccfda6638eda78f56b67def196a2002b6f
|
||||||
|
+ my_used = kb_main_total - kb_main_free - kb_main_cached - kb_main_buffers;
|
||||||
|
+ pct_used = (float)my_used * (100.0 / (float)kb_main_total);
|
||||||
|
#ifdef MEMGRAPH_OLD
|
||||||
|
pct_misc = (float)(kb_main_buffers + kb_main_cached) * (100.0 / (float)kb_main_total);
|
||||||
|
#else
|
||||||
|
- pct_misc = (float)(kb_main_total - kb_main_available - kb_main_used) * (100.0 / (float)kb_main_total);
|
||||||
|
+ pct_misc = (float)(kb_main_total - kb_main_available - my_used) * (100.0 / (float)kb_main_total);
|
||||||
|
#endif
|
||||||
|
if (pct_used + pct_misc > 100.0 || pct_misc < 0) pct_misc = 0;
|
||||||
|
pct_swap = kb_swap_total ? (float)kb_swap_used * (100.0 / (float)kb_swap_total) : 0;
|
72
SOURCES/pgrep-uid-gid-overflow-backport.patch
Normal file
72
SOURCES/pgrep-uid-gid-overflow-backport.patch
Normal file
@ -0,0 +1,72 @@
|
|||||||
|
From 401d587d2deb78adcf62517654f955a24b2d537d Mon Sep 17 00:00:00 2001
|
||||||
|
From: Todd Lewis <todd_lewis@unc.edu>
|
||||||
|
Date: Mon, 25 Oct 2021 19:38:10 -0400
|
||||||
|
Subject: [PATCH] fix uid/gid > 2^31
|
||||||
|
|
||||||
|
---
|
||||||
|
pgrep.c | 10 +++++++---
|
||||||
|
proc/readproc.h | 12 ++++++------
|
||||||
|
2 files changed, 13 insertions(+), 9 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/pgrep.c b/pgrep.c
|
||||||
|
index 1905cd1d..7d731620 100644
|
||||||
|
--- a/pgrep.c
|
||||||
|
+++ b/pgrep.c
|
||||||
|
@@ -229,8 +229,12 @@ static int strict_atol (const char *restrict str, long *restrict value)
|
||||||
|
|
||||||
|
for ( ; *str; ++str) {
|
||||||
|
if (! isdigit (*str))
|
||||||
|
- return (0);
|
||||||
|
+ return 0;
|
||||||
|
+ if (res >= LONG_MAX / 10)
|
||||||
|
+ return 0;
|
||||||
|
res *= 10;
|
||||||
|
+ if (res >= LONG_MAX - (*str - '0'))
|
||||||
|
+ return 0;
|
||||||
|
res += *str - '0';
|
||||||
|
}
|
||||||
|
*value = sign * res;
|
||||||
|
@@ -305,7 +309,7 @@ static int conv_uid (const char *restrict name, struct el *restrict e)
|
||||||
|
xwarnx(_("invalid user name: %s"), name);
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
- e->num = (int) pwd->pw_uid;
|
||||||
|
+ e->num = pwd->pw_uid;
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -322,7 +326,7 @@ static int conv_gid (const char *restrict name, struct el *restrict e)
|
||||||
|
xwarnx(_("invalid group name: %s"), name);
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
- e->num = (int) grp->gr_gid;
|
||||||
|
+ e->num = grp->gr_gid;
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
diff --git a/proc/readproc.h b/proc/readproc.h
|
||||||
|
index 7905ea99..8d9ae392 100644
|
||||||
|
--- a/proc/readproc.h
|
||||||
|
+++ b/proc/readproc.h
|
||||||
|
@@ -159,12 +159,12 @@ typedef struct proc_t {
|
||||||
|
session, // stat session id
|
||||||
|
nlwp, // stat,status number of threads, or 0 if no clue
|
||||||
|
tgid, // (special) thread group ID, the POSIX PID (see also: tid)
|
||||||
|
- tty, // stat full device number of controlling terminal
|
||||||
|
- /* FIXME: int uids & gids should be uid_t or gid_t from pwd.h */
|
||||||
|
- euid, egid, // stat(),status effective
|
||||||
|
- ruid, rgid, // status real
|
||||||
|
- suid, sgid, // status saved
|
||||||
|
- fuid, fgid, // status fs (used for file access only)
|
||||||
|
+ tty; // stat full device number of controlling terminal
|
||||||
|
+ uid_t euid; gid_t egid; // stat(),status effective
|
||||||
|
+ uid_t ruid; gid_t rgid; // status real
|
||||||
|
+ uid_t suid; gid_t sgid; // status saved
|
||||||
|
+ uid_t fuid; gid_t fgid; // status fs (used for file access only)
|
||||||
|
+ int
|
||||||
|
tpgid, // stat terminal process group id
|
||||||
|
exit_signal, // stat might not be SIGCHLD
|
||||||
|
processor; // stat current (or most recent?) CPU
|
||||||
|
--
|
||||||
|
GitLab
|
||||||
|
|
153
SOURCES/sysctl-print-dotted-keys-again.patch
Normal file
153
SOURCES/sysctl-print-dotted-keys-again.patch
Normal file
@ -0,0 +1,153 @@
|
|||||||
|
diff -up ./NEWS.ori ./NEWS
|
||||||
|
--- ./NEWS.ori 2022-08-15 11:59:35.929714848 +0200
|
||||||
|
+++ ./NEWS 2022-08-15 12:00:12.892937479 +0200
|
||||||
|
@@ -1,4 +1,14 @@
|
||||||
|
procps-ng-NEXT
|
||||||
|
+<<<<<<< HEAD
|
||||||
|
+=======
|
||||||
|
+ * library
|
||||||
|
+ Re-add elogind support merge #151
|
||||||
|
+ * ps: threads again display when -L is used with -q issue #234
|
||||||
|
+ * ps: proper aix format string behavior was restored
|
||||||
|
+ * sysctl: print dotted keys again
|
||||||
|
+
|
||||||
|
+procps-ng-4.0.0
|
||||||
|
+>>>>>>> b159c198 (sysctl: print dotted keys again)
|
||||||
|
---------------
|
||||||
|
* Rename pwait to pidwait
|
||||||
|
|
||||||
|
diff -up ./sysctl.c.ori ./sysctl.c
|
||||||
|
--- ./sysctl.c.ori 2022-08-15 11:59:35.934714878 +0200
|
||||||
|
+++ ./sysctl.c 2022-08-15 12:00:12.893937485 +0200
|
||||||
|
@@ -152,7 +152,7 @@ static SysctlSetting *setting_new(
|
||||||
|
strcat(path + proc_len, key+1);
|
||||||
|
else
|
||||||
|
strcat(path + proc_len, key);
|
||||||
|
- /* change . to / */
|
||||||
|
+ /* change . to / for path */
|
||||||
|
slashdot(path + proc_len, '.', '/');
|
||||||
|
|
||||||
|
s = xmalloc(sizeof(SysctlSetting));
|
||||||
|
@@ -510,7 +510,8 @@ static int WriteSetting(
|
||||||
|
|
||||||
|
int rc = EXIT_SUCCESS;
|
||||||
|
FILE *fp;
|
||||||
|
- struct stat ts;
|
||||||
|
+ struct stat ts;
|
||||||
|
+ char *dotted_key;
|
||||||
|
|
||||||
|
if (!key || !path)
|
||||||
|
return rc;
|
||||||
|
@@ -523,13 +524,22 @@ static int WriteSetting(
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
- if ((ts.st_mode & S_IWUSR) == 0) {
|
||||||
|
- xwarn(_("setting key \"%s\""), key);
|
||||||
|
+ /* Convert the globbed path into a dotted key */
|
||||||
|
+ if ( (dotted_key = strdup(path + strlen(PROC_PATH))) == NULL) {
|
||||||
|
+ xerrx(EXIT_FAILURE, _("strdup key"));
|
||||||
|
+ return EXIT_FAILURE;
|
||||||
|
+ }
|
||||||
|
+ slashdot(dotted_key, '/', '.');
|
||||||
|
+
|
||||||
|
+ if ((ts.st_mode & S_IWUSR) == 0) {
|
||||||
|
+ xwarn(_("setting key \"%s\""), dotted_key);
|
||||||
|
+ free(dotted_key);
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
- if (S_ISDIR(ts.st_mode)) {
|
||||||
|
- xwarn(_("setting key \"%s\""), key);
|
||||||
|
+ if (S_ISDIR(ts.st_mode)) {
|
||||||
|
+ xwarn(_("setting key \"%s\""), dotted_key);
|
||||||
|
+ free(dotted_key);
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -539,7 +549,7 @@ static int WriteSetting(
|
||||||
|
case ENOENT:
|
||||||
|
if (!IgnoreError) {
|
||||||
|
xwarnx(_("\"%s\" is an unknown key%s"),
|
||||||
|
- key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
+ dotted_key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
if (!ignore_failure)
|
||||||
|
rc = EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
@@ -548,11 +558,11 @@ static int WriteSetting(
|
||||||
|
case EROFS:
|
||||||
|
case EACCES:
|
||||||
|
xwarnx(_("permission denied on key \"%s\"%s"),
|
||||||
|
- key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
+ dotted_key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
xwarn(_("setting key \"%s\"%s"),
|
||||||
|
- key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
+ dotted_key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
if (!ignore_failure && errno != ENOENT)
|
||||||
|
@@ -561,7 +571,7 @@ static int WriteSetting(
|
||||||
|
if (0 < fprintf(fp, "%s\n", value))
|
||||||
|
rc = EXIT_SUCCESS;
|
||||||
|
if (close_stream(fp) != 0) {
|
||||||
|
- xwarn(_("setting key \"%s\""), path);
|
||||||
|
+ xwarn(_("setting key \"%s\""), dotted_key);
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
@@ -571,7 +581,7 @@ static int WriteSetting(
|
||||||
|
printf("%s\n", value);
|
||||||
|
} else {
|
||||||
|
if (PrintName) {
|
||||||
|
- printf("%s = %s\n", path, value);
|
||||||
|
+ printf("%s = %s\n", dotted_key, value);
|
||||||
|
} else {
|
||||||
|
if (PrintNewline)
|
||||||
|
printf("%s\n", value);
|
||||||
|
@@ -580,6 +590,7 @@ static int WriteSetting(
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
+ free(dotted_key);
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
diff -up ./testsuite/sysctl_slash_test.conf.ori ./testsuite/sysctl_slash_test.conf
|
||||||
|
--- ./testsuite/sysctl_slash_test.conf.ori 2022-08-15 12:00:12.894937491 +0200
|
||||||
|
+++ ./testsuite/sysctl_slash_test.conf 2022-08-15 12:00:12.893937485 +0200
|
||||||
|
@@ -0,0 +1 @@
|
||||||
|
+kernel/hostname = procps-test
|
||||||
|
diff -up ./testsuite/sysctl.test/sysctl_write.exp.ori ./testsuite/sysctl.test/sysctl_write.exp
|
||||||
|
--- ./testsuite/sysctl.test/sysctl_write.exp.ori 2022-08-15 11:59:35.934714878 +0200
|
||||||
|
+++ ./testsuite/sysctl.test/sysctl_write.exp 2022-08-15 12:00:12.893937485 +0200
|
||||||
|
@@ -3,11 +3,19 @@ set sysctl ${topdir}sysctl
|
||||||
|
|
||||||
|
set test "sysctl write from command line"
|
||||||
|
spawn $sysctl --dry-run kernel.hostname=procps-test
|
||||||
|
-expect_pass "$test" "/proc/sys/kernel/hostname = procps-test"
|
||||||
|
+expect_pass "$test" "kernel.hostname = procps-test"
|
||||||
|
+
|
||||||
|
+set test "sysctl write from command line using slash"
|
||||||
|
+spawn $sysctl --dry-run kernel/hostname=procps-test
|
||||||
|
+expect_pass "$test" "kernel.hostname = procps-test"
|
||||||
|
|
||||||
|
set test "sysctl write from configuration file"
|
||||||
|
spawn $sysctl --dry-run -f ${topdir}testsuite/sysctl_glob_test.conf
|
||||||
|
-expect_pass "$test" "/proc/sys/fs/protected_fifos = 2\\s+/proc/sys/fs/protected_symlinks = 2\\s+/proc/sys/fs/protected_hardlinks = 1"
|
||||||
|
+expect_pass "$test" "fs.protected_fifos = 2\\s+fs.protected_symlinks = 2\\s+fs.protected_hardlinks = 1"
|
||||||
|
+
|
||||||
|
+set test "sysctl write from file with slashes"
|
||||||
|
+spawn $sysctl --dry-run -f ${topdir}testsuite/sysctl_slash_test.conf
|
||||||
|
+expect_pass "$test" "kernel.hostname = procps-test"
|
||||||
|
|
||||||
|
set hostname_file "/proc/sys/kernel/hostname"
|
||||||
|
if {[file exists ${hostname_file}]} {
|
||||||
|
@@ -25,5 +33,5 @@ if {[file exists ${hostname_file}]} {
|
||||||
|
expect_spawn_retval "$test" 0
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
- unsupported "sysctl write: hostname file doe not exist"
|
||||||
|
+ unsupported "sysctl write: hostname file does not exist"
|
||||||
|
}
|
833
SOURCES/sysctl-support-systemd-globs.patch
Normal file
833
SOURCES/sysctl-support-systemd-globs.patch
Normal file
@ -0,0 +1,833 @@
|
|||||||
|
diff -up ./NEWS.ori ./NEWS
|
||||||
|
diff -up ./sysctl.c.ori ./sysctl.c
|
||||||
|
--- ./sysctl.c.ori 2021-02-09 11:11:25.000000000 +0100
|
||||||
|
+++ ./sysctl.c 2022-07-29 15:50:50.767380061 +0200
|
||||||
|
@@ -17,6 +17,7 @@
|
||||||
|
* along with this program; if not, write to the Free Software
|
||||||
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
||||||
|
*
|
||||||
|
+ * Part of this code comes from systemd, especially sysctl.c
|
||||||
|
* Changelog:
|
||||||
|
* v1.01:
|
||||||
|
* - added -p <preload> to preload values from a file
|
||||||
|
@@ -40,6 +41,7 @@
|
||||||
|
#include <sys/stat.h>
|
||||||
|
#include <sys/types.h>
|
||||||
|
#include <unistd.h>
|
||||||
|
+#include <ctype.h>
|
||||||
|
|
||||||
|
#include "c.h"
|
||||||
|
#include "fileutils.h"
|
||||||
|
@@ -66,12 +68,34 @@ static bool PrintName;
|
||||||
|
static bool PrintNewline;
|
||||||
|
static bool IgnoreError;
|
||||||
|
static bool Quiet;
|
||||||
|
+static bool DryRun;
|
||||||
|
static char *pattern;
|
||||||
|
|
||||||
|
#define LINELEN 4096
|
||||||
|
static char *iobuf;
|
||||||
|
static size_t iolen = LINELEN;
|
||||||
|
|
||||||
|
+typedef struct SysctlSetting {
|
||||||
|
+ char *key;
|
||||||
|
+ char *path;
|
||||||
|
+ char *value;
|
||||||
|
+ bool ignore_failure;
|
||||||
|
+ bool glob_exclude;
|
||||||
|
+ struct SysctlSetting *next;
|
||||||
|
+} SysctlSetting;
|
||||||
|
+
|
||||||
|
+typedef struct SettingList {
|
||||||
|
+ struct SysctlSetting *head;
|
||||||
|
+ struct SysctlSetting *tail;
|
||||||
|
+} SettingList;
|
||||||
|
+
|
||||||
|
+#define GLOB_CHARS "*?["
|
||||||
|
+static inline bool string_is_glob(const char *p)
|
||||||
|
+{
|
||||||
|
+ return !!strpbrk(p, GLOB_CHARS);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
/* Function prototypes. */
|
||||||
|
static int pattern_match(const char *string, const char *pat);
|
||||||
|
static int DisplayAll(const char *restrict const path);
|
||||||
|
@@ -100,6 +124,81 @@ static void slashdot(char *restrict p, c
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
+static void setting_free(SysctlSetting *s) {
|
||||||
|
+ if (!s)
|
||||||
|
+ return;
|
||||||
|
+
|
||||||
|
+ free(s->key);
|
||||||
|
+ free(s->path);
|
||||||
|
+ free(s->value);
|
||||||
|
+ free(s);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static SysctlSetting *setting_new(
|
||||||
|
+ const char *key,
|
||||||
|
+ const char *value,
|
||||||
|
+ bool ignore_failure,
|
||||||
|
+ bool glob_exclude) {
|
||||||
|
+
|
||||||
|
+ SysctlSetting *s = NULL;
|
||||||
|
+ char *path = NULL;
|
||||||
|
+ int proc_len;
|
||||||
|
+
|
||||||
|
+ proc_len = strlen(PROC_PATH);
|
||||||
|
+ /* used to open the file */
|
||||||
|
+ path = xmalloc(strlen(key) + proc_len + 2);
|
||||||
|
+ strcpy(path, PROC_PATH);
|
||||||
|
+ if (key[0] == '-')
|
||||||
|
+ strcat(path + proc_len, key+1);
|
||||||
|
+ else
|
||||||
|
+ strcat(path + proc_len, key);
|
||||||
|
+ /* change . to / */
|
||||||
|
+ slashdot(path + proc_len, '.', '/');
|
||||||
|
+
|
||||||
|
+ s = xmalloc(sizeof(SysctlSetting));
|
||||||
|
+
|
||||||
|
+ *s = (SysctlSetting) {
|
||||||
|
+ .key = strdup(key),
|
||||||
|
+ .path = path,
|
||||||
|
+ .value = value? strdup(value): NULL,
|
||||||
|
+ .ignore_failure = ignore_failure,
|
||||||
|
+ .glob_exclude = glob_exclude,
|
||||||
|
+ .next = NULL,
|
||||||
|
+ };
|
||||||
|
+
|
||||||
|
+ return s;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static void settinglist_add(SettingList *l, SysctlSetting *s) {
|
||||||
|
+ SysctlSetting *old_tail;
|
||||||
|
+
|
||||||
|
+ if (!l)
|
||||||
|
+ return;
|
||||||
|
+
|
||||||
|
+ if (l->head == NULL)
|
||||||
|
+ l->head = s;
|
||||||
|
+
|
||||||
|
+ if (l->tail != NULL) {
|
||||||
|
+ old_tail = l->tail;
|
||||||
|
+ old_tail->next = s;
|
||||||
|
+ }
|
||||||
|
+ l->tail = s;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static SysctlSetting *settinglist_findpath(const SettingList *l, const char *path) {
|
||||||
|
+ SysctlSetting *node;
|
||||||
|
+
|
||||||
|
+ for (node=l->head; node != NULL; node = node->next) {
|
||||||
|
+ if (strcmp(node->path, path) == 0)
|
||||||
|
+ return node;
|
||||||
|
+ }
|
||||||
|
+ return NULL;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+/* Function prototypes. */
|
||||||
|
+static int pattern_match(const char *string, const char *pat);
|
||||||
|
+static int DisplayAll(const char *restrict const path);
|
||||||
|
+
|
||||||
|
/*
|
||||||
|
* Display the usage format
|
||||||
|
*/
|
||||||
|
@@ -115,6 +214,7 @@ static void __attribute__ ((__noreturn__
|
||||||
|
fputs(_(" -A alias of -a\n"), out);
|
||||||
|
fputs(_(" -X alias of -a\n"), out);
|
||||||
|
fputs(_(" --deprecated include deprecated parameters to listing\n"), out);
|
||||||
|
+ fputs(_(" --dry-run Print the key and values but do not write\n"), out);
|
||||||
|
fputs(_(" -b, --binary print value without new line\n"), out);
|
||||||
|
fputs(_(" -e, --ignore ignore unknown variables errors\n"), out);
|
||||||
|
fputs(_(" -N, --names print variable names without values\n"), out);
|
||||||
|
@@ -138,6 +238,39 @@ static void __attribute__ ((__noreturn__
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
+ * Strip left/leading side of a string
|
||||||
|
+ */
|
||||||
|
+static char *lstrip(char *line)
|
||||||
|
+{
|
||||||
|
+ char *start;
|
||||||
|
+
|
||||||
|
+ if (!line || !*line)
|
||||||
|
+ return line;
|
||||||
|
+
|
||||||
|
+ start = line;
|
||||||
|
+ while(isspace(*start)) start++;
|
||||||
|
+
|
||||||
|
+ return start;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+/*
|
||||||
|
+ * Strip right/trailing side of a string
|
||||||
|
+ * by placing a \0
|
||||||
|
+ */
|
||||||
|
+static void rstrip(char *line)
|
||||||
|
+{
|
||||||
|
+ char *end;
|
||||||
|
+
|
||||||
|
+ if (!line || !*line)
|
||||||
|
+ return;
|
||||||
|
+
|
||||||
|
+ end = line + strlen(line) - 1;
|
||||||
|
+ while(end > line && isspace(*end)) end--;
|
||||||
|
+
|
||||||
|
+ end[1] = '\0';
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+/*
|
||||||
|
* Strip the leading and trailing spaces from a string
|
||||||
|
*/
|
||||||
|
static char *StripLeadingAndTrailingSpaces(char *oneline)
|
||||||
|
@@ -166,7 +299,7 @@ static char *StripLeadingAndTrailingSpac
|
||||||
|
*/
|
||||||
|
static int ReadSetting(const char *restrict const name)
|
||||||
|
{
|
||||||
|
- int rc = 0;
|
||||||
|
+ int rc = EXIT_SUCCESS;
|
||||||
|
char *restrict tmpname;
|
||||||
|
char *restrict outname;
|
||||||
|
ssize_t rlen;
|
||||||
|
@@ -198,7 +331,7 @@ static int ReadSetting(const char *restr
|
||||||
|
if (stat(tmpname, &ts) < 0) {
|
||||||
|
if (!IgnoreError) {
|
||||||
|
xwarn(_("cannot stat %s"), tmpname);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
@@ -215,7 +348,7 @@ static int ReadSetting(const char *restr
|
||||||
|
}
|
||||||
|
|
||||||
|
if (pattern && !pattern_match(outname, pattern)) {
|
||||||
|
- rc = 0;
|
||||||
|
+ rc = EXIT_SUCCESS;
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -231,19 +364,19 @@ static int ReadSetting(const char *restr
|
||||||
|
case ENOENT:
|
||||||
|
if (!IgnoreError) {
|
||||||
|
xwarnx(_("\"%s\" is an unknown key"), outname);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
case EACCES:
|
||||||
|
xwarnx(_("permission denied on key '%s'"), outname);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
break;
|
||||||
|
case EIO: /* Ignore stable_secret below /proc/sys/net/ipv6/conf */
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
xwarn(_("reading key \"%s\""), outname);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
@@ -279,7 +412,7 @@ static int ReadSetting(const char *restr
|
||||||
|
case EACCES:
|
||||||
|
xwarnx(_("permission denied on key '%s'"),
|
||||||
|
outname);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
break;
|
||||||
|
case EISDIR: {
|
||||||
|
size_t len;
|
||||||
|
@@ -291,11 +424,11 @@ static int ReadSetting(const char *restr
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
case EIO: /* Ignore stable_secret below /proc/sys/net/ipv6/conf */
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
xwarnx(_("reading key \"%s\""), outname);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
case 0:
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
@@ -323,7 +456,7 @@ static int is_deprecated(char *filename)
|
||||||
|
*/
|
||||||
|
static int DisplayAll(const char *restrict const path)
|
||||||
|
{
|
||||||
|
- int rc = 0;
|
||||||
|
+ int rc = EXIT_SUCCESS;
|
||||||
|
int rc2;
|
||||||
|
DIR *restrict dp;
|
||||||
|
struct dirent *restrict de;
|
||||||
|
@@ -333,7 +466,7 @@ static int DisplayAll(const char *restri
|
||||||
|
|
||||||
|
if (!dp) {
|
||||||
|
xwarnx(_("unable to open directory \"%s\""), path);
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
} else {
|
||||||
|
readdir(dp); /* skip . */
|
||||||
|
readdir(dp); /* skip .. */
|
||||||
|
@@ -369,130 +502,183 @@ static int DisplayAll(const char *restri
|
||||||
|
/*
|
||||||
|
* Write a sysctl setting
|
||||||
|
*/
|
||||||
|
-static int WriteSetting(const char *setting)
|
||||||
|
-{
|
||||||
|
- int rc = 0;
|
||||||
|
- const char *name = setting;
|
||||||
|
- const char *value;
|
||||||
|
- const char *equals;
|
||||||
|
- char *tmpname;
|
||||||
|
- char *outname;
|
||||||
|
- char *last_dot;
|
||||||
|
- bool ignore_failure;
|
||||||
|
+static int WriteSetting(
|
||||||
|
+ const char *key,
|
||||||
|
+ const char *path,
|
||||||
|
+ const char *value,
|
||||||
|
+ const bool ignore_failure) {
|
||||||
|
|
||||||
|
- FILE *fp;
|
||||||
|
+ int rc = EXIT_SUCCESS;
|
||||||
|
+ FILE *fp;
|
||||||
|
struct stat ts;
|
||||||
|
|
||||||
|
- if (!name)
|
||||||
|
- /* probably don't want to display this err */
|
||||||
|
- return 0;
|
||||||
|
-
|
||||||
|
- equals = strchr(setting, '=');
|
||||||
|
-
|
||||||
|
- if (!equals) {
|
||||||
|
- xwarnx(_("\"%s\" must be of the form name=value"),
|
||||||
|
- setting);
|
||||||
|
- return -1;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- /* point to the value in name=value */
|
||||||
|
- value = equals + 1;
|
||||||
|
-
|
||||||
|
- if (!*name || name == equals) {
|
||||||
|
- xwarnx(_("malformed setting \"%s\""), setting);
|
||||||
|
- return -2;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- ignore_failure = name[0] == '-';
|
||||||
|
- if (ignore_failure)
|
||||||
|
- name++;
|
||||||
|
+ if (!key || !path)
|
||||||
|
+ return rc;
|
||||||
|
|
||||||
|
- /* used to open the file */
|
||||||
|
- tmpname = xmalloc(equals - name + 1 + strlen(PROC_PATH));
|
||||||
|
- strcpy(tmpname, PROC_PATH);
|
||||||
|
- strncat(tmpname, name, (int) (equals - name));
|
||||||
|
- tmpname[equals - name + strlen(PROC_PATH)] = 0;
|
||||||
|
- /* change . to / */
|
||||||
|
- slashdot(tmpname + strlen(PROC_PATH), '.', '/');
|
||||||
|
-
|
||||||
|
- /* used to display the output */
|
||||||
|
- outname = xmalloc(equals - name + 1);
|
||||||
|
- strncpy(outname, name, (int) (equals - name));
|
||||||
|
- outname[equals - name] = 0;
|
||||||
|
- /* change / to . */
|
||||||
|
- slashdot(outname, '/', '.');
|
||||||
|
- last_dot = strrchr(outname, '.');
|
||||||
|
- if (last_dot != NULL && is_deprecated(last_dot + 1)) {
|
||||||
|
- xwarnx(_("%s is deprecated, value not set"), outname);
|
||||||
|
- goto out;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- if (stat(tmpname, &ts) < 0) {
|
||||||
|
+ if (stat(path, &ts) < 0) {
|
||||||
|
if (!IgnoreError) {
|
||||||
|
- xwarn(_("cannot stat %s"), tmpname);
|
||||||
|
- rc = -1;
|
||||||
|
+ xwarn(_("cannot stat %s"), path);
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
- goto out;
|
||||||
|
+ return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((ts.st_mode & S_IWUSR) == 0) {
|
||||||
|
- xwarn(_("setting key \"%s\""), outname);
|
||||||
|
- goto out;
|
||||||
|
+ xwarn(_("setting key \"%s\""), key);
|
||||||
|
+ return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (S_ISDIR(ts.st_mode)) {
|
||||||
|
- xwarn(_("setting key \"%s\""), outname);
|
||||||
|
- goto out;
|
||||||
|
+ xwarn(_("setting key \"%s\""), key);
|
||||||
|
+ return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
- fp = fprocopen(tmpname, "w");
|
||||||
|
-
|
||||||
|
- if (!fp) {
|
||||||
|
- switch (errno) {
|
||||||
|
- case ENOENT:
|
||||||
|
- if (!IgnoreError) {
|
||||||
|
- xwarnx(_("\"%s\" is an unknown key%s"), outname, (ignore_failure?_(", ignoring"):""));
|
||||||
|
+ if (!DryRun) {
|
||||||
|
+ if ((fp = fprocopen(path, "w")) == NULL) {
|
||||||
|
+ switch (errno) {
|
||||||
|
+ case ENOENT:
|
||||||
|
+ if (!IgnoreError) {
|
||||||
|
+ xwarnx(_("\"%s\" is an unknown key%s"),
|
||||||
|
+ key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
if (!ignore_failure)
|
||||||
|
- rc = -1;
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
- case EPERM:
|
||||||
|
- case EROFS:
|
||||||
|
- case EACCES:
|
||||||
|
- xwarnx(_("permission denied on key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):""));
|
||||||
|
- break;
|
||||||
|
- default:
|
||||||
|
- xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):""));
|
||||||
|
- break;
|
||||||
|
- }
|
||||||
|
- if (!ignore_failure && errno != ENOENT)
|
||||||
|
- rc = -1;
|
||||||
|
- } else {
|
||||||
|
- rc = fprintf(fp, "%s\n", value);
|
||||||
|
- if (0 < rc)
|
||||||
|
- rc = 0;
|
||||||
|
- if (close_stream(fp) != 0)
|
||||||
|
- xwarn(_("setting key \"%s\""), outname);
|
||||||
|
- else if (rc == 0 && !Quiet) {
|
||||||
|
- if (NameOnly) {
|
||||||
|
- fprintf(stdout, "%s\n", outname);
|
||||||
|
- } else {
|
||||||
|
- if (PrintName) {
|
||||||
|
- fprintf(stdout, "%s = %s\n",
|
||||||
|
- outname, value);
|
||||||
|
- } else {
|
||||||
|
- if (PrintNewline)
|
||||||
|
- fprintf(stdout, "%s\n", value);
|
||||||
|
- else
|
||||||
|
- fprintf(stdout, "%s", value);
|
||||||
|
- }
|
||||||
|
- }
|
||||||
|
- }
|
||||||
|
- }
|
||||||
|
- out:
|
||||||
|
- free(tmpname);
|
||||||
|
- free(outname);
|
||||||
|
- return rc;
|
||||||
|
+ case EPERM:
|
||||||
|
+ case EROFS:
|
||||||
|
+ case EACCES:
|
||||||
|
+ xwarnx(_("permission denied on key \"%s\"%s"),
|
||||||
|
+ key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
+ break;
|
||||||
|
+ default:
|
||||||
|
+ xwarn(_("setting key \"%s\"%s"),
|
||||||
|
+ key, (ignore_failure?_(", ignoring"):""));
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+ if (!ignore_failure && errno != ENOENT)
|
||||||
|
+ rc = EXIT_FAILURE;
|
||||||
|
+ } else {
|
||||||
|
+ if (0 < fprintf(fp, "%s\n", value))
|
||||||
|
+ rc = EXIT_SUCCESS;
|
||||||
|
+ if (close_stream(fp) != 0) {
|
||||||
|
+ xwarn(_("setting key \"%s\""), path);
|
||||||
|
+ return rc;
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ if ((rc == EXIT_SUCCESS && !Quiet) || DryRun) {
|
||||||
|
+ if (NameOnly) {
|
||||||
|
+ printf("%s\n", value);
|
||||||
|
+ } else {
|
||||||
|
+ if (PrintName) {
|
||||||
|
+ printf("%s = %s\n", path, value);
|
||||||
|
+ } else {
|
||||||
|
+ if (PrintNewline)
|
||||||
|
+ printf("%s\n", value);
|
||||||
|
+ else
|
||||||
|
+ printf("%s", value);
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ return rc;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+/*
|
||||||
|
+ * parse each configuration line, there are multiple ways of specifying
|
||||||
|
+ * a key/value here:
|
||||||
|
+ *
|
||||||
|
+ * key = value simple setting
|
||||||
|
+ * -key = value ignore errors
|
||||||
|
+ * key.pattern.*.with.glob = value set keys that match glob
|
||||||
|
+ * -key.pattern.exclude.with.glob dont set this value
|
||||||
|
+ * key.pattern.override.with.glob = value set this glob match to value
|
||||||
|
+ *
|
||||||
|
+ */
|
||||||
|
+
|
||||||
|
+static SysctlSetting *parse_setting_line(
|
||||||
|
+ const char *path,
|
||||||
|
+ const int linenum,
|
||||||
|
+ char *line)
|
||||||
|
+{
|
||||||
|
+ SysctlSetting *s;
|
||||||
|
+ char *key;
|
||||||
|
+ char *value;
|
||||||
|
+ bool glob_exclude = FALSE;
|
||||||
|
+ bool ignore_failure = FALSE;
|
||||||
|
+
|
||||||
|
+ key = lstrip(line);
|
||||||
|
+ if (strlen(key) < 2)
|
||||||
|
+ return NULL;
|
||||||
|
+
|
||||||
|
+ /* skip over comments */
|
||||||
|
+ if (key[0] == '#' || key[0] == ';')
|
||||||
|
+ return NULL;
|
||||||
|
+
|
||||||
|
+ if (pattern && !pattern_match(key, pattern))
|
||||||
|
+ return NULL;
|
||||||
|
+
|
||||||
|
+ value = strchr(key, '=');
|
||||||
|
+ if (value == NULL) {
|
||||||
|
+ if (key[0] == '-') {
|
||||||
|
+ glob_exclude = TRUE;
|
||||||
|
+ key++;
|
||||||
|
+ value = NULL;
|
||||||
|
+ rstrip(key);
|
||||||
|
+ } else {
|
||||||
|
+ xwarnx(_("%s(%d): invalid syntax, continuing..."),
|
||||||
|
+ path, linenum);
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+ } else {
|
||||||
|
+ value[0]='\0';
|
||||||
|
+ if (key[0] == '-') {
|
||||||
|
+ ignore_failure = TRUE;
|
||||||
|
+ key++;
|
||||||
|
+ }
|
||||||
|
+ value++; // skip over =
|
||||||
|
+ value=lstrip(value);
|
||||||
|
+ rstrip(value);
|
||||||
|
+ rstrip(key);
|
||||||
|
+ }
|
||||||
|
+ return setting_new(key, value, ignore_failure, glob_exclude);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+/* Go through the setting list, expand and sort out
|
||||||
|
+ * setting globs and actually write the settings out
|
||||||
|
+ */
|
||||||
|
+static int write_setting_list(const SettingList *sl)
|
||||||
|
+{
|
||||||
|
+ SysctlSetting *node;
|
||||||
|
+ int rc = EXIT_SUCCESS;
|
||||||
|
+
|
||||||
|
+ for (node=sl->head; node != NULL; node=node->next) {
|
||||||
|
+ if (node->glob_exclude)
|
||||||
|
+ continue;
|
||||||
|
+
|
||||||
|
+ if (string_is_glob(node->path)) {
|
||||||
|
+ char *gl_path;
|
||||||
|
+ glob_t globbuf;
|
||||||
|
+ int i;
|
||||||
|
+
|
||||||
|
+ if (glob(node->path, 0, NULL, &globbuf) != 0)
|
||||||
|
+ continue;
|
||||||
|
+
|
||||||
|
+ for(i=0; i < globbuf.gl_pathc; i++) {
|
||||||
|
+ if (settinglist_findpath(sl, globbuf.gl_pathv[i]))
|
||||||
|
+ continue; // override or exclude
|
||||||
|
+
|
||||||
|
+ rc |= WriteSetting(node->key, globbuf.gl_pathv[i], node->value,
|
||||||
|
+ node->ignore_failure);
|
||||||
|
+ }
|
||||||
|
+ } else {
|
||||||
|
+ rc |= WriteSetting(node->key, node->path, node->value,
|
||||||
|
+ node->ignore_failure);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
static int pattern_match(const char *string, const char *pat)
|
||||||
|
@@ -513,12 +699,12 @@ static int pattern_match(const char *str
|
||||||
|
* Preload the sysctl's from the conf file. We parse the file and then
|
||||||
|
* reform it (strip out whitespace).
|
||||||
|
*/
|
||||||
|
-static int Preload(const char *restrict const filename)
|
||||||
|
+static int Preload(SettingList *setlist, const char *restrict const filename)
|
||||||
|
{
|
||||||
|
FILE *fp;
|
||||||
|
char *t;
|
||||||
|
int n = 0;
|
||||||
|
- int rc = 0;
|
||||||
|
+ int rc = EXIT_SUCCESS;
|
||||||
|
ssize_t rlen;
|
||||||
|
char *name, *value;
|
||||||
|
glob_t globbuf;
|
||||||
|
@@ -547,62 +733,26 @@ static int Preload(const char *restrict
|
||||||
|
? stdin : fopen(globbuf.gl_pathv[j], "r");
|
||||||
|
if (!fp) {
|
||||||
|
xwarn(_("cannot open \"%s\""), globbuf.gl_pathv[j]);
|
||||||
|
- rc = -1;
|
||||||
|
- goto out;
|
||||||
|
+ return EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
while ((rlen = getline(&iobuf, &iolen, fp)) > 0) {
|
||||||
|
size_t offset;
|
||||||
|
+ SysctlSetting *setting;
|
||||||
|
|
||||||
|
n++;
|
||||||
|
|
||||||
|
if (rlen < 2)
|
||||||
|
continue;
|
||||||
|
|
||||||
|
- t = StripLeadingAndTrailingSpaces(iobuf);
|
||||||
|
- if (strlen(t) < 2)
|
||||||
|
- continue;
|
||||||
|
-
|
||||||
|
- if (*t == '#' || *t == ';')
|
||||||
|
- continue;
|
||||||
|
-
|
||||||
|
- name = strtok(t, "=");
|
||||||
|
- if (!name || !*name) {
|
||||||
|
- xwarnx(_("%s(%d): invalid syntax, continuing..."),
|
||||||
|
- globbuf.gl_pathv[j], n);
|
||||||
|
- continue;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- StripLeadingAndTrailingSpaces(name);
|
||||||
|
-
|
||||||
|
- if (pattern && !pattern_match(name, pattern))
|
||||||
|
- continue;
|
||||||
|
-
|
||||||
|
- offset = strlen(name);
|
||||||
|
- memmove(&iobuf[0], name, offset);
|
||||||
|
- iobuf[offset++] = '=';
|
||||||
|
-
|
||||||
|
- value = strtok(NULL, "\n\r");
|
||||||
|
- if (!value || !*value) {
|
||||||
|
- xwarnx(_("%s(%d): invalid syntax, continuing..."),
|
||||||
|
- globbuf.gl_pathv[j], n);
|
||||||
|
- continue;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- while ((*value == ' ' || *value == '\t') && *value != 0)
|
||||||
|
- value++;
|
||||||
|
-
|
||||||
|
- /* should NameOnly affect this? */
|
||||||
|
- memmove(&iobuf[offset], value, strlen(value));
|
||||||
|
- offset += strlen(value);
|
||||||
|
- iobuf[offset] = '\0';
|
||||||
|
-
|
||||||
|
- rc |= WriteSetting(iobuf);
|
||||||
|
+ if ( (setting = parse_setting_line(globbuf.gl_pathv[j], n, iobuf))
|
||||||
|
+ == NULL)
|
||||||
|
+ continue;
|
||||||
|
+ settinglist_add(setlist, setting);
|
||||||
|
}
|
||||||
|
|
||||||
|
fclose(fp);
|
||||||
|
}
|
||||||
|
-out:
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -618,7 +768,7 @@ static int sortpairs(const void *A, cons
|
||||||
|
return strcmp(a->name, b->name);
|
||||||
|
}
|
||||||
|
|
||||||
|
-static int PreloadSystem(void)
|
||||||
|
+static int PreloadSystem(SettingList *setlist)
|
||||||
|
{
|
||||||
|
unsigned di, i;
|
||||||
|
const char *dirs[] = {
|
||||||
|
@@ -630,7 +780,7 @@ static int PreloadSystem(void)
|
||||||
|
};
|
||||||
|
struct pair **cfgs = NULL;
|
||||||
|
unsigned ncfgs = 0;
|
||||||
|
- int rc = 0;
|
||||||
|
+ int rc = EXIT_SUCCESS;
|
||||||
|
struct stat ts;
|
||||||
|
enum { nprealloc = 16 };
|
||||||
|
|
||||||
|
@@ -688,14 +838,14 @@ static int PreloadSystem(void)
|
||||||
|
for (i = 0; i < ncfgs; ++i) {
|
||||||
|
if (!Quiet)
|
||||||
|
printf(_("* Applying %s ...\n"), cfgs[i]->value);
|
||||||
|
- rc |= Preload(cfgs[i]->value);
|
||||||
|
+ rc |= Preload(setlist, cfgs[i]->value);
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
if (stat(DEFAULT_PRELOAD, &ts) == 0 && S_ISREG(ts.st_mode)) {
|
||||||
|
if (!Quiet)
|
||||||
|
printf(_("* Applying %s ...\n"), DEFAULT_PRELOAD);
|
||||||
|
- rc |= Preload(DEFAULT_PRELOAD);
|
||||||
|
+ rc |= Preload(setlist, DEFAULT_PRELOAD);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* cleaning */
|
||||||
|
@@ -717,15 +867,19 @@ int main(int argc, char *argv[])
|
||||||
|
bool preloadfileOpt = false;
|
||||||
|
int ReturnCode = 0;
|
||||||
|
int c;
|
||||||
|
+ int rc;
|
||||||
|
const char *preloadfile = NULL;
|
||||||
|
+ SettingList *setlist;
|
||||||
|
|
||||||
|
enum {
|
||||||
|
DEPRECATED_OPTION = CHAR_MAX + 1,
|
||||||
|
- SYSTEM_OPTION
|
||||||
|
+ SYSTEM_OPTION,
|
||||||
|
+ DRYRUN_OPTION
|
||||||
|
};
|
||||||
|
static const struct option longopts[] = {
|
||||||
|
{"all", no_argument, NULL, 'a'},
|
||||||
|
{"deprecated", no_argument, NULL, DEPRECATED_OPTION},
|
||||||
|
+ {"dry-run", no_argument, NULL, DRYRUN_OPTION},
|
||||||
|
{"binary", no_argument, NULL, 'b'},
|
||||||
|
{"ignore", no_argument, NULL, 'e'},
|
||||||
|
{"names", no_argument, NULL, 'N'},
|
||||||
|
@@ -753,6 +907,10 @@ int main(int argc, char *argv[])
|
||||||
|
IgnoreError = false;
|
||||||
|
Quiet = false;
|
||||||
|
IgnoreDeprecated = true;
|
||||||
|
+ DryRun = false;
|
||||||
|
+ setlist = xmalloc(sizeof(SettingList));
|
||||||
|
+ setlist->head = NULL;
|
||||||
|
+ setlist->tail = NULL;
|
||||||
|
|
||||||
|
if (argc < 2)
|
||||||
|
Usage(stderr);
|
||||||
|
@@ -805,7 +963,12 @@ int main(int argc, char *argv[])
|
||||||
|
break;
|
||||||
|
case SYSTEM_OPTION:
|
||||||
|
IgnoreError = true;
|
||||||
|
- return PreloadSystem();
|
||||||
|
+ rc |= PreloadSystem(setlist);
|
||||||
|
+ rc |= write_setting_list(setlist);
|
||||||
|
+ return rc;
|
||||||
|
+ case DRYRUN_OPTION:
|
||||||
|
+ DryRun = true;
|
||||||
|
+ break;
|
||||||
|
case 'r':
|
||||||
|
pattern = xstrdup(optarg);
|
||||||
|
break;
|
||||||
|
@@ -833,15 +996,16 @@ int main(int argc, char *argv[])
|
||||||
|
int ret = EXIT_SUCCESS, i;
|
||||||
|
if (!preloadfile) {
|
||||||
|
if (!argc) {
|
||||||
|
- ret |= Preload(DEFAULT_PRELOAD);
|
||||||
|
+ ret |= Preload(setlist, DEFAULT_PRELOAD);
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
/* This happens when -pfile option is
|
||||||
|
* used without space. */
|
||||||
|
- ret |= Preload(preloadfile);
|
||||||
|
+ ret |= Preload(setlist, preloadfile);
|
||||||
|
}
|
||||||
|
for (i = 0; i < argc; i++)
|
||||||
|
- ret |= Preload(argv[i]);
|
||||||
|
+ ret |= Preload(setlist, argv[i]);
|
||||||
|
+ ret |= write_setting_list(setlist);
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -855,9 +1019,14 @@ int main(int argc, char *argv[])
|
||||||
|
program_invocation_short_name);
|
||||||
|
|
||||||
|
for ( ; *argv; argv++) {
|
||||||
|
- if (WriteMode || strchr(*argv, '='))
|
||||||
|
- ReturnCode += WriteSetting(*argv);
|
||||||
|
- else
|
||||||
|
+ if (WriteMode || strchr(*argv, '=')) {
|
||||||
|
+ SysctlSetting *s;
|
||||||
|
+ if ( (s = parse_setting_line("command line", 0, *argv)) != NULL)
|
||||||
|
+ ReturnCode |= WriteSetting(s->key, s->path, s->value,
|
||||||
|
+ s->ignore_failure);
|
||||||
|
+ else
|
||||||
|
+ ReturnCode |= EXIT_FAILURE;
|
||||||
|
+ } else
|
||||||
|
ReturnCode += ReadSetting(*argv);
|
||||||
|
}
|
||||||
|
return ReturnCode;
|
||||||
|
diff -up ./testsuite/config/unix.exp.ori ./testsuite/config/unix.exp
|
||||||
|
--- ./testsuite/config/unix.exp.ori 2021-02-09 11:11:25.000000000 +0100
|
||||||
|
+++ ./testsuite/config/unix.exp 2022-07-29 15:50:50.768380067 +0200
|
||||||
|
@@ -136,6 +136,15 @@ proc expect_table_dsc { test match_heade
|
||||||
|
#}
|
||||||
|
}
|
||||||
|
|
||||||
|
+proc expect_spawn_retval { test retval } {
|
||||||
|
+ foreach {pid spawnid os_error_flag value} [wait] break
|
||||||
|
+
|
||||||
|
+ if {$value == $retval} {
|
||||||
|
+ return
|
||||||
|
+ }
|
||||||
|
+ fail "$test (exit value)"
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
proc make_pipeproc { } {
|
||||||
|
global pipeproc_pid pipeproc_spawnid topdir
|
||||||
|
|
||||||
|
diff -up ./testsuite/sysctl_glob_test.conf.ori ./testsuite/sysctl_glob_test.conf
|
||||||
|
--- ./testsuite/sysctl_glob_test.conf.ori 2022-07-29 15:50:50.768380067 +0200
|
||||||
|
+++ ./testsuite/sysctl_glob_test.conf 2022-07-29 15:50:50.768380067 +0200
|
||||||
|
@@ -0,0 +1,6 @@
|
||||||
|
+#
|
||||||
|
+# Test configuration for for glob in sysctl
|
||||||
|
+#
|
||||||
|
+fs.protected_* = 2
|
||||||
|
+fs.protected_hardlinks = 1
|
||||||
|
+-fs.protected_regular
|
||||||
|
diff -up ./testsuite/sysctl.test/sysctl_write.exp.ori ./testsuite/sysctl.test/sysctl_write.exp
|
||||||
|
--- ./testsuite/sysctl.test/sysctl_write.exp.ori 2022-07-29 15:50:50.768380067 +0200
|
||||||
|
+++ ./testsuite/sysctl.test/sysctl_write.exp 2022-07-29 15:50:50.768380067 +0200
|
||||||
|
@@ -0,0 +1,29 @@
|
||||||
|
+
|
||||||
|
+set sysctl ${topdir}sysctl
|
||||||
|
+
|
||||||
|
+set test "sysctl write from command line"
|
||||||
|
+spawn $sysctl --dry-run kernel.hostname=procps-test
|
||||||
|
+expect_pass "$test" "/proc/sys/kernel/hostname = procps-test"
|
||||||
|
+
|
||||||
|
+set test "sysctl write from configuration file"
|
||||||
|
+spawn $sysctl --dry-run -f ${topdir}testsuite/sysctl_glob_test.conf
|
||||||
|
+expect_pass "$test" "/proc/sys/fs/protected_fifos = 2\\s+/proc/sys/fs/protected_symlinks = 2\\s+/proc/sys/fs/protected_hardlinks = 1"
|
||||||
|
+
|
||||||
|
+set hostname_file "/proc/sys/kernel/hostname"
|
||||||
|
+if {[file exists ${hostname_file}]} {
|
||||||
|
+ if {[file writable ${hostname_file}]} {
|
||||||
|
+ unsupported "sysctl write: hostname file is writable"
|
||||||
|
+ } else {
|
||||||
|
+ set test "sysctl write unwritable file"
|
||||||
|
+ spawn $sysctl -q kernel.hostname=procpstest
|
||||||
|
+ expect_pass "$test" "sysctl: permission denied on key \"kernel.hostname\"\\s*$"
|
||||||
|
+ expect_spawn_retval "$test" 1
|
||||||
|
+
|
||||||
|
+ set test "sysctl write unwritable file ignored"
|
||||||
|
+ spawn $sysctl -q -- -kernel.hostname=procpstest
|
||||||
|
+ expect_pass "$test" "sysctl: permission denied on key \"kernel.hostname\", ignoring\\s*$"
|
||||||
|
+ expect_spawn_retval "$test" 0
|
||||||
|
+ }
|
||||||
|
+} else {
|
||||||
|
+ unsupported "sysctl write: hostname file doe not exist"
|
||||||
|
+}
|
40
SOURCES/uptime-pretty-mod.patch
Normal file
40
SOURCES/uptime-pretty-mod.patch
Normal file
@ -0,0 +1,40 @@
|
|||||||
|
From 7eade2544e1c45bc516744aeaccc45df1d8f42df Mon Sep 17 00:00:00 2001
|
||||||
|
From: Kyle Walker <kwalker@redhat.com>
|
||||||
|
Date: Tue, 11 Feb 2020 14:30:39 -0500
|
||||||
|
Subject: [PATCH] whattime: Refactor the pretty-print evaluation
|
||||||
|
|
||||||
|
This avoids rounding errors such as in the case of 364 days of uptime which
|
||||||
|
results in only output that prints at the hour and below.
|
||||||
|
---
|
||||||
|
proc/whattime.c | 15 ++++++++++++---
|
||||||
|
1 file changed, 12 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/proc/whattime.c b/proc/whattime.c
|
||||||
|
index c223cad..3e1b65c 100644
|
||||||
|
--- a/proc/whattime.c
|
||||||
|
+++ b/proc/whattime.c
|
||||||
|
@@ -69,9 +69,18 @@ char *sprint_uptime(int human_readable) {
|
||||||
|
|
||||||
|
if (human_readable) {
|
||||||
|
updecades = (int) uptime_secs / (60*60*24*365*10);
|
||||||
|
- upyears = ((int) uptime_secs / (60*60*24*365)) % 10;
|
||||||
|
- upweeks = ((int) uptime_secs / (60*60*24*7)) % 52;
|
||||||
|
- updays = ((int) uptime_secs / (60*60*24)) % 7;
|
||||||
|
+ if (updecades)
|
||||||
|
+ uptime_secs -= updecades * (60*60*24*365*10);
|
||||||
|
+
|
||||||
|
+ upyears = (int) uptime_secs / (60*60*24*365);
|
||||||
|
+ if (upyears)
|
||||||
|
+ uptime_secs -= upyears * (60*60*24*365);
|
||||||
|
+
|
||||||
|
+ upweeks = (int) uptime_secs / (60*60*24*7);
|
||||||
|
+ if (upweeks)
|
||||||
|
+ uptime_secs -= upweeks * (60*60*24*7);
|
||||||
|
+
|
||||||
|
+ updays = (int) uptime_secs / (60*60*24);
|
||||||
|
}
|
||||||
|
else
|
||||||
|
updays = (int) uptime_secs / (60*60*24);
|
||||||
|
--
|
||||||
|
2.24.1
|
||||||
|
|
@ -4,7 +4,7 @@
|
|||||||
Summary: System and process monitoring utilities
|
Summary: System and process monitoring utilities
|
||||||
Name: procps-ng
|
Name: procps-ng
|
||||||
Version: 3.3.17
|
Version: 3.3.17
|
||||||
Release: 4%{?dist}
|
Release: 8%{?dist}
|
||||||
License: GPL+ and GPLv2 and GPLv2+ and GPLv3+ and LGPLv2+
|
License: GPL+ and GPLv2 and GPLv2+ and GPLv3+ and LGPLv2+
|
||||||
URL: https://sourceforge.net/projects/procps-ng/
|
URL: https://sourceforge.net/projects/procps-ng/
|
||||||
|
|
||||||
@ -17,6 +17,11 @@ Source2: README.top
|
|||||||
|
|
||||||
Patch1: pwait-to-pidwait.patch
|
Patch1: pwait-to-pidwait.patch
|
||||||
Patch2: covscan_findings.patch
|
Patch2: covscan_findings.patch
|
||||||
|
Patch3: uptime-pretty-mod.patch
|
||||||
|
Patch4: free-new-used-calc.patch
|
||||||
|
Patch5: sysctl-support-systemd-globs.patch
|
||||||
|
Patch6: sysctl-print-dotted-keys-again.patch
|
||||||
|
Patch7: pgrep-uid-gid-overflow-backport.patch
|
||||||
|
|
||||||
|
|
||||||
BuildRequires: make
|
BuildRequires: make
|
||||||
@ -160,6 +165,25 @@ ln -s %{_bindir}/pidof %{buildroot}%{_sbindir}/pidof
|
|||||||
%files i18n -f %{name}.lang
|
%files i18n -f %{name}.lang
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Thu Aug 18 2022 Jan Rybar <jrybar@redhat.com> - 3.3.17-8
|
||||||
|
- pgrep: uid/gid overflow fix backport
|
||||||
|
- Resolves: rhbz#2119083
|
||||||
|
|
||||||
|
* Mon Aug 15 2022 Jan Rybar <jrybar@redhat.com> - 3.3.17-7
|
||||||
|
- sysctl: backport - keys with dots instead of slashes again
|
||||||
|
- Resolves: rhbz#2116977
|
||||||
|
- Related: rhbz#2052536
|
||||||
|
|
||||||
|
* Fri Jul 29 2022 Jan Rybar <jrybar@redhat.com> - 3.3.17-6
|
||||||
|
- free: backport new 'used' calculation
|
||||||
|
- sysctl: backport support of systemd glob patterns
|
||||||
|
- Resolves: rhbz#2003033
|
||||||
|
- Resolves: rhbz#2052536
|
||||||
|
|
||||||
|
* Fri Mar 25 2022 Jan Rybar <jrybar@redhat.com> - 3.3.17-5
|
||||||
|
- uptime: human readable data not shown if 364 days up
|
||||||
|
- Resolves: rhbz#2067166
|
||||||
|
|
||||||
* Tue Aug 10 2021 Mohan Boddu <mboddu@redhat.com> - 3.3.17-4
|
* Tue Aug 10 2021 Mohan Boddu <mboddu@redhat.com> - 3.3.17-4
|
||||||
- Rebuilt for IMA sigs, glibc 2.34, aarch64 flags
|
- Rebuilt for IMA sigs, glibc 2.34, aarch64 flags
|
||||||
Related: rhbz#1991688
|
Related: rhbz#1991688
|
||||||
|
Loading…
Reference in New Issue
Block a user