diff --git a/SOURCES/powerpc-utils-1.3.10-lparstat-Fix-offline-threads-uninitialized-entries.patch b/SOURCES/powerpc-utils-1.3.10-lparstat-Fix-offline-threads-uninitialized-entries.patch new file mode 100644 index 0000000..0d1ec77 --- /dev/null +++ b/SOURCES/powerpc-utils-1.3.10-lparstat-Fix-offline-threads-uninitialized-entries.patch @@ -0,0 +1,46 @@ +commit dee15756bcb287ccf39a904be07c90107b13844b +Author: Laurent Dufour +Date: Wed May 3 10:50:15 2023 +0200 + + lparstat: Fix offline threads uninitialized entries + + When some threads are offline, lparstat -E is failing like that: + + $ ppc64_cpu --info # CPU 20 is offline + Core 0: 0* 1* 2* 3* 4* 5* 6* 7* + Core 1: 8* 9* 10* 11* 12* 13* 14* 15* + Core 2: 16* 17* 18* 19* 20 21* 22* 23* + Core 3: 24* 25* 26* 27* 28* 29* 30* 31* + Core 4: 32* 33* 34* 35* 36* 37* 38* 39* + Core 5: 40* 41* 42* 43* 44* 45* 46* 47* + $ lparstat -E + Failed to read /sys/devices/system/cpu/cpu0/spurr + + The message is complaining about CPU0 but the real issue is that in + parse_sysfs_values() the test cpu_sysfs_fds[i].spurr >= 0 is valid even if + the entry has not been initialized (cpu_sysfs_fds is alloc cleared). So + if the number of threads online seen in assign_cpu_sysfs_fds is lower than + threads_in_system, the loop in parse_sysfs_values() will read uninitialized + entry, where .cpu=0. + + To prevent that, unset entries in the cpu_sysfs_fds should have the spurr + fd set to -1. + + Signed-off-by: Laurent Dufour + Signed-off-by: Tyrel Datwyler + +diff --git a/src/lparstat.c b/src/lparstat.c +index a9e7bce..d2fdb3f 100644 +--- a/src/lparstat.c ++++ b/src/lparstat.c +@@ -163,6 +163,10 @@ static int assign_cpu_sysfs_fds(int threads_in_system) + cpu_idx++; + } + ++ /* Mark extra slots for offline threads unset, see parse_sysfs_values */ ++ for (; cpu_idx < threads_in_system; cpu_idx++) ++ cpu_sysfs_fds[cpu_idx].spurr = -1; ++ + return 0; + error: + fprintf(stderr, "Failed to open %s: %s\n", diff --git a/SOURCES/powerpc-utils-1.3.10-lparstat-report-mixed-SMT-state.patch b/SOURCES/powerpc-utils-1.3.10-lparstat-report-mixed-SMT-state.patch new file mode 100644 index 0000000..d7717dc --- /dev/null +++ b/SOURCES/powerpc-utils-1.3.10-lparstat-report-mixed-SMT-state.patch @@ -0,0 +1,93 @@ +commit b2672fa3d462217ccd057a2cd307af2448e78757 +Author: Laurent Dufour +Date: Wed May 3 10:50:14 2023 +0200 + + lparstat: report mixed SMT state + + when SMT state is mixed like this one (CPU 4 is offline): + + $ ppc64_cpu --info + Core 0: 0* 1* 2* 3* 4 5* 6* 7* + Core 1: 8* 9* 10* 11* 12* 13* 14* 15* + Core 2: 16* 17* 18* 19* 20* 21* 22* 23* + Core 3: 24* 25* 26* 27* 28* 29* 30* 31* + Core 4: 32* 33* 34* 35* 36* 37* 38* 39* + Core 5: 40* 41* 42* 43* 44* 45* 46* 47* + $ ppc64_cpu --smt + SMT=7: 0 + SMT=8: 1-5 + + ppc64_cpu --smt is handling that nicely but lparstat failed reporting the + SMT state: + $ /usr/sbin/lparstat + Failed to get smt state + + System Configuration + type=Dedicated mode=Capped smt=Capped lcpu=6 mem=65969728 kB cpus=0 ent=6.00 + + %user %sys %wait %idle physc %entc lbusy app vcsw phint + ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- + 0.02 0.01 0.00 99.97 3.41 56.83 0.02 0.00 4061778 156 + + Makes lparstat reporting "smt=mixed" in that case. + __do_smt is now returning 0 when the SMT state is mixed instead of -1 which + is also reported when an error is detected. + This doesn't change the call made by ppc64_cpu which is using + print_smt_state=true and so is expecting a returned value equal to 0 or -1. + + With that patch applied, lparstat print that in the above case: + $lparstat + + System Configuration + type=Dedicated mode=Capped smt=Mixed lcpu=6 mem=65969728 kB cpus=0 ent=6.00 + + %user %sys %wait %idle physc %entc lbusy app vcsw phint + ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- + 0.01 0.01 0.00 99.97 3.43 57.17 0.02 0.00 4105654 156 + + Signed-off-by: Laurent Dufour + Signed-off-by: Tyrel Datwyler + +diff --git a/src/common/cpu_info_helpers.c b/src/common/cpu_info_helpers.c +index 925f220..c05d96d 100644 +--- a/src/common/cpu_info_helpers.c ++++ b/src/common/cpu_info_helpers.c +@@ -245,7 +245,7 @@ int __do_smt(bool numeric, int cpus_in_system, int threads_per_cpu, + if (smt_state == 0) + smt_state = thread + 1; + else if (smt_state > 0) +- smt_state = -1; /* mix of SMT modes */ ++ smt_state = 0; /* mix of SMT modes */ + } + } + +@@ -257,7 +257,7 @@ int __do_smt(bool numeric, int cpus_in_system, int threads_per_cpu, + printf("SMT=1\n"); + else + printf("SMT is off\n"); +- } else if (smt_state == -1) { ++ } else if (smt_state == 0) { + for (thread = 0; thread < threads_per_cpu; thread++) { + if (CPU_COUNT_S(cpu_state_size, + cpu_states[thread])) { +diff --git a/src/lparstat.c b/src/lparstat.c +index eebba1f..a9e7bce 100644 +--- a/src/lparstat.c ++++ b/src/lparstat.c +@@ -884,13 +884,15 @@ void get_smt_mode(struct sysentry *se, char *buf) + } + + smt_state = parse_smt_state(); +- if (smt_state < 0) { ++ if (smt_state == -1) { + fprintf(stderr, "Failed to get smt state\n"); + return; + } + + if (smt_state == 1) + sprintf(buf, "Off"); ++ else if (smt_state == 0) ++ sprintf(buf, "Mixed"); + else + sprintf(buf, "%d", smt_state); + } diff --git a/SOURCES/powerpc-utils-73ba26-lparstat-fix_negative_values.patch b/SOURCES/powerpc-utils-73ba26-lparstat-fix_negative_values.patch new file mode 100644 index 0000000..692a7fc --- /dev/null +++ b/SOURCES/powerpc-utils-73ba26-lparstat-fix_negative_values.patch @@ -0,0 +1,36 @@ +diff --git a/src/lparstat.c b/src/lparstat.c +index 31a4ee8..eebba1f 100644 +--- a/src/lparstat.c ++++ b/src/lparstat.c +@@ -492,6 +492,15 @@ void get_cpu_util_purr(struct sysentry *unused_se, char *buf) + delta_purr = get_delta_value("purr"); + delta_idle_purr = get_delta_value("idle_purr"); + ++ /* ++ * Given that these values are read from different ++ * sources (purr from lparcfg and idle_purr from sysfs), ++ * a small variation in the values is possible. ++ * In such cases, round down delta_idle_purr to delta_purr. ++ */ ++ if (delta_idle_purr > delta_purr) ++ delta_idle_purr = delta_purr; ++ + physc = (delta_purr - delta_idle_purr) / delta_tb; + physc *= 100.00; + +@@ -507,6 +516,15 @@ void get_cpu_idle_purr(struct sysentry *unused_se, char *buf) + delta_purr = get_delta_value("purr"); + delta_idle_purr = get_delta_value("idle_purr"); + ++ /* ++ * Given that these values are read from different ++ * sources (purr from lparcfg and idle_purr from sysfs), ++ * a small variation in the values is possible. ++ * In such cases, round down delta_idle_purr to delta_purr. ++ */ ++ if (delta_idle_purr > delta_purr) ++ delta_idle_purr = delta_purr; ++ + physc = (delta_purr - delta_idle_purr) / delta_tb; + idle = (delta_purr / delta_tb) - physc; + idle *= 100.00; diff --git a/SOURCES/powerpc-utils-f4c2b0-fix_display_of_mode_for_dedicated_donating_partition.patch b/SOURCES/powerpc-utils-f4c2b0-fix_display_of_mode_for_dedicated_donating_partition.patch new file mode 100644 index 0000000..5920886 --- /dev/null +++ b/SOURCES/powerpc-utils-f4c2b0-fix_display_of_mode_for_dedicated_donating_partition.patch @@ -0,0 +1,55 @@ +diff --git a/src/lparstat.c b/src/lparstat.c +index 0b30fc9..e998e8c 100644 +--- a/src/lparstat.c ++++ b/src/lparstat.c +@@ -718,6 +718,16 @@ void get_capped_mode(struct sysentry *se, char *buf) + sprintf(buf, "%s", value); + } + ++void get_dedicated_mode(struct sysentry *se, char *buf) ++{ ++ const char *value = "Capped"; ++ ++ if (se->value[0] == '1') ++ value = "Donating"; ++ ++ sprintf(buf, "%s", value); ++} ++ + void get_percent_entry(struct sysentry *se, char *buf) + { + float value; +@@ -1057,7 +1067,10 @@ void print_system_configuration(void) + get_sysdata("shared_processor_mode", &descr, value); + offset = sprintf(buf, "type=%s ", value); + sprintf(type, "%s", value); +- get_sysdata("capped", &descr, value); ++ if (!strcmp(value, "Dedicated")) ++ get_sysdata("DedDonMode", &descr, value); ++ else ++ get_sysdata("capped", &descr, value); + offset += sprintf(buf + offset, "mode=%s ", value); + get_sysdata("smt_state", &descr, value); + offset += sprintf(buf + offset, "smt=%s ", value); +diff --git a/src/lparstat.h b/src/lparstat.h +index 26ed4ba..b7c88e9 100644 +--- a/src/lparstat.h ++++ b/src/lparstat.h +@@ -47,6 +47,7 @@ typedef struct cpu_sysfs_file_desc cpu_sysfs_fd; + + extern void get_smt_state(struct sysentry *, char *); + extern void get_capped_mode(struct sysentry *, char *); ++extern void get_dedicated_mode(struct sysentry *, char *); + extern void get_memory_mode(struct sysentry *, char *); + extern void get_percent_entry(struct sysentry *, char *); + extern void get_phys_cpu_percentage(struct sysentry *, char *); +@@ -110,7 +111,8 @@ struct sysentry system_data[] = { + {.name = "DesVarCapWt", + .descr = "Desired Variable Capacity Weight"}, + {.name = "DedDonMode", +- .descr = "Dedicated Donation Mode"}, ++ .descr = "Dedicated Donation Mode", ++ .get = &get_dedicated_mode}, + {.name = "partition_entitled_capacity", + .descr = "Partition Entitled Capacity"}, + {.name = "system_active_processors", diff --git a/SPECS/powerpc-utils.spec b/SPECS/powerpc-utils.spec index a51acc1..9253173 100644 --- a/SPECS/powerpc-utils.spec +++ b/SPECS/powerpc-utils.spec @@ -1,6 +1,6 @@ Name: powerpc-utils Version: 1.3.10 -Release: 5%{?dist} +Release: 7%{?dist} Summary: PERL-based scripts for maintaining and servicing PowerPC systems License: GPLv2 @@ -18,6 +18,14 @@ Patch6: powerpc-utils-2fbd7c-add_NVMf-FC_boot_support_part2.patch Patch7: powerpc-utils-git3847a1-support_multiple_dev_paths_for_a_nvmf_boot_device.patch Patch8: powerpc-utils-git04e5c9-handle_nsid_as_hex.patch Patch9: powerpc-utils-fix_setting_primary_slave_across_reboots.patch +# lparstat: Fix display of mode for dedicated-donating partition +Patch10: powerpc-utils-f4c2b0-fix_display_of_mode_for_dedicated_donating_partition.patch +# lparstat: Fix negative values seen while running lparstat with -E option +Patch11: powerpc-utils-73ba26-lparstat-fix_negative_values.patch +# report-mixed-SMT-state +Patch12: powerpc-utils-1.3.10-lparstat-report-mixed-SMT-state.patch +# Fix-offline-threads-uninitialized-entries +Patch13: powerpc-utils-1.3.10-lparstat-Fix-offline-threads-uninitialized-entries.patch ExclusiveArch: ppc %{power64} @@ -207,6 +215,15 @@ systemctl enable hcn-init.service >/dev/null 2>&1 || : %changelog +* Wed Jul 26 2023 Than Ngo - 1.3.10-7 +- Fix negative values seen while running lpar +- Fix lparstat error with mixed SMT state +Resolves: #2225371 + +* Wed May 10 2023 Than Ngo - 1.3.10-6 +- Resolves: #2166870, lparstat: Fix display of mode for dedicated-donating partition +- Resolves: #2169269, lparstat: Fix negative values seen while running lparstat with -E option + * Mon Dec 12 2022 Than Ngo - 1.3.10-5 - Resolves: #2125152, HNV bond fails to come up with sriov interface as active slave