- Warning raised by polkit when disconnected from ssh

- polkitagentlistener: resource leak - pointer to 'server'
- Error message raised on every 'systemctl start' in emergency.target

bus-conn-msg-ssh.patch

@@ -0,0 +1,60 @@
+From 0ce0a7b3298d7b0fd5ce8c6775bcef9b0caf1bdb Mon Sep 17 00:00:00 2001
+From: David Herrmann <dh.herrmann@gmail.com>
+Date: Wed, 4 Jul 2018 13:51:24 +0200
+Subject: [PATCH] polkitagent: suppress disconnect messages
+
+The polkitagent may be used by pkexec and friends. These might very
+well survive until very late during system shutdown. Hence, a
+disconnect of polkitd during runtime might be expected [1].
+
+This patch silences the disconnect/reconnect messages and turns them
+into debug messages. This only affects the polkit-agent, it does not
+affect the polkit-daemon implementation.
+
+[1] https://bugzilla.redhat.com/show_bug.cgi?id=1249627
+---
+ src/polkitagent/polkitagentlistener.c | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/src/polkitagent/polkitagentlistener.c b/src/polkitagent/polkitagentlistener.c
+index debd1bb..1c8b666 100644
+--- a/src/polkitagent/polkitagentlistener.c
++++ b/src/polkitagent/polkitagentlistener.c
+@@ -178,10 +178,10 @@ on_notify_authority_owner (GObject    *object,
+   owner = polkit_authority_get_owner (server->authority);
+   if (owner == NULL)
+     {
+-      g_printerr ("PolicyKit daemon disconnected from the bus.\n");
++      g_debug ("PolicyKit daemon disconnected from the bus.\n");
+ 
+       if (server->is_registered)
+-        g_printerr ("We are no longer a registered authentication agent.\n");
++        g_debug ("We are no longer a registered authentication agent.\n");
+ 
+       server->is_registered = FALSE;
+     }
+@@ -192,17 +192,17 @@ on_notify_authority_owner (GObject    *object,
+         {
+           GError *error;
+ 
+-          g_printerr ("PolicyKit daemon reconnected to bus.\n");
+-          g_printerr ("Attempting to re-register as an authentication agent.\n");
++          g_debug ("PolicyKit daemon reconnected to bus.\n");
++          g_debug ("Attempting to re-register as an authentication agent.\n");
+ 
+           error = NULL;
+           if (server_register (server, &error))
+             {
+-              g_printerr ("We are now a registered authentication agent.\n");
++              g_debug ("We are now a registered authentication agent.\n");
+             }
+           else
+             {
+-              g_printerr ("Failed to register as an authentication agent: %s\n", error->message);
++              g_debug ("Failed to register as an authentication agent: %s\n", error->message);
+               g_error_free (error);
+             }
+         }
+-- 
+2.18.0
+

pkttyagent-rescue-target-error-msg.patch

@@ -0,0 +1,13 @@
+diff -up ./src/programs/pkttyagent.c.ori ./src/programs/pkttyagent.c
+--- ./src/programs/pkttyagent.c.ori	2018-08-01 15:51:28.495910434 +0200
++++ ./src/programs/pkttyagent.c	2018-08-02 15:51:45.126311197 +0200
+@@ -150,7 +150,8 @@ main (int argc, char *argv[])
+   authority = polkit_authority_get_sync (NULL /* GCancellable* */, &error);
+   if (authority == NULL)
+     {
+-      g_printerr ("Error getting authority: %s (%s, %d)\n",
++      g_printerr ("Authorization not available. Check if polkit service is running or see debug message for more information.\n");
++      g_debug ("Error getting authority: %s (%s, %d)\n",
+                   error->message, g_quark_to_string (error->domain), error->code);
+       g_error_free (error);
+       ret = 127;

polkit.spec

@@ -6,12 +6,18 @@
 Summary: An authorization framework
 Name: polkit
 Version: 0.115
-Release: 2%{?dist}
+Release: 3%{?dist}
 License: LGPLv2+
 URL: http://www.freedesktop.org/wiki/Software/polkit
 Source0: http://www.freedesktop.org/software/polkit/releases/%{name}-%{version}.tar.gz
 Source1: http://www.freedesktop.org/software/polkit/releases/%{name}-%{version}.tar.gz.sign
 Group: System Environment/Libraries
+
+Patch1: polkitagentlistener-freed-server-returned.patch
+Patch2: pkttyagent-rescue-target-error-msg.patch
+Patch3: bus-conn-msg-ssh.patch
+
+
 BuildRequires: gcc-c++
 BuildRequires: glib2-devel >= 2.30.0
 BuildRequires: expat-devel
@@ -175,6 +181,11 @@ exit 0
 %{_libdir}/girepository-1.0/*.typelib
 
 %changelog
+* Fri Jul 20 2018 Jan Rybar <jrybar@redhat.com> - 0.115-3
+- Warning raised by polkit when disconnected from ssh
+- polkitagentlistener: resource leak - pointer to 'server'
+- Error message raised on every 'systemctl start' in emergency.target
+
 * Fri Jul 13 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.115-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
 

polkitagentlistener-freed-server-returned.patch

@@ -0,0 +1,11 @@
+diff -up ./src/polkitagent/polkitagentlistener.c.ori ./src/polkitagent/polkitagentlistener.c
+--- ./src/polkitagent/polkitagentlistener.c.ori	2018-07-20 13:57:11.435302272 +0200
++++ ./src/polkitagent/polkitagentlistener.c	2018-07-20 13:57:30.427321200 +0200
+@@ -439,6 +439,7 @@ polkit_agent_listener_register_with_opti
+           server->thread_initialization_error = NULL;
+           g_thread_join (server->thread);
+           server_free (server);
++          server = NULL;
+           goto out;
+         }
+     }