rpms/polkit
7
0
Fork 0
Code Issues Pull Requests Releases Activity

polkit doesn't release reference counters of GVariant data (#1180886)

Browse Source
This commit is contained in:
Rex Dieter 2015-01-27 09:03:41 -06:00
parent a27b485ff7
commit 8f57407a32
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
0018-authority-Fix-memory-leak-in-EnumerateActions-call-r.patch Normal file
View File

@ -0,0 +1,30 @@
From f4d71e0de885010494b8b0b8d62ca910011d7544 Mon Sep 17 00:00:00 2001
From: "Max A. Dednev" <dednev@rambler.ru>
Date: Sun, 11 Jan 2015 20:00:44 -0500
Subject: [PATCH 18/18] authority: Fix memory leak in EnumerateActions call
results handler
Policykit-1 doesn't release reference counters of GVariant data for
org.freedesktop.PolicyKit1.Authority.EnumerateActions dbus call. This
patch fixed reference counting and following memory leak.
https://bugs.freedesktop.org/show_bug.cgi?id=88288
---
src/polkit/polkitauthority.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/polkit/polkitauthority.c b/src/polkit/polkitauthority.c
index 75619ab..ab6d3cd 100644
--- a/src/polkit/polkitauthority.c
+++ b/src/polkit/polkitauthority.c
@@ -715,7 +715,6 @@ polkit_authority_enumerate_actions_finish (PolkitAuthority *authority,
while ((child = g_variant_iter_next_value (&iter)) != NULL)
{
ret = g_list_prepend (ret, polkit_action_description_new_for_gvariant (child));
- g_variant_ref_sink (child);
g_variant_unref (child);
}
ret = g_list_reverse (ret);
--
2.1.0

9
polkit.spec
View File

@ -6,7 +6,7 @@
Summary: An authorization framework
Name: polkit
Version: 0.112
Release: 7%{?dist}
Release: 7%{?dist}.1
License: LGPLv2+
URL: http://www.freedesktop.org/wiki/Software/polkit
Source0: http://www.freedesktop.org/software/polkit/releases/%{name}-%{version}.tar.gz
@ -19,6 +19,9 @@ Patch1: polkit-0.112-PolkitAgentSession-race.patch
Patch2: polkit-0.112-systemd-Deduplicate-code-paths.patch
# http://cgit.freedesktop.org/polkit/commit/?id=a68f5dfd7662767b7b9822090b70bc5bd145c50c
Patch3: polkit-0.112-systemd-prepare-for-D-Bus-user-bus.patch
# https://bugs.freedesktop.org/show_bug.cgi?id=88288
# http://cgit.freedesktop.org/polkit/commit/?id=f4d71e0de885010494b8b0b8d62ca910011d7544
Patch4: 0018-authority-Fix-memory-leak-in-EnumerateActions-call-r.patch
Group: System Environment/Libraries
BuildRequires: glib2-devel >= 2.30.0
BuildRequires: expat-devel
@ -89,6 +92,7 @@ Development documentation for polkit.
%patch1 -p1 -b .PolkitAgentSession-race
%patch2 -p1 -b .dbus-user-bus
%patch3 -p1 -b .session-dedup-code
%patch4 -p1 -b .authority-Fix-memory-leak
%build
%if 0%{?enable_autoreconf}
@ -175,6 +179,9 @@ exit 0
%{_datadir}/gtk-doc
%changelog
* Tue Jan 27 2015 Rex Dieter <rdieter@fedoraproject.org> 0.112-7.1
- polkit doesn't release reference counters of GVariant data (#1180886)
* Sun Aug 17 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.112-7
- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild