From df8ecd9392435bafe8b11eefbd149da060f62f07 Mon Sep 17 00:00:00 2001 From: Vit Mojzis Date: Thu, 26 Jan 2023 19:18:04 +0100 Subject: [PATCH] policycoreutils-3.5-0.rc2.2 - python/sepolicy: Cache conditional rule queries --- ...olicy-Cache-conditional-rule-queries.patch | 73 +++++++++++++++++++ policycoreutils.spec | 6 +- 2 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 0006-python-sepolicy-Cache-conditional-rule-queries.patch diff --git a/0006-python-sepolicy-Cache-conditional-rule-queries.patch b/0006-python-sepolicy-Cache-conditional-rule-queries.patch new file mode 100644 index 0000000..e6f9ab5 --- /dev/null +++ b/0006-python-sepolicy-Cache-conditional-rule-queries.patch @@ -0,0 +1,73 @@ +From d2c08d621bf8fb3bfaa4460c31d7189a20fcb9a5 Mon Sep 17 00:00:00 2001 +From: Vit Mojzis +Date: Tue, 24 Jan 2023 21:05:05 +0100 +Subject: [PATCH] python/sepolicy: Cache conditional rule queries + +Commit 7506771e4b630fe0ab853f96574e039055cb72eb +"add missing booleans to man pages" dramatically slowed down +"sepolicy manpage -a" by removing caching of setools rule query. +Re-add said caching and update the query to only return conditional +rules. + +Before commit 7506771e: + #time sepolicy manpage -a + real 1m43.153s + # time sepolicy manpage -d httpd_t + real 0m4.493s + +After commit 7506771e: + #time sepolicy manpage -a + real 1h56m43.153s + # time sepolicy manpage -d httpd_t + real 0m8.352s + +After this commit: + #time sepolicy manpage -a + real 1m41.074s + # time sepolicy manpage -d httpd_t + real 0m7.358s + +Signed-off-by: Vit Mojzis +--- + python/sepolicy/sepolicy/__init__.py | 11 ++++++++++- + 1 file changed, 10 insertions(+), 1 deletion(-) + +diff --git a/python/sepolicy/sepolicy/__init__.py b/python/sepolicy/sepolicy/__init__.py +index e2d5c11a..c177cdfc 100644 +--- a/python/sepolicy/sepolicy/__init__.py ++++ b/python/sepolicy/sepolicy/__init__.py +@@ -125,6 +125,7 @@ all_attributes = None + booleans = None + booleans_dict = None + all_allow_rules = None ++all_bool_rules = None + all_transitions = None + + +@@ -1136,6 +1137,14 @@ def get_all_allow_rules(): + all_allow_rules = search([ALLOW]) + return all_allow_rules + ++def get_all_bool_rules(): ++ global all_bool_rules ++ if not all_bool_rules: ++ q = TERuleQuery(_pol, boolean=".*", boolean_regex=True, ++ ruletype=[ALLOW, DONTAUDIT]) ++ all_bool_rules = [_setools_rule_to_dict(x) for x in q.results()] ++ return all_bool_rules ++ + def get_all_transitions(): + global all_transitions + if not all_transitions: +@@ -1146,7 +1155,7 @@ def get_bools(setype): + bools = [] + domainbools = [] + domainname, short_name = gen_short_name(setype) +- for i in map(lambda x: x['booleans'], filter(lambda x: 'booleans' in x and x['source'] == setype, search([ALLOW, DONTAUDIT]))): ++ for i in map(lambda x: x['booleans'], filter(lambda x: 'booleans' in x and x['source'] == setype, get_all_bool_rules())): + for b in i: + if not isinstance(b, tuple): + continue +-- +2.37.3 + diff --git a/policycoreutils.spec b/policycoreutils.spec index 2d95789..d8eaebf 100644 --- a/policycoreutils.spec +++ b/policycoreutils.spec @@ -11,7 +11,7 @@ Summary: SELinux policy core utilities Name: policycoreutils Version: 3.5 -Release: 0.rc2.1%{?dist}.1 +Release: 0.rc2.2%{?dist} License: GPL-2.0-or-later # https://github.com/SELinuxProject/selinux/wiki/Releases Source0: https://github.com/SELinuxProject/selinux/releases/download/3.5-rc2/selinux-3.5-rc2.tar.gz @@ -36,6 +36,7 @@ Patch0002: 0002-Don-t-be-verbose-if-you-are-not-on-a-tty.patch Patch0003: 0003-sepolicy-generate-Handle-more-reserved-port-types.patch Patch0004: 0004-sandbox-Use-matchbox-window-manager-instead-of-openb.patch Patch0005: 0005-Use-SHA-2-instead-of-SHA-1.patch +Patch0006: 0006-python-sepolicy-Cache-conditional-rule-queries.patch # Patch list end Obsoletes: policycoreutils < 2.0.61-2 @@ -443,6 +444,9 @@ The policycoreutils-restorecond package contains the restorecond service. %systemd_postun_with_restart restorecond.service %changelog +* Thu Jan 26 2023 Vit Mojzis - 3.5-0.rc2.2 +- python/sepolicy: Cache conditional rule queries + * Fri Jan 20 2023 Fedora Release Engineering - 3.5-0.rc2.1.1 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild