pinentry-gtk 0.8.0

also fixes pinentry-gtk keyboard grab fail results in SIGABRT (#585422)
This commit is contained in:
Stanislav Ochotnicky 2010-04-27 08:57:22 +00:00
parent 8388aecc1d
commit 1e5172663b
4 changed files with 47 additions and 8 deletions

View File

@ -1,2 +1,2 @@
pinentry-0.7.6.tar.gz pinentry-0.8.0.tar.gz
pinentry-0.7.6.tar.gz.sig pinentry-0.8.0.tar.gz.sig

View File

@ -0,0 +1,34 @@
Index: gtk+-2/pinentry-gtk-2.c
===================================================================
--- gtk+-2/pinentry-gtk-2.c (revision 228)
+++ gtk+-2/pinentry-gtk-2.c (revision 229)
@@ -52,6 +52,7 @@
#endif
static pinentry_t pinentry;
+static int grab_failed;
static int passphrase_ok;
typedef enum { CONFIRM_CANCEL, CONFIRM_OK, CONFIRM_NOTOK } confirm_value_t;
static confirm_value_t confirm_value;
@@ -135,7 +136,11 @@
return;
if (gdk_keyboard_grab (win->window, FALSE, gdk_event_get_time (event)))
- g_error ("could not grab keyboard");
+ {
+ g_critical ("could not grab keyboard");
+ grab_failed = 1;
+ gtk_main_quit ();
+ }
}
@@ -520,7 +525,7 @@
while (gtk_events_pending ())
gtk_main_iteration ();
- if (confirm_value == CONFIRM_CANCEL)
+ if (confirm_value == CONFIRM_CANCEL || grab_failed)
pe->canceled = 1;
pinentry = NULL;

View File

@ -9,8 +9,8 @@
%endif %endif
Name: pinentry Name: pinentry
Version: 0.7.6 Version: 0.8.0
Release: 5%{?dist} Release: 1%{?dist}
Summary: Collection of simple PIN or passphrase entry dialogs Summary: Collection of simple PIN or passphrase entry dialogs
Group: Applications/System Group: Applications/System
@ -23,9 +23,9 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
# borrowed from opensuse # borrowed from opensuse
Source10: pinentry-wrapper Source10: pinentry-wrapper
## Upstreamable patches ## Backported patches from SVN
# from gpa-devel list, archives seem 404'd atm
Patch50: 0001-Fix-pinentry-gtk-2-SIGSEGV-when-unfocusing-with-g-ar.patch Patch50: 0001-Fix-pinentry-gtk-2-SIGSEGV-when-unfocusing-with-g-ar.patch
Patch51: 0002-Fix-sigabrt-on-fail-grab-r229.patch
BuildRequires: gtk2-devel BuildRequires: gtk2-devel
BuildRequires: libcap-devel BuildRequires: libcap-devel
@ -88,6 +88,7 @@ Support for Qt4 is new, and a bit experimental.
%setup -q %setup -q
%patch50 -p1 -b .rhbug_520236 %patch50 -p1 -b .rhbug_520236
%patch51 -p0 -b .rhbug_585422
# hack around auto* madness, lack of proper support for moc # hack around auto* madness, lack of proper support for moc
%if %{?_enable_pinentry_qt4:1} %if %{?_enable_pinentry_qt4:1}
@ -171,6 +172,10 @@ fi
%changelog %changelog
* Tue Apr 27 2010 Stanislav Ochotnicky <sochotnicky@redhat.com> - 0.8.0-1
- pinentry-0.8.0
- pinentry-gtk keyboard grab fail results in SIGABRT (#585422)
* Sun Apr 18 2010 Rex Dieter <rdieter@fedoraproject.org> - 0.7.6-5 * Sun Apr 18 2010 Rex Dieter <rdieter@fedoraproject.org> - 0.7.6-5
- pinentry-gtk -g segfaults on focus change (#520236) - pinentry-gtk -g segfaults on focus change (#520236)

View File

@ -1,2 +1,2 @@
5a4f676375fa882009da02013d77210f pinentry-0.7.6.tar.gz 590be1b00f9ab63205843c7fed8caf35 pinentry-0.8.0.tar.gz
36cd76923724de5d10830346f4b0f915 pinentry-0.7.6.tar.gz.sig 12467655a6ba5188c5204f2fbe7f4015 pinentry-0.8.0.tar.gz.sig