Fix package review issues.

This commit is contained in:
Robin Norwood 2007-10-26 18:27:42 +00:00
parent 187d98c4fa
commit 2e43aed7d1

View File

@ -1,6 +1,6 @@
Name: perl-libxml-perl Name: perl-libxml-perl
Version: 0.08 Version: 0.08
Release: 2 Release: 3%{?dist}
Summary: A collection of Perl modules for working with XML Summary: A collection of Perl modules for working with XML
Group: Development/Libraries Group: Development/Libraries
@ -10,11 +10,11 @@ Source0: http://www.cpan.org/authors/id/K/KM/KMACLEOD/libxml-perl-%{versi
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch BuildArch: noarch
BuildRequires: perl >= 1:5.6.1
BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(XML::Parser) BuildRequires: perl(XML::Parser)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description %description
libxml-perl is a collection of smaller Perl modules, scripts, and libxml-perl is a collection of smaller Perl modules, scripts, and
documents for working with XML in Perl. libxml-perl software works in documents for working with XML in Perl. libxml-perl software works in
@ -25,10 +25,22 @@ others.
%prep %prep
%setup -q -n libxml-perl-%{version} %setup -q -n libxml-perl-%{version}
# Filter unwanted Provides:
cat << \EOF > %{name}-prov
#!/bin/sh
%{__perl_provides} $* |\
sed -e '/perl(Data::Grove)/d'
EOF
%define __perl_provides %{_builddir}/libxml-perl-%{version}/%{name}-prov
chmod +x %{__perl_provides}
%build %build
%{__perl} Makefile.PL INSTALLDIRS=vendor %{__perl} Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags} make %{?_smp_mflags}
%install %install
rm -rf $RPM_BUILD_ROOT rm -rf $RPM_BUILD_ROOT
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
@ -36,9 +48,11 @@ find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';' find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
chmod -R u+w $RPM_BUILD_ROOT/* chmod -R u+w $RPM_BUILD_ROOT/*
%check || :
%check
make test make test
%clean %clean
rm -rf $RPM_BUILD_ROOT rm -rf $RPM_BUILD_ROOT
@ -52,11 +66,21 @@ rm -rf $RPM_BUILD_ROOT
%changelog %changelog
* Fri Oct 26 2007 Robin Norwood <rnorwood@redhat.com> - 0.08-3
- Fix old changelog entry
- Fix issues from package review:
- Remove extra BR: perl
- Remove "|| :" from check section
- Add dist tag to release
- Remove extra Provides: perl(Data::Grove)
- Clean up tabs and spacing
- Resolves: bz#226269
* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@redhat.com> - 0.08-2 * Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@redhat.com> - 0.08-2
- correct license tag - correct license tag
- add BR: perl(ExtUtils::MakeMaker) - add BR: perl(ExtUtils::MakeMaker)
* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - sh: line 0: fg: no job control * Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - 0.08-1.3
- rebuild - rebuild
* Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 0.08-1.2 * Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 0.08-1.2