Fix package review issues.

perl-libxml-perl.spec

@@ -1,6 +1,6 @@
 Name:           perl-libxml-perl
 Version:        0.08
-Release: 	2
+Release:        3%{?dist}
 Summary:        A collection of Perl modules for working with XML
 
 Group:          Development/Libraries
@@ -10,10 +10,10 @@ Source0:        http://www.cpan.org/authors/id/K/KM/KMACLEOD/libxml-perl-%{versi
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildArch:      noarch
-BuildRequires:  perl >= 1:5.6.1
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(XML::Parser)
-Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+
 
 %description
 libxml-perl is a collection of smaller Perl modules, scripts, and
@@ -25,10 +25,22 @@ others.
 %prep
 %setup -q -n libxml-perl-%{version}
 
+# Filter unwanted Provides:
+cat << \EOF > %{name}-prov
+#!/bin/sh
+%{__perl_provides} $* |\
+  sed -e '/perl(Data::Grove)/d'
+EOF
+
+%define __perl_provides %{_builddir}/libxml-perl-%{version}/%{name}-prov
+chmod +x %{__perl_provides}
+
+
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
+
 %install
 rm -rf $RPM_BUILD_ROOT
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
@@ -36,9 +48,11 @@ find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
 
-%check || :
+
+%check
 make test
 
+
 %clean 
 rm -rf $RPM_BUILD_ROOT
 
@@ -52,11 +66,21 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %changelog
+* Fri Oct 26 2007 Robin Norwood <rnorwood@redhat.com> - 0.08-3
+- Fix old changelog entry
+- Fix issues from package review:
+- Remove extra BR: perl
+- Remove "|| :" from check section
+- Add dist tag to release
+- Remove extra Provides: perl(Data::Grove)
+- Clean up tabs and spacing
+- Resolves: bz#226269
+
 * Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@redhat.com> - 0.08-2
 - correct license tag
 - add BR: perl(ExtUtils::MakeMaker)
 
-* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - sh: line 0: fg: no job control
+* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - 0.08-1.3
 - rebuild
 
 * Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 0.08-1.2