Compare commits

...

No commits in common. "c8s" and "c8-beta" have entirely different histories.
c8s ... c8-beta

8 changed files with 3 additions and 405 deletions

View File

@ -1 +0,0 @@
1

52
.gitignore vendored
View File

@ -1,51 +1 @@
XML-LibXML-1.70.tar.gz
/XML-LibXML-1.74.tar.gz
/XML-LibXML-1.88.tar.gz
/XML-LibXML-1.90.tar.gz
/XML-LibXML-1.92.tar.gz
/XML-LibXML-1.93.tar.gz
/XML-LibXML-1.95.tar.gz
/XML-LibXML-1.96.tar.gz
/XML-LibXML-1.97.tar.gz
/XML-LibXML-1.98.tar.gz
/XML-LibXML-1.99.tar.gz
/XML-LibXML-2.0001.tar.gz
/XML-LibXML-2.0002.tar.gz
/XML-LibXML-2.0003.tar.gz
/XML-LibXML-2.0004.tar.gz
/XML-LibXML-2.0006.tar.gz
/XML-LibXML-2.0007.tar.gz
/XML-LibXML-2.0008.tar.gz
/XML-LibXML-2.0010.tar.gz
/XML-LibXML-2.0012.tar.gz
/XML-LibXML-2.0014.tar.gz
/XML-LibXML-2.0016.tar.gz
/XML-LibXML-2.0017.tar.gz
/XML-LibXML-2.0018.tar.gz
/XML-LibXML-2.0019.tar.gz
/XML-LibXML-2.0101.tar.gz
/XML-LibXML-2.0103.tar.gz
/XML-LibXML-2.0104.tar.gz
/XML-LibXML-2.0105.tar.gz
/XML-LibXML-2.0106.tar.gz
/XML-LibXML-2.0107.tar.gz
/XML-LibXML-2.0108.tar.gz
/XML-LibXML-2.0110.tar.gz
/XML-LibXML-2.0111.tar.gz
/XML-LibXML-2.0113.tar.gz
/XML-LibXML-2.0115.tar.gz
/XML-LibXML-2.0116.tar.gz
/XML-LibXML-2.0117.tar.gz
/XML-LibXML-2.0118.tar.gz
/XML-LibXML-2.0119.tar.gz
/XML-LibXML-2.0121.tar.gz
/XML-LibXML-2.0122.tar.gz
/XML-LibXML-2.0123.tar.gz
/XML-LibXML-2.0124.tar.gz
/XML-LibXML-2.0125.tar.gz
/XML-LibXML-2.0126.tar.gz
/XML-LibXML-2.0128.tar.gz
/XML-LibXML-2.0129.tar.gz
/XML-LibXML-2.0130.tar.gz
/XML-LibXML-2.0131.tar.gz
/XML-LibXML-2.0132.tar.gz
SOURCES/XML-LibXML-2.0132.tar.gz

View File

@ -0,0 +1 @@
c5e316a5fabd656324d9d75c33b2593289c28c33 SOURCES/XML-LibXML-2.0132.tar.gz

View File

@ -8,15 +8,13 @@ Name: perl-XML-LibXML
# it might not be needed anymore
# this module is maintained, the other is not
Version: 2.0132
Release: 3%{?dist}
Release: 2%{?dist}
Epoch: 1
Summary: Perl interface to the libxml2 library
Group: Development/Libraries
License: (GPL+ or Artistic) and MIT
URL: http://search.cpan.org/dist/XML-LibXML/
Source0: http://search.cpan.org/CPAN/authors/id/S/SH/SHLOMIF/XML-LibXML-%{version}.tar.gz
# https://github.com/cpan-authors/XML-LibXML/commit/059abf5f9336e2213794b5b545c707394cca3ac7
Patch0: perl-XML-LibXML-2.0132-CVE-2026-8177.patch
BuildRequires: coreutils
BuildRequires: findutils
BuildRequires: glibc-common
@ -95,7 +93,6 @@ validating XML parser and the high performance DOM implementation.
%prep
%setup -q -n XML-LibXML-%{version}
%patch0 -p1
chmod -x *.c
for i in Changes; do
/usr/bin/iconv -f iso8859-1 -t utf-8 $i > $i.conv && /bin/mv -f $i.conv $i
@ -139,11 +136,6 @@ fi
%{_mandir}/man3/*.3*
%changelog
* Tue Jun 23 2026 RHEL Packaging Agent <redhat-ymir-agent@redhat.com> - 1:2.0132-3
- Fix out-of-bounds heap read via truncated UTF-8 in node name
validation (CVE-2026-8177)
- Resolves: RHEL-186519
* Fri Feb 09 2018 Fedora Release Engineering <releng@fedoraproject.org> - 1:2.0132-2
- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild

View File

@ -1,7 +0,0 @@
# RHEL
--- !Policy
product_versions:
- rhel-*
decision_context: osci_compose_gate
rules:
- !PassingTestCaseRule {test_case_name: osci.brew-build.tier0.functional}

View File

@ -1,324 +0,0 @@
From ea9a5f9e9bbe48aa1fa7b16dc53d610fba093e17 Mon Sep 17 00:00:00 2001
From: Toddr Bot <toddbot@rinaldo.us>
Date: Tue, 19 May 2026 19:32:08 +0000
Subject: [PATCH] fix: replace domParseChar with xmlValidateName to prevent OOB
UTF-8 read
domParseChar() read continuation bytes for multi-byte UTF-8 sequences without
validating they exist or have required 10xxxxxx form. Truncated sequences like
"a\xF0" caused heap reads past NUL terminator. Replace with libxml2's
xmlValidateName(), which correctly handles all UTF-8 edge cases.
Adds 65 regression tests covering truncation points, invalid continuations, and
5 affected DOM entry points (createElement, createAttribute, setNodeName, etc).
Fixes https://github.com/cpan-authors/XML-LibXML/issues/146
---
LibXML.xs | 33 +------------
MANIFEST | 1 +
dom.c | 88 ---------------------------------
dom.h | 32 ------------
t/48_security_oob_utf8_gh146.t | 90 ++++++++++++++++++++++++++++++++++
5 files changed, 93 insertions(+), 151 deletions(-)
create mode 100644 t/48_security_oob_utf8_gh146.t
diff --git a/LibXML.xs b/LibXML.xs
index efca0b6..cac5447 100644
--- a/LibXML.xs
+++ b/LibXML.xs
@@ -989,40 +989,11 @@ LibXML_cleanup_parser() {
int
LibXML_test_node_name( xmlChar * name )
{
- xmlChar * cur = name;
- int tc = 0;
- int len = 0;
-
- if ( cur == NULL || *cur == 0 ) {
- /* warn("name is empty" ); */
- return(0);
- }
-
- tc = domParseChar( cur, &len );
-
- if ( !( IS_LETTER( tc ) || (tc == '_') || (tc == ':')) ) {
- /* warn( "is not a letter\n" ); */
+ if ( name == NULL || *name == 0 ) {
return(0);
}
- tc = 0;
- cur += len;
-
- while (*cur != 0 ) {
- tc = domParseChar( cur, &len );
-
- if (!(IS_LETTER(tc) || IS_DIGIT(tc) || (tc == '_') ||
- (tc == '-') || (tc == ':') || (tc == '.') ||
- IS_COMBINING(tc) || IS_EXTENDER(tc)) ) {
- /* warn( "is not a letter\n" ); */
- return(0);
- }
- tc = 0;
- cur += len;
- }
-
- /* warn("name is ok"); */
- return(1);
+ return xmlValidateName( name, 0 ) == 0;
}
/* Assumes that the node has a proxy. */
diff --git a/MANIFEST b/MANIFEST
index 2efb21a..e72a35d 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -168,6 +168,7 @@ t/48_replaceNode_DTD_nodes_rT_80521.t
t/48_rt123379_setNamespace.t
t/48_rt55000.t
t/48_rt93429_recover_2_in_html_parsing.t
+t/48_security_oob_utf8_gh146.t
t/48importing_nodes_IDs_rt_69520.t
t/49_load_html.t
t/49callbacks_returning_undef.t
diff --git a/dom.c b/dom.c
index 10eb33d..0a818b2 100644
--- a/dom.c
+++ b/dom.c
@@ -235,94 +235,6 @@ domReconcileNs(xmlNodePtr tree)
xmlFreeNsList(unused);
}
-/**
- * NAME domParseChar
- * TYPE function
- * SYNOPSIS
- * int utf8char = domParseChar( curchar, &len );
- *
- * The current char value, if using UTF-8 this may actually span
- * multiple bytes in the given string. This function parses an utf8
- * character from a string into a UTF8 character (an integer). It uses
- * a slightly modified version of libxml2's character parser. libxml2
- * itself does not provide any function to parse characters dircetly
- * from a string and test if they are valid utf8 characters.
- *
- * XML::LibXML uses this function rather than perls native UTF8
- * support for two reasons:
- * 1) perls UTF8 handling functions often lead to encoding errors,
- * which partly comes, that they are badly documented.
- * 2) not all perl versions XML::LibXML intends to run with have native
- * UTF8 support.
- *
- * domParseChar() allows to use the very same code with all versions
- * of perl :)
- *
- * Returns the current char value and its length
- *
- * NOTE: If the character passed to this function is not a UTF
- * character, the return value will be 0 and the length of the
- * character is -1!
- */
-int
-domParseChar( xmlChar *cur, int *len )
-{
- unsigned char c;
- unsigned int val;
-
- /*
- * We are supposed to handle UTF8, check it's valid
- * From rfc2044: encoding of the Unicode values on UTF-8:
- *
- * UCS-4 range (hex.) UTF-8 octet sequence (binary)
- * 0000 0000-0000 007F 0xxxxxxx
- * 0000 0080-0000 07FF 110xxxxx 10xxxxxx
- * 0000 0800-0000 FFFF 1110xxxx 10xxxxxx 10xxxxxx
- *
- * Check for the 0x110000 limit too
- */
-
- if ( cur == NULL || *cur == 0 ) {
- *len = 0;
- return(0);
- }
-
- c = *cur;
- if ( c & 0x80 ) {
- if ((c & 0xe0) == 0xe0) {
- if ((c & 0xf0) == 0xf0) {
- /* 4-byte code */
- *len = 4;
- val = (cur[0] & 0x7) << 18;
- val |= (cur[1] & 0x3f) << 12;
- val |= (cur[2] & 0x3f) << 6;
- val |= cur[3] & 0x3f;
- } else {
- /* 3-byte code */
- *len = 3;
- val = (cur[0] & 0xf) << 12;
- val |= (cur[1] & 0x3f) << 6;
- val |= cur[2] & 0x3f;
- }
- } else {
- /* 2-byte code */
- *len = 2;
- val = (cur[0] & 0x1f) << 6;
- val |= cur[1] & 0x3f;
- }
- if ( !IS_CHAR(val) ) {
- *len = -1;
- return(0);
- }
- return(val);
- }
- else {
- /* 1-byte code */
- *len = 1;
- return((int)c);
- }
-}
-
/**
* Name: domReadWellBalancedString
* Synopsis: xmlNodePtr domReadWellBalancedString( xmlDocPtr doc, xmlChar *string )
diff --git a/dom.h b/dom.h
index 29cf2b5..cf0f474 100644
--- a/dom.h
+++ b/dom.h
@@ -54,38 +54,6 @@ extern "C" {
void
domReconcileNs(xmlNodePtr tree);
-/**
- * NAME domParseChar
- * TYPE function
- * SYNOPSIS
- * int utf8char = domParseChar( curchar, &len );
- *
- * The current char value, if using UTF-8 this may actually span
- * multiple bytes in the given string. This function parses an utf8
- * character from a string into a UTF8 character (an integer). It uses
- * a slightly modified version of libxml2's character parser. libxml2
- * itself does not provide any function to parse characters dircetly
- * from a string and test if they are valid utf8 characters.
- *
- * XML::LibXML uses this function rather than perls native UTF8
- * support for two reasons:
- * 1) perls UTF8 handling functions often lead to encoding errors,
- * which partly comes, that they are badly documented.
- * 2) not all perl versions XML::LibXML intends to run with have native
- * UTF8 support.
- *
- * domParseChar() allows to use the very same code with all versions
- * of perl :)
- *
- * Returns the current char value and its length
- *
- * NOTE: If the character passed to this function is not a UTF
- * character, the return value will be 0 and the length of the
- * character is -1!
- */
-int
-domParseChar( xmlChar *characters, int *len );
-
xmlNodePtr
domReadWellBalancedString( xmlDocPtr doc, xmlChar* string, int repair );
diff --git a/t/48_security_oob_utf8_gh146.t b/t/48_security_oob_utf8_gh146.t
new file mode 100644
index 0000000..74fb6d4
--- /dev/null
+++ b/t/48_security_oob_utf8_gh146.t
@@ -0,0 +1,90 @@
+# Security regression test for GitHub issue #146:
+# Out-of-bounds heap read via hand-rolled UTF-8 walker on truncated sequences.
+#
+# The original domParseChar() read continuation bytes for multi-byte UTF-8
+# sequences without verifying they exist or are valid. A truncated sequence
+# (e.g., "a\xF0") caused reads past the NUL terminator into uninitialized
+# heap memory. This affects all DOM methods that validate node names via
+# LibXML_test_node_name(): createElement, createAttribute, setNodeName,
+# createElementNS, createAttributeNS, etc.
+#
+# Impact: denial of service (crash on unmapped memory) and potential
+# information disclosure (reading adjacent heap allocations).
+#
+# Fixed by replacing the hand-rolled UTF-8 walker (domParseChar) with
+# libxml2's own xmlValidateName(), which correctly handles all UTF-8
+# edge cases.
+#
+# NOTE: This test verifies that malformed UTF-8 does not crash the process
+# (the actual security issue). Whether a given sequence is rejected depends
+# on the linked libxml2 version — older 2.9.x builds may accept some
+# sequences that newer versions reject.
+
+use strict;
+use warnings;
+
+use Test::More;
+use XML::LibXML;
+
+# Truncated UTF-8 sequences that previously caused OOB heap reads.
+# Each entry: [ bytes, description ]
+my @truncated_sequences = (
+ [ "a\xC0", "truncated 2-byte (leader only)" ],
+ [ "a\xC2", "truncated 2-byte (valid leader, missing continuation)" ],
+ [ "a\xE0", "truncated 3-byte (leader only)" ],
+ [ "a\xE0\x80", "truncated 3-byte (leader + 1 continuation)" ],
+ [ "a\xF0", "truncated 4-byte (leader only)" ],
+ [ "a\xF0\x80", "truncated 4-byte (leader + 1 continuation)" ],
+ [ "a\xF0\x80\x80", "truncated 4-byte (leader + 2 continuations)" ],
+);
+
+# Invalid continuation bytes — the leader is valid but the continuations
+# are not 10xxxxxx.
+my @invalid_continuations = (
+ [ "a\xC2\x41", "2-byte with ASCII continuation" ],
+ [ "a\xE0\x41\x80", "3-byte with ASCII in first continuation" ],
+ [ "a\xE0\x80\x41", "3-byte with ASCII in second continuation" ],
+ [ "a\xF0\x41\x80\x80", "4-byte with ASCII in first continuation" ],
+ [ "a\xF0\x80\x41\x80", "4-byte with ASCII in second continuation" ],
+ [ "a\xF0\x80\x80\x41", "4-byte with ASCII in third continuation" ],
+);
+
+my @all_bad = (@truncated_sequences, @invalid_continuations);
+
+my @methods = qw( createElement setNodeName createElementNS
+ createAttribute createAttributeNS );
+
+# TEST:$bad_count=13
+# TEST:$method_count=5
+plan tests => scalar(@all_bad) * scalar(@methods);
+
+my $doc = XML::LibXML::Document->new();
+my $nsURI = "http://example.com/ns";
+
+for my $case (@all_bad) {
+ my ($bytes, $desc) = @$case;
+
+ for my $method (@methods) {
+ eval {
+ if ($method eq 'createElement') {
+ $doc->createElement($bytes);
+ }
+ elsif ($method eq 'setNodeName') {
+ my $node = $doc->createElement("tmp");
+ $node->setNodeName($bytes);
+ }
+ elsif ($method eq 'createElementNS') {
+ $doc->createElementNS($nsURI, $bytes);
+ }
+ elsif ($method eq 'createAttribute') {
+ $doc->createAttribute($bytes, "value");
+ }
+ elsif ($method eq 'createAttributeNS') {
+ $doc->createAttributeNS($nsURI, $bytes, "value");
+ }
+ };
+
+ # TEST*$bad_count*$method_count
+ pass("$method survives $desc without crashing");
+ }
+}
--
2.52.0

View File

@ -1,12 +0,0 @@
summary: Private (RHEL) beakerlib tests
enabled: false
adjust:
- when: distro == rhel
enabled: true
because: private tests are accesible only within rhel pipeline
discover:
- name: rhel
how: fmf
url: https://pkgs.devel.redhat.com/git/tests/perl-XML-LibXML
execute:
how: tmt

View File

@ -1 +0,0 @@
SHA512 (XML-LibXML-2.0132.tar.gz) = 3df1cb67ea955133492f2b6f8def2b28079c59e99170a31820aca69ea81686c4b67171509f1b311faab9389d200c4a24942b3950d7c0730ff1233a009b398fce