From 68965e00ff2d48d2a31182cd6ca4032e6e246c98 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 4 Apr 2018 11:55:42 +0200
Subject: [PATCH] Modernize spec file

---
 .rpmlint                  |  2 ++
 perl-Test-NoWarnings.spec | 39 ++++++++++++++++++++++++++++-----------
 2 files changed, 30 insertions(+), 11 deletions(-)
 create mode 100644 .rpmlint

diff --git a/.rpmlint b/.rpmlint
new file mode 100644
index 0000000..83bd7d8
--- /dev/null
+++ b/.rpmlint
@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error .* ok");
diff --git a/perl-Test-NoWarnings.spec b/perl-Test-NoWarnings.spec
index e2edd89..557be43 100644
--- a/perl-Test-NoWarnings.spec
+++ b/perl-Test-NoWarnings.spec
@@ -1,21 +1,37 @@
+# Enable dumping a stack trace
+%bcond_without perl_Test_NoWarnings_enables_stack_trace
+
 Name:           perl-Test-NoWarnings
 Version:        1.04
-Release:        14%{?dist}
+Release:        15%{?dist}
 Summary:        Make sure you didn't emit any warnings while testing
 License:        LGPLv2+
-Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Test-NoWarnings/
 Source0:        http://www.cpan.org/authors/id/A/AD/ADAMK/Test-NoWarnings-%{version}.tar.gz
 BuildArch:      noarch
+BuildRequires:  make
 BuildRequires:  perl-generators
+BuildRequires:  perl-interpreter
+BuildRequires:  perl(:VERSION) >= 5.6
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires:  perl(strict)
+# Run-time:
 BuildRequires:  perl(Carp)
-BuildRequires:  perl(Devel::StackTrace)
 BuildRequires:  perl(Exporter)
-BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Test::Builder) >= 0.86
-BuildRequires:  perl(Test::More)
+BuildRequires:  perl(warnings)
+BuildRequires:  perl(vars)
+%if %{with perl_Test_NoWarnings_enables_stack_trace}
+# Optional run-time:
+BuildRequires:  perl(Devel::StackTrace)
+%endif
+# Tests:
+BuildRequires:  perl(Test::More) >= 0.47
 BuildRequires:  perl(Test::Tester) >= 0.107
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+%if %{with perl_Test_NoWarnings_enables_stack_trace}
+Suggests:       perl(Devel::StackTrace)
+%endif
 
 %description
 In general, your tests shouldn't produce warnings. This module causes any
@@ -29,25 +45,26 @@ going on when the it occurred.
 %setup -q -n Test-NoWarnings-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL NO_PACKLIST=1 INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
 make pure_install DESTDIR=$RPM_BUILD_ROOT
-
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-
 %{_fixperms} $RPM_BUILD_ROOT/*
 
 %check
 make test
 
 %files
-%doc Changes LICENSE README
+%license LICENSE
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
 
 %changelog
+* Wed Apr 04 2018 Petr Pisar <ppisar@redhat.com> - 1.04-15
+- Modernize spec file
+
 * Fri Feb 09 2018 Fedora Release Engineering <releng@fedoraproject.org> - 1.04-14
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild