From 720d4b79b50fed5896efc36dc51d84771db9a507 Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul@city-fan.org>
Date: Sat, 13 May 2023 15:26:15 +0100
Subject: [PATCH] Spec tidy-up

- Use SPDX-format license tag
- Use author-independent source URL
- Specify all dependencies
- Fix permissions verbosely
- Simplify find commands using -empty and -delete
- Make %files list more explicit
---
 perl-Taint-Runtime.rpmlintrc |  2 ++
 perl-Taint-Runtime.spec      | 38 +++++++++++++++++++++++++-----------
 2 files changed, 29 insertions(+), 11 deletions(-)
 create mode 100644 perl-Taint-Runtime.rpmlintrc

diff --git a/perl-Taint-Runtime.rpmlintrc b/perl-Taint-Runtime.rpmlintrc
new file mode 100644
index 0000000..2e0916c
--- /dev/null
+++ b/perl-Taint-Runtime.rpmlintrc
@@ -0,0 +1,2 @@
+# This is a loadable module; the main calling process is linked against libc itself
+addFilter("library-not-linked-against-libc /.*/auto/Taint/Runtime/Runtime\.so")
diff --git a/perl-Taint-Runtime.spec b/perl-Taint-Runtime.spec
index 29ea952..d1decaa 100644
--- a/perl-Taint-Runtime.spec
+++ b/perl-Taint-Runtime.spec
@@ -1,21 +1,28 @@
 Name:           perl-Taint-Runtime
 Version:        0.03
-Release:        47%{?dist}
+Release:        48%{?dist}
 Summary:        Runtime enable taint checking
-License:        GPL+ or Artistic
+License:        GPL-1.0-or-later OR Artistic-1.0-Perl
 URL:            https://metacpan.org/release/Taint-Runtime
-Source0:        https://cpan.metacpan.org/authors/id/R/RH/RHANDOM/Taint-Runtime-%{version}.tar.gz
-BuildRequires: make
+Source0:        https://cpan.metacpan.org/modules/by-module/Taint/Taint-Runtime-%{version}.tar.gz
+# Build:
+BuildRequires:  coreutils
+BuildRequires:  findutils
 BuildRequires:  gcc
+BuildRequires:  make
 BuildRequires:  perl-devel
 BuildRequires:  perl-generators
+BuildRequires:  perl-interpreter
 BuildRequires:  perl(ExtUtils::MakeMaker)
 # Run-time:
 BuildRequires:  perl(Carp)
 BuildRequires:  perl(Exporter)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(vars)
 BuildRequires:  perl(XSLoader)
 # Tests:
 BuildRequires:  perl(Test::More)
+# Dependencies:
 Requires:       perl(Carp)
 
 %{?perl_default_filter}
@@ -29,17 +36,17 @@ good reason for not using the -T option, you should use the -T option.
 
 %prep
 %setup -q -n Taint-Runtime-%{version}
-chmod +x is_taint_bench.pl
+chmod -c +x is_taint_bench.pl
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
 make %{?_smp_mflags}
 
 %install
-make pure_install DESTDIR=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+find %{buildroot} -type f -name '*.bs' -empty -delete
+%{_fixperms} -c %{buildroot}
 
 %check
 make test
@@ -48,9 +55,18 @@ make test
 %doc Changes README
 %{perl_vendorarch}/auto/Taint/
 %{perl_vendorarch}/Taint/
-%{_mandir}/man3/*.3*
+%{_mandir}/man3/Taint::Runtime.3*
 
 %changelog
+* Sat May 13 2023 Paul Howarth <paul@city-fan.org> - 0.03-48
+- Spec tidy-up
+  - Use SPDX-format license tag
+  - Use author-independent source URL
+  - Specify all dependencies
+  - Fix permissions verbosely
+  - Simplify find commands using -empty and -delete
+  - Make %%files list more explicit
+
 * Fri Jan 20 2023 Fedora Release Engineering <releng@fedoraproject.org> - 0.03-47
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild