- Incorporate package review suggestions (#602597)

- Use %{?perl_default_filter}
- Use DESTDIR instead of PERL_INSTALL_ROOT
This commit is contained in:
Paul Howarth 2010-06-14 08:10:38 +00:00
parent 12f659e05b
commit 87e5a2bc84

View File

@ -1,6 +1,6 @@
Name: perl-Package-Stash Name: perl-Package-Stash
Version: 0.03 Version: 0.03
Release: 1%{?dist} Release: 2%{?dist}
Summary: Routines for manipulating stashes Summary: Routines for manipulating stashes
Group: Development/Libraries Group: Development/Libraries
License: GPL+ or Artistic License: GPL+ or Artistic
@ -17,6 +17,8 @@ BuildRequires: perl(Test::Pod)
BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod::Coverage)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%{?perl_default_filter}
%description %description
Manipulating stashes (Perl's symbol tables) is occasionally necessary, but Manipulating stashes (Perl's symbol tables) is occasionally necessary, but
incredibly messy, and easy to get wrong. This module hides all of that behind incredibly messy, and easy to get wrong. This module hides all of that behind
@ -31,7 +33,7 @@ make %{?_smp_mflags}
%install %install
rm -rf %{buildroot} rm -rf %{buildroot}
make pure_install PERL_INSTALL_ROOT=%{buildroot} make pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} \; find %{buildroot} -type f -name .packlist -exec rm -f {} \;
find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
%{_fixperms} %{buildroot} %{_fixperms} %{buildroot}
@ -49,5 +51,10 @@ rm -rf %{buildroot}
%{_mandir}/man3/Package::Stash.3pm* %{_mandir}/man3/Package::Stash.3pm*
%changelog %changelog
* Mon Jun 14 2010 Paul Howarth <paul@city-fan.org> - 0.03-2
- Incorporate package review suggestions (#602597)
- Use %%{?perl_default_filter}
- Use DESTDIR instead of PERL_INSTALL_ROOT
* Mon Jun 7 2010 Paul Howarth <paul@city-fan.org> - 0.03-1 * Mon Jun 7 2010 Paul Howarth <paul@city-fan.org> - 0.03-1
- Initial RPM version - Initial RPM version