Spec clean-up

- Run Perl::Critic test in %check too
- BR: perl(Test::Perl::Critic)
- BR: perl(Carp) and perl(Symbol), which might be dual-lived
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Drop version requirement for perl(ExtUtils::MakeMaker); older versions work
  without problems, e.g. version 6.17 on EL-4
- Make %files list more explicit
- Don't use macros for commands
- Use tabs
This commit is contained in:
Paul Howarth 2012-02-01 16:11:46 +00:00
parent 61692033a7
commit ca2b7d13c0
2 changed files with 56 additions and 43 deletions

2
.gitignore vendored
View File

@ -1 +1 @@
Package-Generator-0.103.tar.gz
/Package-Generator-[0-9.]*.tar.gz

View File

@ -1,22 +1,26 @@
Name: perl-Package-Generator
Version: 0.103
Release: 7%{?dist}
Summary: Generate new packages quickly and easily
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Package-Generator/
Source0: http://search.cpan.org/CPAN/authors/id/R/RJ/RJBS/Package-Generator-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
BuildRequires: perl(ExtUtils::MakeMaker) >= 6.42
BuildRequires: perl(Test::Pod::Coverage)
BuildRequires: perl(Test::Pod)
BuildRequires: perl(Params::Util)
BuildRequires: perl(Scalar::Util)
BuildRequires: perl(Test::More)
Name: perl-Package-Generator
Version: 0.103
Release: 8%{?dist}
Summary: Generate new packages quickly and easily
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Package-Generator/
Source0: http://search.cpan.org/CPAN/authors/id/R/RJ/RJBS/Package-Generator-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
BuildArch: noarch
BuildRequires: perl(Carp)
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Params::Util)
BuildRequires: perl(Scalar::Util)
BuildRequires: perl(Symbol)
BuildRequires: perl(Test::More)
# Test::Perl::Critic not available in EPEL-4
%if "%{rhel}" != "4"
BuildRequires: perl(Test::Perl::Critic)
%endif
BuildRequires: perl(Test::Pod)
BuildRequires: perl(Test::Pod::Coverage)
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
%description
This module lets you quickly and easily construct new packages. It gives
@ -26,21 +30,18 @@ them unused names and sets up their package data, if provided.
%setup -q -n Package-Generator-%{version}
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor
perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
rm -rf %{buildroot}
make pure_install PERL_INSTALL_ROOT=%{buildroot}
make pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} \;
find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
%{_fixperms} %{buildroot}/*
find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
%{_fixperms} %{buildroot}
%check
make test
make test PERL_TEST_CRITIC=1
%clean
rm -rf %{buildroot}
@ -48,10 +49,22 @@ rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc Changes README
%{perl_vendorlib}/*
%{_mandir}/man3/*
%{perl_vendorlib}/Package/
%{_mandir}/man3/Package::Generator.3pm*
%{_mandir}/man3/Package::Reaper.3pm*
%changelog
* Wed Feb 1 2012 Paul Howarth <paul@city-fan.org> - 0.103-8
- Run Perl::Critic test in %%check too
- BR: perl(Test::Perl::Critic)
- BR: perl(Carp) and perl(Symbol), which might be dual-lived
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Drop version requirement for perl(ExtUtils::MakeMaker); older versions work
without problems, e.g. version 6.17 on EL-4
- Make %%files list more explicit
- Don't use macros for commands
- Use tabs
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.103-7
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
@ -62,17 +75,17 @@ rm -rf %{buildroot}
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Tue Dec 21 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.103-4
- 661697 rebuild for fixing problems with vendorach/lib
- Rebuild to fix problems with vendorarch/lib (#661697)
* Tue May 04 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.103-3
- Mass rebuild with perl-5.12.0
* Mon Dec 7 2009 Stepan Kasal <skasal@redhat.com> - 0.103-2
- rebuild against perl 5.10.1
- Rebuild against perl 5.10.1
* Tue Aug 11 2009 Chris Weyl <cweyl@alumni.drew.edu> 0.103-1
- auto-update to 0.103 (by cpan-spec-update 0.01)
- added a new br on perl(ExtUtils::MakeMaker) (version 6.42)
* Tue Aug 11 2009 Chris Weyl <cweyl@alumni.drew.edu> - 0.103-1
- Auto-update to 0.103 (by cpan-spec-update 0.01)
- Added a new br on perl(ExtUtils::MakeMaker) (version 6.42)
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.102-4
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@ -83,13 +96,13 @@ rm -rf %{buildroot}
* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 0.102-2
- Rebuild for perl 5.10 (again)
* Thu Jan 24 2008 Tom "spot" Callaway <tcallawa@redhat.com> 0.102-1
- rebuild for new perl
- update to 0.102
- fix license tag
* Thu Jan 24 2008 Tom "spot" Callaway <tcallawa@redhat.com> - 0.102-1
- Rebuild for new perl
- Update to 0.102
- Fix license tag
* Wed Sep 06 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.100-2
- bump
* Wed Sep 06 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.100-2
- Bump
* Tue Sep 05 2006 Chris Weyl <cweyl@alumni.drew.edu> 0.100-1
- Specfile autogenerated by cpanspec 1.69.1.
* Tue Sep 05 2006 Chris Weyl <cweyl@alumni.drew.edu> - 0.100-1
- Specfile autogenerated by cpanspec 1.69.1