Package cleanup

perl-Mail-SPF.spec

@@ -1,31 +1,42 @@
 Name:           perl-Mail-SPF
 Version:        2.9.0
-Release:        8%{?dist}
+Release:        9%{?dist}
 Summary:        Object-oriented implementation of Sender Policy Framework
 License:        BSD
-Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Mail-SPF/
 Source0:        http://www.cpan.org/authors/id/J/JM/JMEHNLE/mail-spf/Mail-SPF-v%{version}.tar.gz
 Patch0:         Mail-SPF-v2.8.0-POD.patch
 Patch1:         Mail-SPF-v2.8.0-testsuite.patch
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:      noarch
+# Build
+BuildRequires:  coreutils
+BuildRequires:  perl
+BuildRequires:  perl(Module::Build)
+BuildRequires:  perl(version)
+# Runtime
 BuildRequires:  perl(base)
 BuildRequires:  perl(constant)
 BuildRequires:  perl(Error)
-BuildRequires:  perl(Module::Build)
-BuildRequires:  perl(NetAddr::IP) >= 4
 BuildRequires:  perl(Net::DNS) >= 0.62
 BuildRequires:  perl(Net::DNS::Resolver)
-BuildRequires:  perl(Net::DNS::Resolver::Programmable) >= 0.003
-BuildRequires:  perl(Test::More)
-BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(NetAddr::IP) >= 4
+BuildRequires:  perl(overload)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(Sys::Hostname)
 BuildRequires:  perl(URI) >= 1.13
 BuildRequires:  perl(URI::Escape)
-BuildRequires:  perl(version)
+BuildRequires:  perl(utf8)
+BuildRequires:  perl(warnings)
+# Tests only
+BuildRequires:  perl(blib)
+BuildRequires:  perl(Net::DNS::Resolver::Programmable) >= 0.003
+BuildRequires:  perl(Net::DNS::RR)
+BuildRequires:  perl(Test::More)
+# Optional tests only
+BuildRequires:  perl(Test::Pod) >= 1.00
+Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version))
 Requires:       perl(Net::DNS) >= 0.62
 Requires:       perl(URI) >= 1.13
-Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Mail::SPF is an object-oriented implementation of Sender Policy Framework
@@ -33,13 +44,10 @@ Mail::SPF is an object-oriented implementation of Sender Policy Framework
 
 %prep
 %setup -q -n Mail-SPF-v%{version}
-
 # Fix broken POD (CPAN RT#86060)
 %patch0
-
 # Work around test suite failures with Net::DNS ≥ 0.68 (CPAN RT#78214)
 %patch1
-
 chmod -x bin/* sbin/*
 
 %build
@@ -47,28 +55,25 @@ perl Build.PL installdirs=vendor
 ./Build
 
 %install
-rm -rf $RPM_BUILD_ROOT
-./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-%{_fixperms} $RPM_BUILD_ROOT/*
-
+./Build install destdir=%{buildroot} create_packlist=0
+%{_fixperms} %{buildroot}/*
 # Don't include the spfd and spfquery scripts in _bindir.
-rm -f $RPM_BUILD_ROOT%{_bindir}/spfquery $RPM_BUILD_ROOT%{_sbindir}/spfd
-rm -rf $RPM_BUILD_ROOT%{_mandir}/man1
+rm -f %{buildroot}%{_bindir}/spfquery %{buildroot}%{_sbindir}/spfd
+rm -rf %{buildroot}%{_mandir}/man1
 
 %check
 ./Build test
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
-%defattr(-,root,root,-)
-%doc CHANGES LICENSE README TODO bin/ sbin/
+%license LICENSE
+%doc CHANGES README TODO bin/ sbin/
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
 
 %changelog
+* Mon Feb 29 2016 Petr Šabata <contyk@redhat.com> - 2.9.0-9
+- Package cleanup
+
 * Thu Feb 04 2016 Fedora Release Engineering <releng@fedoraproject.org> - 2.9.0-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild