Spec clean-up

- Run author tests too for completeness
- Add buildreqs needed for author tests
- Add buildreqs for core perl modules, which may be dual-lived
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Make %files list more explicit
This commit is contained in:
Paul Howarth 2012-01-12 10:44:37 +00:00
parent ba00106ca0
commit ef8279a640

View File

@ -1,34 +1,33 @@
Name: perl-IPC-System-Simple Name: perl-IPC-System-Simple
Version: 1.21 Version: 1.21
Release: 2%{?dist} Release: 3%{?dist}
# lib/IPC/System/Simple.pm -> GPL+ or Artistic License: GPL+ or Artistic
License: GPL+ or Artistic Group: Development/Libraries
Group: Development/Libraries Summary: Run commands simply, with detailed diagnostics
Summary: Run commands simply, with detailed diagnostics Url: http://search.cpan.org/dist/IPC-System-Simple
Source: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz Source: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz
Url: http://search.cpan.org/dist/IPC-System-Simple BuildArch: noarch
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildRequires: perl(BSD::Resource)
BuildArch: noarch BuildRequires: perl(Carp)
BuildRequires: perl(Config)
BuildRequires: perl(ExtUtils::MakeMaker) >= 6.42 BuildRequires: perl(Exporter)
BuildRequires: perl(Config) BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(File::Basename) BuildRequires: perl(File::Basename)
BuildRequires: perl(File::Spec) BuildRequires: perl(File::Spec)
BuildRequires: perl(List::Util) BuildRequires: perl(List::Util)
BuildRequires: perl(Scalar::Util) BuildRequires: perl(POSIX)
# testing BuildRequires: perl(Scalar::Util)
BuildRequires: perl(BSD::Resource) BuildRequires: perl(Test)
BuildRequires: perl(Test) BuildRequires: perl(Test::Kwalitee)
BuildRequires: perl(Test::More) BuildRequires: perl(Test::More)
BuildRequires: perl(Test::NoWarnings) BuildRequires: perl(Test::NoWarnings)
# These are explicitly marked as AUTHOR_TESTS, and we skip those. BuildRequires: perl(Test::Perl::Critic)
#BuildRequires: perl(Test::Pod) BuildRequires: perl(Test::Pod)
#BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod::Coverage)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description %description
Calling Perl's in-built 'system()' function is easy, determining if it Calling Perl's in-built 'system()' function is easy; determining if it
was successful is _hard_. Let's face it, '$?' isn't the nicest variable was successful is _hard_. Let's face it, '$?' isn't the nicest variable
in the world to play with, and even if you _do_ check it, producing a in the world to play with, and even if you _do_ check it, producing a
well-formatted error string takes a lot of work. 'IPC::System::Simple' well-formatted error string takes a lot of work. 'IPC::System::Simple'
@ -37,62 +36,67 @@ want to be really lazy, you can just write:
use IPC::System::Simple qw(system); use IPC::System::Simple qw(system);
and all of your "system" commands will either succeeed (run to completion and and all of your "system" commands will either succeed (run to completion and
return a zero exit value), or die with rich diagnostic messages. return a zero exit value), or die with rich diagnostic messages.
%prep %prep
%setup -q -n IPC-System-Simple-%{version} %setup -q -n IPC-System-Simple-%{version}
find . -type f -exec chmod -x {} \; # Avoid doc-file dependencies
chmod -c -x examples/*.pl
%build %build
%{__perl} Makefile.PL INSTALLDIRS=vendor perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags} make %{?_smp_mflags}
%install %install
make pure_install PERL_INSTALL_ROOT=%{buildroot} make pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} \; find %{buildroot} -type f -name .packlist -exec rm -f {} \;
find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
%{_fixperms} %{buildroot}
%{_fixperms} %{buildroot}/*
%check %check
make test make test TEST_AUTHOR=1
%files %files
%defattr(-,root,root,-) %doc Changes LICENSE README examples/
%doc Changes LICENSE README examples/ %{perl_vendorlib}/IPC/
%{perl_vendorlib}/* %{_mandir}/man3/IPC::System::Simple.3pm*
%{_mandir}/man3/*.3*
%changelog %changelog
* Thu Jan 12 2012 Paul Howarth <paul@city-fan.org> - 1.21-3
- Run author tests too for completeness
- Add buildreqs needed for author tests
- Add buildreqs for core perl modules, which may be dual-lived
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Make %%files list more explicit
* Wed Jul 20 2011 Petr Sabata <contyk@redhat.com> - 1.21-2 * Wed Jul 20 2011 Petr Sabata <contyk@redhat.com> - 1.21-2
- Perl mass rebuild - Perl mass rebuild
* Fri Mar 18 2011 Iain Arnell <iarnell@gmail.com> 1.21-1 * Fri Mar 18 2011 Iain Arnell <iarnell@gmail.com> - 1.21-1
- update to latest upstream version - Update to latest upstream version
- clean up spec for modern rpmbuild - Clean up spec for modern rpmbuild
* Tue Feb 08 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.18-6 * Tue Feb 08 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.18-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Mon Dec 20 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.18-5 * Mon Dec 20 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.18-5
- 661697 rebuild for fixing problems with vendorach/lib - Rebuild to fix problems with vendorarch/lib (#661697)
* Sun May 02 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.18-4 * Sun May 02 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.18-4
- Mass rebuild with perl-5.12.0 - Mass rebuild with perl-5.12.0
* Mon Dec 7 2009 Stepan Kasal <skasal@redhat.com> - 1.18-3 * Mon Dec 07 2009 Stepan Kasal <skasal@redhat.com> - 1.18-3
- rebuild against perl 5.10.1 - Rebuild against perl 5.10.1
* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.18-2 * Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.18-2
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
* Thu Mar 05 2009 Chris Weyl <cweyl@alumni.drew.edu> 1.18-1 * Thu Mar 05 2009 Chris Weyl <cweyl@alumni.drew.edu> - 1.18-1
- submission - Submission
* Thu Mar 05 2009 Chris Weyl <cweyl@alumni.drew.edu> 1.18-0 * Thu Mar 05 2009 Chris Weyl <cweyl@alumni.drew.edu> - 1.18-0
- initial RPM packaging - Initial RPM packaging
- generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.8) - Generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.8)