From 2faa6b9e8d5864e5f3c33f0a8ed44f07fdf34c1d Mon Sep 17 00:00:00 2001
From: Robin Norwood <rnorwood@fedoraproject.org>
Date: Fri, 26 Oct 2007 19:57:41 +0000
Subject: [PATCH] Various fixes from package review.

---
 perl-IO-String.spec | 33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/perl-IO-String.spec b/perl-IO-String.spec
index 5938349..1fab6d3 100644
--- a/perl-IO-String.spec
+++ b/perl-IO-String.spec
@@ -1,21 +1,17 @@
-%{!?perl_vendorlib: %define perl_vendorlib %(eval "`%{__perl} -V:installvendorlib`"; echo $installvendorlib)}
-
 Name:           perl-IO-String
 Version:        1.08
-Release:        2
-
+Release:        3%{?dist}
 Summary:        Emulate file interface for in-core strings
 
 Group:          Development/Libraries
 License:        GPL+ or Artistic
 URL:            http://search.cpan.org/dist/IO-String/
-Source0:        http://www.cpan.org/authors/id/G/GA/GAAS/IO-String-1.08.tar.gz
+Source0:        http://www.cpan.org/authors/id/G/GA/GAAS/IO-String-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildArch:      noarch
-BuildRequires:  perl >= 1:5.6.1
 BuildRequires:  perl(ExtUtils::MakeMaker)
-Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %description
 The "IO::String" module provides the "IO::File" interface for in-core
@@ -49,7 +45,7 @@ find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
 
 
-%check || :
+%check
 make test
 
 
@@ -65,17 +61,26 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %changelog
-* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@redhat.com> - 0:1.08-2
+* Fri Oct 26 2007 Robin Norwood <rnorwood@redhat.com> - 1.08-3
+- Fix various package review issues:
+- Remove BR: perl
+- Remove "|| :" from check section
+- Add dist tag
+- Fix Source URL
+- Fix old changelog entries
+- Resolves: bz#226265
+
+* Tue Oct 16 2007 Tom "spot" Callaway <tcallawa@redhat.com> - 1.08-2
 - correct license tag
 - add BR: perl(ExtUtils::MakeMaker)
 
-* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - sh: line 0: fg: no job control
+* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - 1.08-1.2
 - rebuild
 
-* Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 0:1.08-1.1
+* Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 1.08-1.1
 - rebuild for new perl-5.8.8
 
-* Fri Dec 16 2005 Jason Vas Dias <jvdias@redhat.com> - 0:1.08-1
+* Fri Dec 16 2005 Jason Vas Dias <jvdias@redhat.com> - 1.08-1
 - 1.08
 
 * Sun Nov 06 2005 Florian La Roche <laroche@redhat.com>
@@ -84,8 +89,8 @@ rm -rf $RPM_BUILD_ROOT
 * Fri Apr  7 2005 Michael Schwendt <mschwendt[AT]users.sf.net>
 - rebuilt
 
-* Wed Nov 24 2004 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0:1.06-1
+* Wed Nov 24 2004 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.06-1
 - Update to 1.06.
 
-* Sun Jul 04 2004 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0:1.05-0.fdr.1
+* Sun Jul 04 2004 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.05-0.fdr.1
 - First build.