From 28e5c9c053938770dbc5a85ea41d7939bdea28f5 Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul@city-fan.org>
Date: Sun, 29 Sep 2019 10:33:24 +0100
Subject: [PATCH] Spec tidy-up

- Use author-independent source URL
- Classify builds by usage
- Drop redundant buildroot cleaning in %install section
- Don't need to delete empty directories from the buildroot
- Make %files list more explicit
---
 perl-ExtUtils-PkgConfig.rpmlintrc |  3 ++
 perl-ExtUtils-PkgConfig.spec      | 50 ++++++++++++++++---------------
 2 files changed, 29 insertions(+), 24 deletions(-)
 create mode 100644 perl-ExtUtils-PkgConfig.rpmlintrc

diff --git a/perl-ExtUtils-PkgConfig.rpmlintrc b/perl-ExtUtils-PkgConfig.rpmlintrc
new file mode 100644
index 0000000..d8dfeec
--- /dev/null
+++ b/perl-ExtUtils-PkgConfig.rpmlintrc
@@ -0,0 +1,3 @@
+from Config import *
+addFilter("spelling-error Summary\(en_US\) config -> ")
+addFilter("spelling-error %description -l en_US config -> ")
diff --git a/perl-ExtUtils-PkgConfig.spec b/perl-ExtUtils-PkgConfig.spec
index 4c12f0a..31e379d 100644
--- a/perl-ExtUtils-PkgConfig.spec
+++ b/perl-ExtUtils-PkgConfig.spec
@@ -1,27 +1,30 @@
 Name:           perl-ExtUtils-PkgConfig
 Version:        1.16
-Release:        9%{?dist}
+Release:        10%{?dist}
 Summary:        Simplistic interface to pkg-config
-
 License:        LGPLv2+
 URL:            https://metacpan.org/release/ExtUtils-PkgConfig
-Source0:        https://cpan.metacpan.org/authors/id/X/XA/XAOC/ExtUtils-PkgConfig-%{version}.tar.gz
+Source0:        https://cpan.metacpan.org/modules/by-module/ExtUtils/ExtUtils-PkgConfig-%{version}.tar.gz
 BuildArch:      noarch
+# Module Build
 BuildRequires:  coreutils
 BuildRequires:  findutils
 BuildRequires:  make
-BuildRequires:  pkgconfig
-BuildRequires:  perl-interpreter
 BuildRequires:  perl-generators
-BuildRequires:  perl(Carp)
+BuildRequires:  perl-interpreter
 BuildRequires:  perl(Cwd)
-BuildRequires:  perl(English)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# Module Runtime
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(English)
 BuildRequires:  perl(strict)
-BuildRequires:  perl(Test::More)
 BuildRequires:  perl(vars)
+BuildRequires:  pkgconfig
+# Test Suite
+BuildRequires:  perl(Test::More)
 BuildRequires:  perl(warnings)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:       pkgconfig
 
 %description
@@ -29,40 +32,39 @@ The pkg-config program retrieves information about installed libraries,
 usually for the purposes of compiling against and linking to them.
 
 ExtUtils::PkgConfig is a very simplistic interface to this utility,
-intended for use in the Makefile.PL of perl extensions which bind
+intended for use in the Makefile.PL of perl extensions that bind
 libraries that pkg-config knows. It is really just boilerplate code
 that you would've written yourself.
 
-
 %prep
 %setup -q -n ExtUtils-PkgConfig-%{version}
 
-
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
-
 %install
-rm -rf $RPM_BUILD_ROOT
-make pure_install DESTDIR=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -delete
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
-
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+%{_fixperms} -c %{buildroot}
 
 %check
 make test
 
-
-
 %files
 %doc Changes README
 %{perl_vendorlib}/ExtUtils/
-%{_mandir}/man3/*.3pm*
-
+%{_mandir}/man3/ExtUtils::PkgConfig.3*
 
 %changelog
+* Sun Sep 29 2019 Paul Howarth <paul@city-fan.org> - 1.16-10
+- Spec tidy-up
+  - Use author-independent source URL
+  - Classify builds by usage
+  - Drop redundant buildroot cleaning in %%install section
+  - Don't need to delete empty directories from the buildroot
+  - Make %%files list more explicit
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.16-9
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild