From 2c527e82badd0bbff2bb5bdf4bff0801ce79e538 Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul@city-fan.org>
Date: Fri, 8 Jan 2021 11:05:29 +0000
Subject: [PATCH] Spec tidy-up

- Specify all build dependencies
- Use author-independent source URL
- Use %{make_build} and %{make_install}
- Fix permissions verbosely
- Use %license macro
- Make %files list more explicit
---
 perl-DateTime-Format-HTTP.spec | 43 +++++++++++++++++++++++-----------
 1 file changed, 29 insertions(+), 14 deletions(-)

diff --git a/perl-DateTime-Format-HTTP.spec b/perl-DateTime-Format-HTTP.spec
index 4458d68..17e22bd 100644
--- a/perl-DateTime-Format-HTTP.spec
+++ b/perl-DateTime-Format-HTTP.spec
@@ -1,16 +1,18 @@
 Name:           perl-DateTime-Format-HTTP
 Version:        0.42
-Release:        17%{?dist}
+Release:        18%{?dist}
 Summary:        HTTP protocol date conversion routines
 License:        GPL+ or Artistic
 URL:            https://metacpan.org/release/DateTime-Format-HTTP
-Source0:        https://cpan.metacpan.org/authors/id/C/CK/CKRAS/DateTime-Format-HTTP-%{version}.tar.gz
+Source0:        https://cpan.metacpan.org/modules/by-module/DateTime/DateTime-Format-HTTP-%{version}.tar.gz
 BuildArch:      noarch
 # Build
-BuildRequires: make
-BuildRequires:  perl-interpreter
+BuildRequires:  coreutils
+BuildRequires:  make
 BuildRequires:  perl-generators
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl-interpreter
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires:  sed
 # Runtime
 BuildRequires:  perl(DateTime) >= 0.17
 BuildRequires:  perl(HTTP::Date) => 1.44
@@ -20,10 +22,12 @@ BuildRequires:  perl(warnings)
 # Tests only
 BuildRequires:  perl(lib)
 BuildRequires:  perl(Test::More) >= 0.47
-Requires:  perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version))
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version))
 Requires:       perl(DateTime) >= 0.17
 Requires:       perl(HTTP::Date) >= 1.44
 
+# Filter underspecified dependencies
 %global __requires_exclude %{?__requires_exclude|%__requires_exclude|}^perl\\(DateTime\\)$
 %global __requires_exclude %{?__requires_exclude|%__requires_exclude|}^perl\\(HTTP::Date\\)$
 
@@ -33,26 +37,37 @@ HTTP protocol (and then some).
 
 %prep
 %setup -q -n DateTime-Format-HTTP-%{version}
+
+# Fix line endings
 sed -i -e 's/\r//' LICENSE README Changes CREDITS
 
 %build
-perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-make %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{make_build}
 
 %install
-make pure_install DESTDIR=%{buildroot}
-%{_fixperms} %{buildroot}/*
+%{make_install}
+%{_fixperms} -c %{buildroot}
 
 %check
 make test
 
 %files
-%doc LICENSE Changes CREDITS README
-%{perl_vendorlib}/*
-%{_mandir}/man3/*.3*
-
+%license LICENSE
+%doc Changes CREDITS README
+%{perl_vendorlib}/DateTime/
+%{_mandir}/man3/DateTime::Format::HTTP.3*
 
 %changelog
+* Fri Jan  8 2021 Paul Howarth <paul@city-fan.org> - 0.42-18
+- Spec tidy-up
+  - Specify all build dependencies
+  - Use author-independent source URL
+  - Use %%{make_build} and %%{make_install}
+  - Fix permissions verbosely
+  - Use %%license macro
+  - Make %%files list more explicit
+
 * Tue Jul 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.42-17
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild