From d9753ef21642dc852faeaa3b4cb71efa38485aa4 Mon Sep 17 00:00:00 2001
From: Robin Norwood <rnorwood@fedoraproject.org>
Date: Tue, 6 Feb 2007 05:21:15 +0000
Subject: [PATCH] incorporate changes from jpo@di.uminho.pt for package review.

---
 .cvsignore             |  3 +--
 perl-Convert-ASN1.spec | 42 +++++++++++++++++++++++++++---------------
 sources                |  2 +-
 3 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/.cvsignore b/.cvsignore
index 015efd2..dcc5d47 100644
--- a/.cvsignore
+++ b/.cvsignore
@@ -1,2 +1 @@
-Convert-ASN1-0.19.tar.gz
-Convert-ASN1-0.20.tar.gz
+Convert-ASN1-0.21.tar.gz
diff --git a/perl-Convert-ASN1.spec b/perl-Convert-ASN1.spec
index 846bdc5..fb9c4e9 100644
--- a/perl-Convert-ASN1.spec
+++ b/perl-Convert-ASN1.spec
@@ -1,25 +1,32 @@
-Summary:        Convert-ASN1 Perl module
+Summary:        ASN.1 Encode/Decode library
 Name:           perl-Convert-ASN1
-Version:        0.20
-Release: 	1.1
+Version:        0.21
+Release:        1%{?dist}
 
 Group:          Development/Libraries
 License:        GPL or Artistic
 URL:            http://search.cpan.org/dist/Convert-ASN1/
-Source0:     	http://www.cpan.org/authors/id/G/GB/GBARR/Convert-ASN1-%{version}.tar.gz
+Source0:        http://www.cpan.org/authors/id/G/GB/GBARR/Convert-ASN1-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildArch:      noarch
-BuildRequires:  perl >= 1:5.6.1
-Requires:  	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %description
-%{summary}.
+Convert::ASN1 encodes and decodes ASN.1 data structures using BER/DER rules.
 
 
 %prep
 %setup -q -n Convert-ASN1-%{version}
 
+# Provides: exclude perl(Convert::ASN1)
+cat <<__EOF__ > %{name}-perl.prov
+#!/bin/sh
+/usr/lib/rpm/perl.prov \$* | grep -v '^perl(Convert::ASN1)$'
+__EOF__
+%define __perl_provides %{_builddir}/Convert-ASN1-%{version}/%{name}-perl.prov
+chmod +x %{__perl_provides}
+
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
@@ -28,11 +35,10 @@ make %{?_smp_mflags}
 rm -rf $RPM_BUILD_ROOT
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
+find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
 
-%check || :
-mv t/0-signature.t t/0-signature.t.skip
+%check
 make test
 
 %clean
@@ -43,16 +49,22 @@ rm -rf $RPM_BUILD_ROOT
 %defattr(-,root,root,-)
 %doc ChangeLog README examples/
 %{perl_vendorlib}/Convert/
-%{_mandir}/man3/*.3*
+%{_mandir}/man3/*.3pm*
+
 
 %changelog
-* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - sh: line 0: fg: no job control
+* Sat Feb  3 2007 Jose Pedro Oliveira <jpo at di.uminho.pt> - 0.21-1
+- Update to 0.21.
+- Corrected several changelog entries.
+- Removed an explicit perl(Convert::ASN1) provides.
+
+* Wed Jul 12 2006 Jesse Keating <jkeating@redhat.com> - 0.20-1.1
 - rebuild
 
-* Thu Mar 09 2006 Jason Vas Dias <jvdias@redhat.com> - 1.20-1
-- upgrade to upstream version 1.20-1
+* Thu Mar 09 2006 Jason Vas Dias <jvdias@redhat.com> - 0.20-1
+- upgrade to upstream version 0.20
 
-* Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 1.19-1.2
+* Fri Feb 03 2006 Jason Vas Dias <jvdias@redhat.com> - 0.19-1.2
 - rebuild for new perl-5.8.8
 
 * Fri Dec 16 2005 Jesse Keating <jkeating@redhat.com>
diff --git a/sources b/sources
index df1e31d..9a9053d 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-b6bce0b7a88f52dc27182b6fb82868c9  Convert-ASN1-0.20.tar.gz
+6f5c45724db1b09911e489275d19d0f5  Convert-ASN1-0.21.tar.gz