Update to 1.5

- New upstream release 1.5
  - Work around global destruction order issue (CPAN RT#23568/68526)
- This release by SHAY ⇒ update source URL
- Drop %defattr, redundant since rpm 4.4
- Don't use macros for commands
- Don't need to remove empty directories from the buildroot
- Classify buildreqs by usage
- Make %files list more explicit

.gitignore

@@ -1 +1 @@
-Class-Singleton-1.4.tar.gz
+/Class-Singleton-[0-9.]*.tar.gz

perl-Class-Singleton.spec

@@ -1,16 +1,25 @@
 Name:           perl-Class-Singleton
-Version:        1.4
-Release:        18%{?dist}
+Version:        1.5
+Release:        1%{?dist}
 Summary:        Implementation of a "Singleton" class
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Class-Singleton/
-Source0:        http://www.cpan.org/authors/id/A/AB/ABW/Class-Singleton-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+Source0:        http://www.cpan.org/authors/id/S/SH/SHAY/Class-Singleton-%{version}.tar.gz
+BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:      noarch
+# Module Build
+BuildRequires:  perl
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# Module Runtime
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
+# Test Suite
+BuildRequires:  perl(base)
+BuildRequires:  perl(lib)
 BuildRequires:  perl(Test::More)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+# Runtime
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This is the Class::Singleton module. A Singleton describes an object class
@@ -26,18 +35,14 @@ method and can implement whatever specific functionality is required.
 %setup -q -n Class-Singleton-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
 rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
 
 %check
 make test
@@ -46,12 +51,21 @@ make test
 rm -rf $RPM_BUILD_ROOT
 
 %files
-%defattr(-,root,root,-)
 %doc Changes README
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Class/
+%{_mandir}/man3/Class::Singleton.3*
 
 %changelog
+* Mon Nov 10 2014 Paul Howarth <paul@city-fan.org> - 1.5-1
+- Update to 1.5
+  - Work around global destruction order issue (CPAN RT#23568/68526)
+- This release by SHAY ⇒ update source URL
+- Drop %%defattr, redundant since rpm 4.4
+- Don't use macros for commands
+- Don't need to remove empty directories from the buildroot
+- Classify buildreqs by usage
+- Make %%files list more explicit
+
 * Tue Aug 26 2014 Jitka Plesnikova <jplesnik@redhat.com> - 1.4-18
 - Perl 5.20 rebuild
 
@@ -83,7 +97,7 @@ rm -rf $RPM_BUILD_ROOT
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Wed Dec 15 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.4-8
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Fri Apr 30 2010 Marcela Maslanova <mmaslano@redhat.com> - 1.4-7
 - Mass rebuild with perl-5.12.0

sources

@@ -1 +1 @@
-a18b108ab97e2107cbbe816d2b3e2ee3  Class-Singleton-1.4.tar.gz
+6a2524f590eda075f4bc929598119241  Class-Singleton-1.5.tar.gz