Clean up and fix FTBFS (#914249)

- BR: perl(base), perl(Carp), perl(ExtUtils::MakeMaker) and perl(Sub::Name),
  fixing FTBFS (#914249)
- Enhance %description
- Drop %defattr, redundant since rpm 4.4
- Don't need to remove empty directories from the buildroot
- Don't use macros for commands
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Use %{_fixperms} macro rather than our own chmod incantation
- Make %files list more explicit
This commit is contained in:
Paul Howarth 2013-02-26 10:32:58 +00:00
parent c5345c5c77
commit af70e271df

View File

@ -1,33 +1,35 @@
Name: perl-Class-Accessor
Version: 0.34
Release: 11%{?dist}
Release: 12%{?dist}
Summary: Automated accessor generation
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Class-Accessor/
Source0: http://search.cpan.org/CPAN/authors/id/K/KA/KASEI/Class-Accessor-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
BuildArch: noarch
BuildRequires: perl >= 1:5.6.1, perl(Test::More)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
BuildRequires: perl(base)
BuildRequires: perl(Carp)
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Sub::Name)
BuildRequires: perl(Test::More)
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
%description
%{summary}.
This module automagically generates accessors/mutators for your class.
%prep
%setup -q -n Class-Accessor-%{version}
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor
perl Makefile.PL INSTALLDIRS=vendor
make
%install
rm -rf $RPM_BUILD_ROOT
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
chmod -R u+w $RPM_BUILD_ROOT/*
%{_fixperms} $RPM_BUILD_ROOT
%check
make test
@ -36,13 +38,24 @@ make test
rm -rf $RPM_BUILD_ROOT
%files
%defattr(-,root,root,-)
%doc Changes examples/
%{perl_vendorlib}/Class
%{_mandir}/man3/*.3*
%{perl_vendorlib}/Class/
%{_mandir}/man3/Class::Accessor.3pm*
%{_mandir}/man3/Class::Accessor::Fast.3pm*
%{_mandir}/man3/Class::Accessor::Faster.3pm*
%changelog
* Tue Feb 26 2013 Paul Howarth <paul@city-fan.org> - 0.34-12
- BR: perl(base), perl(Carp), perl(ExtUtils::MakeMaker) and perl(Sub::Name),
fixing FTBFS (#914249)
- Enhance %%description
- Drop %%defattr, redundant since rpm 4.4
- Don't need to remove empty directories from the buildroot
- Don't use macros for commands
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Use %%{_fixperms} macro rather than our own chmod incantation
- Make %%files list more explicit
* Thu Feb 14 2013 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.34-11
- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
@ -65,7 +78,7 @@ rm -rf $RPM_BUILD_ROOT
- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Dec 15 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.34-4
- 661697 rebuild for fixing problems with vendorach/lib
- Rebuild to fix problems with vendorarch/lib (#661697)
* Fri Apr 30 2010 Marcela Maslanova <mmaslano@redhat.com> - 0.34-3
- Mass rebuild with perl-5.12.0
@ -110,7 +123,7 @@ rm -rf $RPM_BUILD_ROOT
- bump to 0.22
* Fri Aug 5 2005 Tom "spot" Callaway <tcallawa@redhat.com> 0.19-3
- add examples/ to %doc
- add examples/ to %%doc
* Fri Jul 8 2005 Tom "spot" Callaway <tcallawa@redhat.com> 0.19-2
- cleanups