36 lines
1.1 KiB
Diff
36 lines
1.1 KiB
Diff
From cd950e6b7f85f4f8f80284ba79a027dee57bfa61 Mon Sep 17 00:00:00 2001
|
|
From: Stefano Brivio <sbrivio@redhat.com>
|
|
Date: Mon, 27 Feb 2023 03:13:31 +0100
|
|
Subject: [PATCH 06/20] tcp: Avoid (theoretical) resource leak (CWE-772)
|
|
Coverity warning
|
|
|
|
If tcp_timer_ctl() gets a socket number greater than SOCKET_MAX
|
|
(2 ^ 24), we return error but we don't close the socket. This is a
|
|
rather formal issue given that, at least on Linux, socket numbers are
|
|
monotonic and we're in general not allowed to open so many sockets.
|
|
|
|
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
|
|
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
|
|
(cherry picked from commit 4f523c3276741781346478328f863e60f30cba8e)
|
|
---
|
|
tcp.c | 3 +++
|
|
1 file changed, 3 insertions(+)
|
|
|
|
diff --git a/tcp.c b/tcp.c
|
|
index a811b5e..fe6e458 100644
|
|
--- a/tcp.c
|
|
+++ b/tcp.c
|
|
@@ -702,6 +702,9 @@ static void tcp_timer_ctl(const struct ctx *c, struct tcp_tap_conn *conn)
|
|
fd = timerfd_create(CLOCK_MONOTONIC, 0);
|
|
if (fd == -1 || fd > SOCKET_MAX) {
|
|
debug("TCP: failed to get timer: %s", strerror(errno));
|
|
+ if (fd > -1)
|
|
+ close(fd);
|
|
+ conn->timer = -1;
|
|
return;
|
|
}
|
|
conn->timer = fd;
|
|
--
|
|
2.39.2
|
|
|