From 5bbbf14e51638909a331046e1df8c125ff4bb5e5 Mon Sep 17 00:00:00 2001 From: Marek Kasik Date: Thu, 18 Sep 2025 16:52:05 +0200 Subject: [PATCH] Fix crash on repeated signing Resolves: RHEL-109515 --- papers-47.0-fix-wrong-clear.patch | 30 ++++++++++++++++++++++++++++++ papers.spec | 3 +++ 2 files changed, 33 insertions(+) create mode 100644 papers-47.0-fix-wrong-clear.patch diff --git a/papers-47.0-fix-wrong-clear.patch b/papers-47.0-fix-wrong-clear.patch new file mode 100644 index 0000000..d7e5936 --- /dev/null +++ b/papers-47.0-fix-wrong-clear.patch @@ -0,0 +1,30 @@ +From 91e0945415c0c4d4c4690760e2b9f64d081639fa Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= +Date: Fri, 11 Apr 2025 00:15:21 +0200 +Subject: [PATCH 075/500] libdocument/pps-signature: Fix wrong object clear + call on rect finalize + +PpsRectangle is a boxed type whose free function is just g_free, +not g_object_unref. + +So fix a crash on signature cleanup +--- + libdocument/pps-signature.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/libdocument/pps-signature.c b/libdocument/pps-signature.c +index 8b1be9fe4..26e620ed6 100644 +--- a/libdocument/pps-signature.c ++++ b/libdocument/pps-signature.c +@@ -71,7 +71,7 @@ pps_signature_finalize (GObject *object) + g_clear_pointer (&priv->password, g_free); + g_clear_pointer (&priv->signature, g_free); + g_clear_pointer (&priv->signature_left, g_free); +- g_clear_object (&priv->rect); ++ g_clear_pointer (&priv->rect, g_free); + g_clear_pointer (&priv->document_owner_password, g_free); + g_clear_pointer (&priv->document_user_password, g_free); + g_clear_pointer (&priv->signature_time, g_date_time_unref); +-- +2.51.0 + diff --git a/papers.spec b/papers.spec index dd5dcec..842268a 100644 --- a/papers.spec +++ b/papers.spec @@ -55,6 +55,9 @@ Patch: papers-47.0-help.patch # Fix openning of linked files Patch: papers-47.0-launch-target-file.patch +# Fix crash during repeated signing +Patch: papers-47.0-fix-wrong-clear.patch + # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval ExcludeArch: %{ix86}