rpms/package-notes
5
0
Fork 0
Code Issues Pull Requests Releases Activity
9da9df8af2
package-notes/macros.package-notes-srpm

33 lines
1.6 KiB
Plaintext
Raw Normal View History

Add %_package_note_linker and document everything (rhbz#2043178, rhbz#2043368)
2022-01-22 10:57:31 +00:00
# This file is part of the package-notes package.
#
Add package-notes-srpm-macros subpackage to configure rpm builds
2022-01-14 17:50:39 +00:00
# Add an ELF note with information about the package the code was compiled for.
# See https://fedoraproject.org/wiki/Changes/Package_information_on_ELF_objects
# for details.
Add %_package_note_linker and document everything (rhbz#2043178, rhbz#2043368)
2022-01-22 10:57:31 +00:00
#
# To opt out of the use of this feature completely, include this in
# the spec file:
#
Switch to --package-metadata Use a compiler specs file to avoid issues with escaping and quoting when a package is built using autotools. Generate the osCpe string at build time for now, as it's not set as an env var by rpm yet.
2022-08-04 23:36:28 +00:00
# %undefine _package_note_flags
Add %_package_note_linker and document everything (rhbz#2043178, rhbz#2043368)
2022-01-22 10:57:31 +00:00
#
Disable notes with linkers other than bfd %_package_note_linker != "bfd" disables note insertion, so that it also works as another opt-out mechanism. Maybe we can improve support in the future. From https://bugzilla.redhat.com/show_bug.cgi?id=2043178#c26: It turns out that gold does something wrong with sections. When we add the new section, it shifts existing sections (and even gets one section less than before): │ - Entry point address: 0x500 │ + Entry point address: 0x50 │ Start of program headers: 64 (bytes into file) │ - Start of section headers: 6328 (bytes into file) │ + Start of section headers: 8344 (bytes into file) │ Flags: 0x0 │ Size of this header: 64 (bytes) │ Size of program headers: 56 (bytes) │ - Number of program headers: 9 │ + Number of program headers: 8 │ Size of section headers: 64 (bytes) │ - Number of section headers: 36 │ - Section header string table index: 35 │ + Number of section headers: 38 │ + Section header string table index: 37 There's a bug open to add INSERT AFTER [https://sourceware.org/bugzilla/show_bug.cgi?id=15373], but it's 8 years old. Opting out seems to be the best we can do for now. I also noticed that gold support -dT, only lld doesn't, so the conditional is adjusted accordingly.
2022-01-24 12:07:46 +00:00
# Which linker will be used? This should be either "bfd", "gold", or
Switch to --package-metadata Use a compiler specs file to avoid issues with escaping and quoting when a package is built using autotools. Generate the osCpe string at build time for now, as it's not set as an env var by rpm yet.
2022-08-04 23:36:28 +00:00
# "mold". Unfortunately "lld" does not support the --package-metadata flag so
# the note insertion is disabled when using it.
Disable notes when clang toolchain is used on arm Per https://bugzilla.redhat.com/show_bug.cgi?id=2043178#c27.
2022-01-25 17:19:07 +00:00
#
# (The default linker for clang on armv7hl is lld.)
%_package_note_linker %["%_target_cpu" == "armv7hl" && "%{toolchain}" == "clang" ? "lld" : "bfd"]
Add %_package_note_linker and document everything (rhbz#2043178, rhbz#2043368)
2022-01-22 10:57:31 +00:00
Switch to --package-metadata Use a compiler specs file to avoid issues with escaping and quoting when a package is built using autotools. Generate the osCpe string at build time for now, as it's not set as an env var by rpm yet.
2022-08-04 23:36:28 +00:00
# These are defined for backwards compatibility. Do not use.
%_package_note_file 1
%_generate_package_note_file %{nil}
Add %_package_note_linker and document everything (rhbz#2043178, rhbz#2043368)
2022-01-22 10:57:31 +00:00
Disable notes with linkers other than bfd %_package_note_linker != "bfd" disables note insertion, so that it also works as another opt-out mechanism. Maybe we can improve support in the future. From https://bugzilla.redhat.com/show_bug.cgi?id=2043178#c26: It turns out that gold does something wrong with sections. When we add the new section, it shifts existing sections (and even gets one section less than before): │ - Entry point address: 0x500 │ + Entry point address: 0x50 │ Start of program headers: 64 (bytes into file) │ - Start of section headers: 6328 (bytes into file) │ + Start of section headers: 8344 (bytes into file) │ Flags: 0x0 │ Size of this header: 64 (bytes) │ Size of program headers: 56 (bytes) │ - Number of program headers: 9 │ + Number of program headers: 8 │ Size of section headers: 64 (bytes) │ - Number of section headers: 36 │ - Section header string table index: 35 │ + Number of section headers: 38 │ + Section header string table index: 37 There's a bug open to add INSERT AFTER [https://sourceware.org/bugzilla/show_bug.cgi?id=15373], but it's 8 years old. Opting out seems to be the best we can do for now. I also noticed that gold support -dT, only lld doesn't, so the conditional is adjusted accordingly.
2022-01-24 12:07:46 +00:00
# Overall status: 1 if looks like we can insert the note, 0 otherwise
Switch to --package-metadata Use a compiler specs file to avoid issues with escaping and quoting when a package is built using autotools. Generate the osCpe string at build time for now, as it's not set as an env var by rpm yet.
2022-08-04 23:36:28 +00:00
%_package_note_status %[0%{?_package_note_file:1} && 0%{?name:1} && "%_target_cpu" != "noarch" && "%_package_note_linker" != "lld" ? 1 : 0]
Disable notes with linkers other than bfd %_package_note_linker != "bfd" disables note insertion, so that it also works as another opt-out mechanism. Maybe we can improve support in the future. From https://bugzilla.redhat.com/show_bug.cgi?id=2043178#c26: It turns out that gold does something wrong with sections. When we add the new section, it shifts existing sections (and even gets one section less than before): │ - Entry point address: 0x500 │ + Entry point address: 0x50 │ Start of program headers: 64 (bytes into file) │ - Start of section headers: 6328 (bytes into file) │ + Start of section headers: 8344 (bytes into file) │ Flags: 0x0 │ Size of this header: 64 (bytes) │ Size of program headers: 56 (bytes) │ - Number of program headers: 9 │ + Number of program headers: 8 │ Size of section headers: 64 (bytes) │ - Number of section headers: 36 │ - Section header string table index: 35 │ + Number of section headers: 38 │ + Section header string table index: 37 There's a bug open to add INSERT AFTER [https://sourceware.org/bugzilla/show_bug.cgi?id=15373], but it's 8 years old. Opting out seems to be the best we can do for now. I also noticed that gold support -dT, only lld doesn't, so the conditional is adjusted accordingly.
2022-01-24 12:07:46 +00:00
Switch to --package-metadata Use a compiler specs file to avoid issues with escaping and quoting when a package is built using autotools. Generate the osCpe string at build time for now, as it's not set as an env var by rpm yet.
2022-08-04 23:36:28 +00:00
# The linker flags to be passed to the compiler to insert the notes section will be created by the spec file,
# to avoid issues with quoting and escaping across different build systems and shells.
%_package_note_flags %[%_package_note_status?"-specs=/usr/lib/rpm/redhat/redhat-package-notes":""]
Add package-notes-srpm-macros subpackage to configure rpm builds
2022-01-14 17:50:39 +00:00
Switch to --package-metadata Use a compiler specs file to avoid issues with escaping and quoting when a package is built using autotools. Generate the osCpe string at build time for now, as it's not set as an env var by rpm yet.
2022-08-04 23:36:28 +00:00
# Passing linker flags inline via -Xlinker causes autotools failures, as libtool eats the escaped quotes
#%_package_note_json %(%{_rpmconfigdir}/generate-rpm-note.sh %name %version %_arch)
#%_package_note_flags %[%_package_note_status?"%_package_note_json":""]
Reference in New Issue Copy Permalink