From 2f3d1e1f960e89481cc4088832b8f76a5fc6d376 Mon Sep 17 00:00:00 2001
From: Klaus Wenninger <klaus.wenninger@aon.at>
Date: Thu, 19 Aug 2021 17:02:16 +0200
Subject: [PATCH] Test: cts-fencing: check metadata from fence_dummy/watchdog

xml gotten via stonith_admin has actual metadata just embedded
and thus is always valid xml even if metadata itself isn't.
---
 cts/cts-fencing.in | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/cts/cts-fencing.in b/cts/cts-fencing.in
index 942e607..0bedd9a 100644
--- a/cts/cts-fencing.in
+++ b/cts/cts-fencing.in
@@ -1442,6 +1442,18 @@ class Tests(object):
                              "Run stonith_admin --metadata for the fence_dummy agent", 1)
         test.add_cmd_check_stdout("stonith_admin", "--output-as=xml -a fence_dummy --metadata", '<shortdesc lang')
 
+    def build_metadata_tests(self):
+        """ run fence-agents coming with pacemaker with -o metadata and check for valid xml """
+
+        test = self.new_test("check_metadata_dummy",
+                             "Run fence_dummy -o metadata and check for valid xml", 0)
+        test.add_cmd("fence_dummy", "-o metadata", check_rng=False, check_stderr=False)
+        # fence_dummy prints on stderr to check that tools just listen on stdout
+
+        test = self.new_test("check_metadata_watchdog",
+                             "Run fence_watchdog -o metadata and check for valid xml", 0)
+        test.add_cmd("fence_watchdog", "-o metadata", check_rng=False)
+
     def setup_environment(self, use_corosync):
         """ Prepare the host before executing any tests """
 
@@ -1571,6 +1583,7 @@ def main(argv):
         tests.build_nodeid_tests()
         tests.build_remap_tests()
         tests.build_query_tests()
+        tests.build_metadata_tests()
 
         if opts.options['list-tests']:
             tests.print_list()
-- 
1.8.3.1