Rebase on upstream 2.1.6-rc2 release
- Resolves: rhbz2182482
This commit is contained in:
parent
b8d83ff74b
commit
68e9365af0
File diff suppressed because it is too large
Load Diff
@ -1,98 +0,0 @@
|
||||
From d8e08729ad5e3dc62f774172f992210902fc0ed4 Mon Sep 17 00:00:00 2001
|
||||
From: Ken Gaillot <kgaillot@redhat.com>
|
||||
Date: Mon, 23 Jan 2023 14:25:56 -0600
|
||||
Subject: [PATCH] High: executor: fix regression in remote node shutdown
|
||||
|
||||
This reverts the essential part of d61494347, which was based on misdiagnosing
|
||||
a remote node shutdown issue. Initially, it was thought that a "TLS server
|
||||
session ended" log just after a remote node requested shutdown indicated that
|
||||
the proxy connection coincidentally dropped at that moment. It actually is the
|
||||
routine stopping of accepting new proxy connections, and existing when that
|
||||
happens makes the remote node exit immediately without waiting for the
|
||||
all-clear from the cluster.
|
||||
|
||||
Fixes T361
|
||||
---
|
||||
daemons/execd/pacemaker-execd.c | 19 +------------------
|
||||
daemons/execd/pacemaker-execd.h | 3 +--
|
||||
daemons/execd/remoted_tls.c | 6 +-----
|
||||
3 files changed, 3 insertions(+), 25 deletions(-)
|
||||
|
||||
diff --git a/daemons/execd/pacemaker-execd.c b/daemons/execd/pacemaker-execd.c
|
||||
index db12674f13..491808974a 100644
|
||||
--- a/daemons/execd/pacemaker-execd.c
|
||||
+++ b/daemons/execd/pacemaker-execd.c
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2012-2022 the Pacemaker project contributors
|
||||
+ * Copyright 2012-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -305,23 +305,6 @@ lrmd_exit(gpointer data)
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
-/*!
|
||||
- * \internal
|
||||
- * \brief Clean up and exit if shutdown has started
|
||||
- *
|
||||
- * \return Doesn't return
|
||||
- */
|
||||
-void
|
||||
-execd_exit_if_shutting_down(void)
|
||||
-{
|
||||
-#ifdef PCMK__COMPILE_REMOTE
|
||||
- if (shutting_down) {
|
||||
- crm_warn("exit because TLS connection was closed and 'shutting_down' set");
|
||||
- lrmd_exit(NULL);
|
||||
- }
|
||||
-#endif
|
||||
-}
|
||||
-
|
||||
/*!
|
||||
* \internal
|
||||
* \brief Request cluster shutdown if appropriate, otherwise exit immediately
|
||||
diff --git a/daemons/execd/pacemaker-execd.h b/daemons/execd/pacemaker-execd.h
|
||||
index 6646ae29e3..f78e8dcdde 100644
|
||||
--- a/daemons/execd/pacemaker-execd.h
|
||||
+++ b/daemons/execd/pacemaker-execd.h
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2012-2022 the Pacemaker project contributors
|
||||
+ * Copyright 2012-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -105,6 +105,5 @@ void remoted_spawn_pidone(int argc, char **argv, char **envp);
|
||||
int process_lrmd_alert_exec(pcmk__client_t *client, uint32_t id,
|
||||
xmlNode *request);
|
||||
void lrmd_drain_alerts(GMainLoop *mloop);
|
||||
-void execd_exit_if_shutting_down(void);
|
||||
|
||||
#endif // PACEMAKER_EXECD__H
|
||||
diff --git a/daemons/execd/remoted_tls.c b/daemons/execd/remoted_tls.c
|
||||
index 6f4b2d0062..c65e3f394d 100644
|
||||
--- a/daemons/execd/remoted_tls.c
|
||||
+++ b/daemons/execd/remoted_tls.c
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2012-2022 the Pacemaker project contributors
|
||||
+ * Copyright 2012-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -250,10 +250,6 @@ static void
|
||||
tls_server_dropped(gpointer user_data)
|
||||
{
|
||||
crm_notice("TLS server session ended");
|
||||
- /* If we are in the process of shutting down, then we should actually exit.
|
||||
- * bz#1804259
|
||||
- */
|
||||
- execd_exit_if_shutting_down();
|
||||
return;
|
||||
}
|
||||
|
||||
--
|
||||
2.31.1
|
||||
|
File diff suppressed because it is too large
Load Diff
@ -1,107 +0,0 @@
|
||||
From 45617b727e280cac384a28ae3d96145e066e6197 Mon Sep 17 00:00:00 2001
|
||||
From: Reid Wahl <nrwahl@protonmail.com>
|
||||
Date: Fri, 3 Feb 2023 12:08:57 -0800
|
||||
Subject: [PATCH 01/02] Fix: fencer: Prevent double g_source_remove of op_timer_one
|
||||
|
||||
QE observed a rarely reproducible core dump in the fencer during
|
||||
Pacemaker shutdown, in which we try to g_source_remove() an op timer
|
||||
that's already been removed.
|
||||
|
||||
free_stonith_remote_op_list()
|
||||
-> g_hash_table_destroy()
|
||||
-> g_hash_table_remove_all_nodes()
|
||||
-> clear_remote_op_timers()
|
||||
-> g_source_remove()
|
||||
-> crm_glib_handler()
|
||||
-> "Source ID 190 was not found when attempting to remove it"
|
||||
|
||||
The likely cause is that request_peer_fencing() doesn't set
|
||||
op->op_timer_one to 0 after calling g_source_remove() on it, so if that
|
||||
op is still in the stonith_remote_op_list at shutdown with the same
|
||||
timer, clear_remote_op_timers() tries to remove the source for
|
||||
op_timer_one again.
|
||||
|
||||
There are only five locations that call g_source_remove() on a
|
||||
remote_fencing_op_t timer.
|
||||
* Three of them are in clear_remote_op_timers(), which first 0-checks
|
||||
the timer and then sets it to 0 after g_source_remove().
|
||||
* One is in remote_op_query_timeout(), which does the same.
|
||||
* The last is the one we fix here in request_peer_fencing().
|
||||
|
||||
I don't know all the conditions of QE's test scenario at this point.
|
||||
What I do know:
|
||||
* have-watchdog=true
|
||||
* stonith-watchdog-timeout=10
|
||||
* no explicit topology
|
||||
* fence agent script is missing for the configured fence device
|
||||
* requested fencing of one node
|
||||
* cluster shutdown
|
||||
|
||||
Fixes RHBZ2166967
|
||||
|
||||
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
|
||||
---
|
||||
daemons/fenced/fenced_remote.c | 1 +
|
||||
1 file changed, 1 insertion(+)
|
||||
|
||||
diff --git a/daemons/fenced/fenced_remote.c b/daemons/fenced/fenced_remote.c
|
||||
index d61b5bd..b7426ff 100644
|
||||
--- a/daemons/fenced/fenced_remote.c
|
||||
+++ b/daemons/fenced/fenced_remote.c
|
||||
@@ -1825,6 +1825,7 @@ request_peer_fencing(remote_fencing_op_t *op, peer_device_info_t *peer)
|
||||
op->state = st_exec;
|
||||
if (op->op_timer_one) {
|
||||
g_source_remove(op->op_timer_one);
|
||||
+ op->op_timer_one = 0;
|
||||
}
|
||||
|
||||
if (!((stonith_watchdog_timeout_ms > 0)
|
||||
--
|
||||
2.31.1
|
||||
|
||||
From 0291db4750322ec7f01ae6a4a2a30abca9d8e19e Mon Sep 17 00:00:00 2001
|
||||
From: Reid Wahl <nrwahl@protonmail.com>
|
||||
Date: Wed, 15 Feb 2023 22:30:27 -0800
|
||||
Subject: [PATCH 02/02] Fix: fencer: Avoid double source remove of op_timer_total
|
||||
|
||||
remote_op_timeout() returns G_SOURCE_REMOVE, which tells GLib to remove
|
||||
the source from the main loop after returning. Currently this function
|
||||
is used as the callback only when creating op->op_timer_total.
|
||||
|
||||
If we don't set op->op_timer_total to 0 before returning from
|
||||
remote_op_timeout(), then we can get an assertion and core dump from
|
||||
GLib when the op's timers are being cleared (either during op
|
||||
finalization or during fencer shutdown). This is because
|
||||
clear_remote_op_timers() sees that op->op_timer_total != 0 and tries to
|
||||
remove the source, but the source has already been removed.
|
||||
|
||||
Note that we're already (correctly) zeroing op->op_timer_one and
|
||||
op->query_timeout as appropriate in their respective callback functions.
|
||||
|
||||
Fortunately, GLib doesn't care whether the source has already been
|
||||
removed before we return G_SOURCE_REMOVE from a callback. So it's safe
|
||||
to call finalize_op() (which removes all the op's timer sources) from
|
||||
within a callback.
|
||||
|
||||
Fixes RHBZ#2166967
|
||||
|
||||
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
|
||||
---
|
||||
daemons/fenced/fenced_remote.c | 2 ++
|
||||
1 file changed, 2 insertions(+)
|
||||
|
||||
diff --git a/daemons/fenced/fenced_remote.c b/daemons/fenced/fenced_remote.c
|
||||
index b7426ff88..adea3d7d8 100644
|
||||
--- a/daemons/fenced/fenced_remote.c
|
||||
+++ b/daemons/fenced/fenced_remote.c
|
||||
@@ -718,6 +718,8 @@ remote_op_timeout(gpointer userdata)
|
||||
{
|
||||
remote_fencing_op_t *op = userdata;
|
||||
|
||||
+ op->op_timer_total = 0;
|
||||
+
|
||||
if (op->state == st_done) {
|
||||
crm_debug("Action '%s' targeting %s for client %s already completed "
|
||||
CRM_XS " id=%.8s",
|
||||
--
|
||||
2.39.0
|
@ -1,151 +0,0 @@
|
||||
From 0d15568a538349ac41028db6b506d13dd23e8732 Mon Sep 17 00:00:00 2001
|
||||
From: Chris Lumens <clumens@redhat.com>
|
||||
Date: Tue, 14 Feb 2023 14:00:37 -0500
|
||||
Subject: [PATCH] High: libcrmcommon: Fix handling node=NULL in
|
||||
pcmk__attrd_api_query.
|
||||
|
||||
According to the header file, if node is NULL, pcmk__attrd_api_query
|
||||
should query the value of the given attribute on all cluster nodes.
|
||||
This is also what the server expects and how attrd_updater is supposed
|
||||
to work.
|
||||
|
||||
However, pcmk__attrd_api_query has no way of letting callers decide
|
||||
whether they want to query all nodes or whether they want to use the
|
||||
local node. We were passing NULL for the node name, which it took to
|
||||
mean it should look up the local node name. This calls
|
||||
pcmk__node_attr_target, which probes the local cluster name and returns
|
||||
that to pcmk__attrd_api_query. If it returns non-NULL, that value will
|
||||
then be put into the XML IPC call which means the server will only
|
||||
return the value for that node.
|
||||
|
||||
In testing this was usually fine. However, in pratice, the methods
|
||||
pcmk__node_attr_target uses to figure out the local cluster node name
|
||||
involves checking the OCF_RESKEY_CRM_meta_on_node environment variable
|
||||
among others.
|
||||
|
||||
This variable was never set in testing, but can be set in the real
|
||||
world. This leads to circumstances where the user did "attrd_updater -QA"
|
||||
expecting to get the values on all nodes, but instead only got the value
|
||||
on the local cluster node.
|
||||
|
||||
In pacemaker-2.1.4 and prior, pcmk__node_attr_target was simply never
|
||||
called if the node was NULL but was called otherwise.
|
||||
|
||||
The fix is to modify pcmk__attrd_api_query to take an option for
|
||||
querying all nodes. If that's present, we'll query all nodes. If it's
|
||||
not present, we'll look at the given node name - NULL means look it up,
|
||||
anything else means just that node.
|
||||
|
||||
Regression in 2.1.5 introduced by eb20a65577
|
||||
---
|
||||
include/crm/common/attrd_internal.h | 6 +++++-
|
||||
include/crm/common/ipc_attrd_internal.h | 7 +++++--
|
||||
lib/common/ipc_attrd.c | 12 ++++++++----
|
||||
tools/attrd_updater.c | 5 +++--
|
||||
4 files changed, 21 insertions(+), 9 deletions(-)
|
||||
|
||||
diff --git a/include/crm/common/attrd_internal.h b/include/crm/common/attrd_internal.h
|
||||
index 389be48..7337c38 100644
|
||||
--- a/include/crm/common/attrd_internal.h
|
||||
+++ b/include/crm/common/attrd_internal.h
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2004-2022 the Pacemaker project contributors
|
||||
+ * Copyright 2004-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -25,6 +25,10 @@ enum pcmk__node_attr_opts {
|
||||
pcmk__node_attr_perm = (1 << 5),
|
||||
pcmk__node_attr_sync_local = (1 << 6),
|
||||
pcmk__node_attr_sync_cluster = (1 << 7),
|
||||
+ // pcmk__node_attr_utilization is 8, but that has not been backported.
|
||||
+ // I'm leaving the gap here in case we backport that in the future and
|
||||
+ // also to avoid problems on mixed-version clusters.
|
||||
+ pcmk__node_attr_query_all = (1 << 9),
|
||||
};
|
||||
|
||||
#define pcmk__set_node_attr_flags(node_attr_flags, flags_to_set) do { \
|
||||
diff --git a/include/crm/common/ipc_attrd_internal.h b/include/crm/common/ipc_attrd_internal.h
|
||||
index 2c6713f..b1b7584 100644
|
||||
--- a/include/crm/common/ipc_attrd_internal.h
|
||||
+++ b/include/crm/common/ipc_attrd_internal.h
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2022 the Pacemaker project contributors
|
||||
+ * Copyright 2022-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -110,10 +110,13 @@ int pcmk__attrd_api_purge(pcmk_ipc_api_t *api, const char *node);
|
||||
*
|
||||
* \param[in,out] api Connection to pacemaker-attrd
|
||||
* \param[in] node Look up the attribute for this node
|
||||
- * (or NULL for all nodes)
|
||||
+ * (or NULL for the local node)
|
||||
* \param[in] name Attribute name
|
||||
* \param[in] options Bitmask of pcmk__node_attr_opts
|
||||
*
|
||||
+ * \note Passing pcmk__node_attr_query_all will cause the function to query
|
||||
+ * the value of \p name on all nodes, regardless of the value of \p node.
|
||||
+ *
|
||||
* \return Standard Pacemaker return code
|
||||
*/
|
||||
int pcmk__attrd_api_query(pcmk_ipc_api_t *api, const char *node, const char *name,
|
||||
diff --git a/lib/common/ipc_attrd.c b/lib/common/ipc_attrd.c
|
||||
index 4606509..dece49b 100644
|
||||
--- a/lib/common/ipc_attrd.c
|
||||
+++ b/lib/common/ipc_attrd.c
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2011-2022 the Pacemaker project contributors
|
||||
+ * Copyright 2011-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -332,10 +332,14 @@ pcmk__attrd_api_query(pcmk_ipc_api_t *api, const char *node, const char *name,
|
||||
return EINVAL;
|
||||
}
|
||||
|
||||
- target = pcmk__node_attr_target(node);
|
||||
+ if (pcmk_is_set(options, pcmk__node_attr_query_all)) {
|
||||
+ node = NULL;
|
||||
+ } else {
|
||||
+ target = pcmk__node_attr_target(node);
|
||||
|
||||
- if (target != NULL) {
|
||||
- node = target;
|
||||
+ if (target != NULL) {
|
||||
+ node = target;
|
||||
+ }
|
||||
}
|
||||
|
||||
request = create_attrd_op(NULL);
|
||||
diff --git a/tools/attrd_updater.c b/tools/attrd_updater.c
|
||||
index 3cd766d..cbd341d 100644
|
||||
--- a/tools/attrd_updater.c
|
||||
+++ b/tools/attrd_updater.c
|
||||
@@ -376,6 +376,7 @@ attrd_event_cb(pcmk_ipc_api_t *attrd_api, enum pcmk_ipc_event event_type,
|
||||
static int
|
||||
send_attrd_query(pcmk__output_t *out, const char *attr_name, const char *attr_node, gboolean query_all)
|
||||
{
|
||||
+ uint32_t options = pcmk__node_attr_none;
|
||||
pcmk_ipc_api_t *attrd_api = NULL;
|
||||
int rc = pcmk_rc_ok;
|
||||
|
||||
@@ -400,10 +401,10 @@ send_attrd_query(pcmk__output_t *out, const char *attr_name, const char *attr_no
|
||||
|
||||
/* Decide which node(s) to query */
|
||||
if (query_all == TRUE) {
|
||||
- attr_node = NULL;
|
||||
+ options |= pcmk__node_attr_query_all;
|
||||
}
|
||||
|
||||
- rc = pcmk__attrd_api_query(attrd_api, attr_node, attr_name, 0);
|
||||
+ rc = pcmk__attrd_api_query(attrd_api, attr_node, attr_name, options);
|
||||
|
||||
if (rc != pcmk_rc_ok) {
|
||||
g_set_error(&error, PCMK__RC_ERROR, rc, "Could not query value of %s: %s (%d)",
|
||||
--
|
||||
2.31.1
|
||||
|
@ -1,142 +0,0 @@
|
||||
From 17cc49e1564b0ae55cc8212d14c5c055f88040da Mon Sep 17 00:00:00 2001
|
||||
From: Klaus Wenninger <klaus.wenninger@aon.at>
|
||||
Date: Tue, 14 Feb 2023 15:35:37 +0100
|
||||
Subject: [PATCH] Fix: watchdog-fencing: terminate dangling timer before
|
||||
watchdog-waiting
|
||||
|
||||
---
|
||||
daemons/fenced/fenced_remote.c | 6 +++++-
|
||||
1 file changed, 5 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/daemons/fenced/fenced_remote.c b/daemons/fenced/fenced_remote.c
|
||||
index 5c3fe25e3..aab185adb 100644
|
||||
--- a/daemons/fenced/fenced_remote.c
|
||||
+++ b/daemons/fenced/fenced_remote.c
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
- * Copyright 2009-2022 the Pacemaker project contributors
|
||||
+ * Copyright 2009-2023 the Pacemaker project contributors
|
||||
*
|
||||
* The version control history for this file may have further details.
|
||||
*
|
||||
@@ -1702,6 +1702,10 @@ check_watchdog_fencing_and_wait(remote_fencing_op_t * op)
|
||||
"client %s " CRM_XS " id=%.8s",
|
||||
(stonith_watchdog_timeout_ms / 1000),
|
||||
op->target, op->action, op->client_name, op->id);
|
||||
+
|
||||
+ if (op->op_timer_one) {
|
||||
+ g_source_remove(op->op_timer_one);
|
||||
+ }
|
||||
op->op_timer_one = g_timeout_add(stonith_watchdog_timeout_ms,
|
||||
remote_op_watchdog_done, op);
|
||||
return TRUE;
|
||||
--
|
||||
2.39.0
|
||||
|
||||
From f2cc2a4277124230903a18713e50604a8f1842cd Mon Sep 17 00:00:00 2001
|
||||
From: Klaus Wenninger <klaus.wenninger@aon.at>
|
||||
Date: Wed, 1 Mar 2023 15:00:15 +0100
|
||||
Subject: [PATCH] Refactor: watchdog-fencing: convenience function
|
||||
pcmk__is_fencing_action
|
||||
|
||||
for consistency and add comment making clear why this block exits
|
||||
with new timer set in any case
|
||||
---
|
||||
daemons/fenced/fenced_remote.c | 5 ++++-
|
||||
1 file changed, 4 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/daemons/fenced/fenced_remote.c b/daemons/fenced/fenced_remote.c
|
||||
index aab185adb..e0f8de057 100644
|
||||
--- a/daemons/fenced/fenced_remote.c
|
||||
+++ b/daemons/fenced/fenced_remote.c
|
||||
@@ -1834,7 +1834,7 @@ request_peer_fencing(remote_fencing_op_t *op, peer_device_info_t *peer)
|
||||
if (!((stonith_watchdog_timeout_ms > 0)
|
||||
&& (pcmk__str_eq(device, STONITH_WATCHDOG_ID, pcmk__str_none)
|
||||
|| (pcmk__str_eq(peer->host, op->target, pcmk__str_casei)
|
||||
- && !pcmk__str_eq(op->action, "on", pcmk__str_none)))
|
||||
+ && pcmk__is_fencing_action(op->action)))
|
||||
&& check_watchdog_fencing_and_wait(op))) {
|
||||
|
||||
/* Some thoughts about self-fencing cases reaching this point:
|
||||
@@ -1854,6 +1854,9 @@ request_peer_fencing(remote_fencing_op_t *op, peer_device_info_t *peer)
|
||||
Otherwise the selection of stonith-watchdog-timeout at
|
||||
least is questionable.
|
||||
*/
|
||||
+
|
||||
+ /* coming here we're not waiting for watchdog timeout -
|
||||
+ thus engage timer with timout evaluated before */
|
||||
op->op_timer_one = g_timeout_add((1000 * timeout_one), remote_op_timeout_one, op);
|
||||
}
|
||||
|
||||
--
|
||||
2.39.0
|
||||
|
||||
From c4eb45a986f8865fc5e69350fd5b9f4b056d9d69 Mon Sep 17 00:00:00 2001
|
||||
From: Klaus Wenninger <klaus.wenninger@aon.at>
|
||||
Date: Tue, 14 Feb 2023 11:57:17 +0100
|
||||
Subject: [PATCH] Fix: watchdog-fencing: correctly derive timeout with topology
|
||||
|
||||
up to now the timeout for watchdog-fencing was just added to
|
||||
the overall timeout if the node to be fenced was visible and
|
||||
reported back to the query.
|
||||
---
|
||||
daemons/fenced/fenced_remote.c | 28 +++++++++++++++++++++++++---
|
||||
1 file changed, 25 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/daemons/fenced/fenced_remote.c b/daemons/fenced/fenced_remote.c
|
||||
index e0f8de057..3b7ab05e9 100644
|
||||
--- a/daemons/fenced/fenced_remote.c
|
||||
+++ b/daemons/fenced/fenced_remote.c
|
||||
@@ -969,8 +969,9 @@ advance_topology_level(remote_fencing_op_t *op, bool empty_ok)
|
||||
return pcmk_rc_ok;
|
||||
}
|
||||
|
||||
- crm_info("All fencing options targeting %s for client %s@%s failed "
|
||||
+ crm_info("All %sfencing options targeting %s for client %s@%s failed "
|
||||
CRM_XS " id=%.8s",
|
||||
+ (stonith_watchdog_timeout_ms > 0)?"non-watchdog ":"",
|
||||
op->target, op->client_name, op->originator, op->id);
|
||||
return ENODEV;
|
||||
}
|
||||
@@ -1434,8 +1435,17 @@ stonith_choose_peer(remote_fencing_op_t * op)
|
||||
&& pcmk_is_set(op->call_options, st_opt_topology)
|
||||
&& (advance_topology_level(op, false) == pcmk_rc_ok));
|
||||
|
||||
- crm_notice("Couldn't find anyone to fence (%s) %s using %s",
|
||||
- op->action, op->target, (device? device : "any device"));
|
||||
+ if ((stonith_watchdog_timeout_ms > 0)
|
||||
+ && pcmk__is_fencing_action(op->action)
|
||||
+ && pcmk__str_eq(device, STONITH_WATCHDOG_ID, pcmk__str_none)
|
||||
+ && node_does_watchdog_fencing(op->target)) {
|
||||
+ crm_info("Couldn't contact watchdog-fencing target-node (%s)",
|
||||
+ op->target);
|
||||
+ /* check_watchdog_fencing_and_wait will log additional info */
|
||||
+ } else {
|
||||
+ crm_notice("Couldn't find anyone to fence (%s) %s using %s",
|
||||
+ op->action, op->target, (device? device : "any device"));
|
||||
+ }
|
||||
return NULL;
|
||||
}
|
||||
|
||||
@@ -1531,6 +1541,18 @@ get_op_total_timeout(const remote_fencing_op_t *op,
|
||||
continue;
|
||||
}
|
||||
for (device_list = tp->levels[i]; device_list; device_list = device_list->next) {
|
||||
+ /* in case of watchdog-device we add the timeout to the budget
|
||||
+ regardless of if we got a reply or not
|
||||
+ */
|
||||
+ if ((stonith_watchdog_timeout_ms > 0)
|
||||
+ && pcmk__is_fencing_action(op->action)
|
||||
+ && pcmk__str_eq(device_list->data, STONITH_WATCHDOG_ID,
|
||||
+ pcmk__str_none)
|
||||
+ && node_does_watchdog_fencing(op->target)) {
|
||||
+ total_timeout += stonith_watchdog_timeout_ms / 1000;
|
||||
+ continue;
|
||||
+ }
|
||||
+
|
||||
for (iter = op->query_results; iter != NULL; iter = iter->next) {
|
||||
const peer_device_info_t *peer = iter->data;
|
||||
|
||||
--
|
||||
2.39.0
|
||||
|
@ -35,11 +35,11 @@
|
||||
## Upstream pacemaker version, and its package version (specversion
|
||||
## can be incremented to build packages reliably considered "newer"
|
||||
## than previously built packages with the same pcmkversion)
|
||||
%global pcmkversion 2.1.5
|
||||
%global specversion 9
|
||||
%global pcmkversion 2.1.6
|
||||
%global specversion 1
|
||||
|
||||
## Upstream commit (full commit ID, abbreviated commit ID, or tag) to build
|
||||
%global commit a3f44794f94e1571c6ba0042915ade369b4ce4b1
|
||||
%global commit 802a72226be8f90747e9c897c626b060512d6fe6
|
||||
|
||||
## Since git v2.11, the extent of abbreviation is autoscaled by default
|
||||
## (used to be constant of 7), so we need to convey it for non-tags, too.
|
||||
@ -233,7 +233,7 @@ Name: pacemaker
|
||||
Summary: Scalable High-Availability cluster resource manager
|
||||
Version: %{pcmkversion}
|
||||
Release: %{pcmk_release}%{?dist}
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Url: https://www.clusterlabs.org/
|
||||
|
||||
# Example: https://codeload.github.com/ClusterLabs/pacemaker/tar.gz/e91769e
|
||||
@ -248,17 +248,15 @@ Source0: https://codeload.github.com/%{github_owner}/%{name}/tar.gz/%{arch
|
||||
Source1: https://codeload.github.com/%{github_owner}/%{nagios_name}/tar.gz/%{nagios_archive_github_url}
|
||||
|
||||
# upstream commits
|
||||
Patch001: 001-sync-points.patch
|
||||
Patch002: 002-remote-regression.patch
|
||||
Patch003: 003-history-cleanup.patch
|
||||
Patch004: 004-g_source_remove.patch
|
||||
Patch005: 005-query-null.patch
|
||||
Patch006: 006-watchdog-fencing-topology.patch
|
||||
#Patch001: 001-xxxx.patch
|
||||
|
||||
Requires: resource-agents
|
||||
Requires: %{pkgname_pcmk_libs}%{?_isa} = %{version}-%{release}
|
||||
Requires: %{name}-cluster-libs%{?_isa} = %{version}-%{release}
|
||||
Requires: %{name}-cli = %{version}-%{release}
|
||||
%if %{with stonithd}
|
||||
Requires: %{python_name}-%{name} = %{version}-%{release}
|
||||
%endif
|
||||
%{?systemd_requires}
|
||||
|
||||
%if %{defined centos}
|
||||
@ -271,6 +269,7 @@ ExclusiveArch: aarch64 i686 ppc64le s390x x86_64
|
||||
|
||||
Requires: %{python_path}
|
||||
BuildRequires: %{python_name}-devel
|
||||
BuildRequires: %{python_name}-setuptools
|
||||
|
||||
# Pacemaker requires a minimum libqb functionality
|
||||
# RHEL requires a higher version than upstream, for qb_ipcc_connect_async()
|
||||
@ -360,7 +359,7 @@ Available rpmbuild rebuild options:
|
||||
stonithd
|
||||
|
||||
%package cli
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Summary: Command line tools for controlling Pacemaker clusters
|
||||
Requires: %{pkgname_pcmk_libs}%{?_isa} = %{version}-%{release}
|
||||
%if 0%{?supports_recommends}
|
||||
@ -383,7 +382,7 @@ to query and control the cluster from machines that may, or may not,
|
||||
be part of the cluster.
|
||||
|
||||
%package -n %{pkgname_pcmk_libs}
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Summary: Core Pacemaker libraries
|
||||
Requires(pre): %{pkgname_shadow_utils}
|
||||
Requires: %{name}-schemas = %{version}-%{release}
|
||||
@ -400,7 +399,7 @@ The %{pkgname_pcmk_libs} package contains shared libraries needed for cluster
|
||||
nodes and those just running the CLI tools.
|
||||
|
||||
%package cluster-libs
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Summary: Cluster Libraries used by Pacemaker
|
||||
Requires: %{pkgname_pcmk_libs}%{?_isa} = %{version}-%{release}
|
||||
|
||||
@ -411,8 +410,22 @@ manager.
|
||||
The %{name}-cluster-libs package contains cluster-aware shared
|
||||
libraries needed for nodes that will form part of the cluster nodes.
|
||||
|
||||
%package -n %{python_name}-%{name}
|
||||
License: LGPL-2.1-or-later
|
||||
Summary: Python libraries for Pacemaker
|
||||
Requires: %{python_path}
|
||||
Requires: %{pkgname_pcmk_libs} = %{version}-%{release}
|
||||
BuildArch: noarch
|
||||
|
||||
%description -n %{python_name}-%{name}
|
||||
Pacemaker is an advanced, scalable High-Availability cluster resource
|
||||
manager.
|
||||
|
||||
The %{python_name}-%{name} package contains a Python library that can be used
|
||||
to interface with Pacemaker.
|
||||
|
||||
%package remote
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Summary: Pacemaker remote executor daemon for non-cluster nodes
|
||||
Requires: %{pkgname_pcmk_libs}%{?_isa} = %{version}-%{release}
|
||||
Requires: %{name}-cli = %{version}-%{release}
|
||||
@ -431,7 +444,7 @@ which is capable of extending pacemaker functionality to remote
|
||||
nodes not running the full corosync/cluster stack.
|
||||
|
||||
%package -n %{pkgname_pcmk_libs}-devel
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Summary: Pacemaker development package
|
||||
Requires: %{pkgname_pcmk_libs}%{?_isa} = %{version}-%{release}
|
||||
Requires: %{name}-cluster-libs%{?_isa} = %{version}-%{release}
|
||||
@ -454,11 +467,12 @@ The %{pkgname_pcmk_libs}-devel package contains headers and shared libraries
|
||||
for developing tools for Pacemaker.
|
||||
|
||||
%package cts
|
||||
License: GPLv2+ and LGPLv2+
|
||||
License: GPL-2.0-or-later AND LGPL-2.1-or-later
|
||||
Summary: Test framework for cluster-related technologies like Pacemaker
|
||||
Requires: %{python_path}
|
||||
Requires: %{pkgname_pcmk_libs} = %{version}-%{release}
|
||||
Requires: %{name}-cli = %{version}-%{release}
|
||||
Requires: %{python_name}-%{name} = %{version}-%{release}
|
||||
Requires: %{pkgname_procps}
|
||||
Requires: psmisc
|
||||
Requires: %{python_name}-psutil
|
||||
@ -486,7 +500,7 @@ Pacemaker is an advanced, scalable High-Availability cluster resource
|
||||
manager.
|
||||
|
||||
%package schemas
|
||||
License: GPLv2+
|
||||
License: GPL-2.0-or-later
|
||||
Summary: Schemas and upgrade stylesheets for Pacemaker
|
||||
BuildArch: noarch
|
||||
|
||||
@ -558,6 +572,10 @@ export LDFLAGS_HARDENED_LIB="%{?_hardening_ldflags}"
|
||||
|
||||
make %{_smp_mflags} V=1
|
||||
|
||||
pushd python
|
||||
%py3_build
|
||||
popd
|
||||
|
||||
%check
|
||||
make %{_smp_mflags} check
|
||||
{ cts/cts-scheduler --run load-stopped-loop \
|
||||
@ -575,6 +593,10 @@ make install \
|
||||
DESTDIR=%{buildroot} V=1 docdir=%{pcmk_docdir} \
|
||||
%{?_python_bytecompile_extra:%{?py_byte_compile:am__py_compile=true}}
|
||||
|
||||
pushd python
|
||||
%py3_install
|
||||
popd
|
||||
|
||||
mkdir -p %{buildroot}%{_datadir}/pacemaker/nagios/plugins-metadata
|
||||
for file in $(find %{nagios_name}-%{nagios_hash}/metadata -type f); do
|
||||
install -m 644 $file %{buildroot}%{_datadir}/pacemaker/nagios/plugins-metadata
|
||||
@ -759,19 +781,22 @@ exit 0
|
||||
%dir %{ocf_root}/resource.d
|
||||
%{ocf_root}/resource.d/pacemaker
|
||||
|
||||
%doc %{_mandir}/man7/*
|
||||
%doc %{_mandir}/man7/*pacemaker*
|
||||
%exclude %{_mandir}/man7/pacemaker-controld.*
|
||||
%exclude %{_mandir}/man7/pacemaker-schedulerd.*
|
||||
%exclude %{_mandir}/man7/pacemaker-fenced.*
|
||||
%exclude %{_mandir}/man7/ocf_pacemaker_controld.*
|
||||
%exclude %{_mandir}/man7/ocf_pacemaker_o2cb.*
|
||||
%exclude %{_mandir}/man7/ocf_pacemaker_remote.*
|
||||
%doc %{_mandir}/man8/*
|
||||
%doc %{_mandir}/man8/crm*.8.gz
|
||||
%exclude %{_mandir}/man8/crm_master.*
|
||||
%exclude %{_mandir}/man8/fence_legacy.*
|
||||
%exclude %{_mandir}/man8/fence_watchdog.*
|
||||
%exclude %{_mandir}/man8/pacemakerd.*
|
||||
%exclude %{_mandir}/man8/pacemaker-remoted.*
|
||||
%doc %{_mandir}/man8/attrd_updater.*
|
||||
%doc %{_mandir}/man8/cibadmin.*
|
||||
%if %{with cibsecrets}
|
||||
%doc %{_mandir}/man8/cibsecret.*
|
||||
%endif
|
||||
%doc %{_mandir}/man8/iso8601.*
|
||||
%doc %{_mandir}/man8/stonith_admin.*
|
||||
|
||||
%license licenses/GPLv2
|
||||
%doc COPYING
|
||||
@ -802,6 +827,14 @@ exit 0
|
||||
%doc COPYING
|
||||
%doc ChangeLog
|
||||
|
||||
%files -n %{python_name}-%{name}
|
||||
%{python3_sitelib}/pacemaker/
|
||||
%{python3_sitelib}/pacemaker-*.egg-info
|
||||
%exclude %{python3_sitelib}/pacemaker/_cts/
|
||||
%license licenses/LGPLv2.1
|
||||
%doc COPYING
|
||||
%doc ChangeLog
|
||||
|
||||
%files remote
|
||||
%config(noreplace) %{_sysconfdir}/sysconfig/pacemaker
|
||||
# state directory is shared between the subpackets
|
||||
@ -823,6 +856,7 @@ exit 0
|
||||
|
||||
%files cts
|
||||
%{python_site}/cts
|
||||
%{python3_sitelib}/pacemaker/_cts/
|
||||
%{_datadir}/pacemaker/tests
|
||||
|
||||
%{_libexecdir}/pacemaker/cts-log-watcher
|
||||
@ -834,8 +868,16 @@ exit 0
|
||||
|
||||
%files -n %{pkgname_pcmk_libs}-devel
|
||||
%{_includedir}/pacemaker
|
||||
%{_libdir}/*.so
|
||||
%{_libdir}/pkgconfig/*.pc
|
||||
%{_libdir}/libcib.so
|
||||
%{_libdir}/liblrmd.so
|
||||
%{_libdir}/libcrmservice.so
|
||||
%{_libdir}/libcrmcommon.so
|
||||
%{_libdir}/libpe_status.so
|
||||
%{_libdir}/libpe_rules.so
|
||||
%{_libdir}/libpacemaker.so
|
||||
%{_libdir}/libstonithd.so
|
||||
%{_libdir}/libcrmcluster.so
|
||||
%{_libdir}/pkgconfig/*pacemaker*.pc
|
||||
%license licenses/LGPLv2.1
|
||||
%doc COPYING
|
||||
%doc ChangeLog
|
||||
@ -856,6 +898,10 @@ exit 0
|
||||
%license %{nagios_name}-%{nagios_hash}/COPYING
|
||||
|
||||
%changelog
|
||||
* Tue May 23 2023 Chris Lumens <clumens@redhat.com> - 2.1.6-1
|
||||
- Rebase on upstream 2.1.6-rc2 release
|
||||
- Resolves: rhbz2182482
|
||||
|
||||
* Wed May 17 2023 Klaus Wenninger <kwenning@redhat.com> - 2.1.5-9
|
||||
- Rebuild with incremented release to allow a safe upgrade from
|
||||
c8s/rhel-8
|
||||
|
2
sources
2
sources
@ -1,2 +1,2 @@
|
||||
SHA512 (nagios-agents-metadata-105ab8a7b2c16b9a29cf1c1596b80136eeef332b.tar.gz) = 11ddeb48a4929e7642b6dfa9c7962aa1d7a1af1c569830f55ed6cd6773abac13377317327bc1db8411c8077884f83f81cc54d746c834b63a99fa6dc219b5caad
|
||||
SHA512 (pacemaker-a3f44794f.tar.gz) = 554f4c47fcf2f5be61afe9b1485a6bb19de1bdfc0ec8d9be44eba31d77d0df1c6f07b29590299c4664e676a5c90e9c5fdb8a84921665151211df92d8f549dbc9
|
||||
SHA512 (pacemaker-802a72226.tar.gz) = fa4259c1f44de38ced1488fa827441ad101f4760e7cb1962c94610a9a3ed5a5a8227cd307636525a14396311ce3c5ae13919a8111f734a1a59905f99f79081e4
|
||||
|
Loading…
Reference in New Issue
Block a user