From a9a4f482591b9f1baa0ad2c0d841069157f18ec1 Mon Sep 17 00:00:00 2001
From: Vitezslav Crhonek <vcrhonek@redhat.com>
Date: Tue, 28 Aug 2012 15:15:13 +0200
Subject: [PATCH] Fix issues found by fedora-review utility in the spec file

---
 openwsman.spec | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/openwsman.spec b/openwsman.spec
index 0355c73..7694600 100644
--- a/openwsman.spec
+++ b/openwsman.spec
@@ -15,7 +15,7 @@ BuildRequires:  perl-devel pkgconfig openssl-devel
 BuildRequires:  cmake
 BuildRequires:  systemd-units
 Version:        2.3.0
-Release:        6%{?dist}
+Release:        7%{?dist}
 Url:            http://www.openwsman.org/
 License:        BSD
 Group:          Applications/System
@@ -30,7 +30,6 @@ Source3:        owsmantestcert.sh
 Patch0:         %{name}-sitelibdir.patch
 Patch2:         openwsman-2.2.7-disable-ruby.patch
 Patch3:         openwsman-2.2.7-libssl.patch
-BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXXX)
 
 %description
 Openwsman is a project intended to provide an open-source
@@ -169,7 +168,6 @@ cmake \
 make CFLAGS="-DSSL_LIB='\"$SSL_LIB\"'"
 
 %install
-rm -rf %{buildroot}
 cd build
 make DESTDIR=%{buildroot} install
 cd ..
@@ -182,7 +180,7 @@ rm -f %{buildroot}/%{_libdir}/openwsman/authenticators/*.la
 mkdir -p %{buildroot}%{_sysconfdir}/init.d
 install -m 644 etc/openwsman.conf %{buildroot}/%{_sysconfdir}/openwsman
 install -m 644 etc/openwsman_client.conf %{buildroot}/%{_sysconfdir}/openwsman
-mkdir -p $RPM_BUILD_ROOT%{_unitdir}
+mkdir -p %{buildroot}/%{_unitdir}
 install -p -m 644 %{SOURCE2} %{buildroot}/%{_unitdir}/openwsmand.service
 install -m 644 etc/ssleay.cnf %{buildroot}/%{_sysconfdir}/openwsman
 install -p -m 755 %{SOURCE3} %{buildroot}/%{_sysconfdir}/openwsman
@@ -194,9 +192,6 @@ install -m 644 include/wsman-xml.h %{buildroot}/%{_includedir}/openwsman
 install -m 644 include/wsman-xml-binding.h %{buildroot}/%{_includedir}/openwsman
 install -m 644 include/wsman-dispatcher.h %{buildroot}/%{_includedir}/openwsman
 
-%clean
-rm -rf %{buildroot}
-
 %post -n libwsman1 -p /sbin/ldconfig
 
 %postun -n libwsman1 -p /sbin/ldconfig
@@ -218,21 +213,18 @@ rm -f /var/log/wsmand.log
 %postun client -p /sbin/ldconfig
 
 %files -n libwsman1
-%defattr(-,root,root,-)
 %doc AUTHORS COPYING ChangeLog README.md TODO
 %{_libdir}/libwsman.so.*
 %{_libdir}/libwsman_client.so.*
 %{_libdir}/libwsman_curl_client_transport.so.*
 
 %files -n libwsman-devel
-%defattr(-,root,root,-)
 %{_includedir}/*
 %{_libdir}/pkgconfig/*
 %{_libdir}/*.so
 %doc AUTHORS COPYING ChangeLog README.md
 
 %files python
-%defattr(-,root,root,-)
 %{python_sitearch}/*.so
 %{python_sitearch}/*.py
 %{python_sitearch}/*.pyc
@@ -240,7 +232,6 @@ rm -f /var/log/wsmand.log
 %doc AUTHORS COPYING ChangeLog README.md
 
 #%files ruby
-#%defattr(-,root,root,-)
 #%{ruby_sitearch}/openwsman.so
 #%{ruby_sitearch}/_openwsman.so
 #%dir %{ruby_sitelib}/openwsman
@@ -248,7 +239,6 @@ rm -f /var/log/wsmand.log
 #%doc AUTHORS COPYING ChangeLog README.md
 
 %files perl
-%defattr(-,root,root,-)
 %{perl_vendorarch}/openwsman.so
 %{perl_vendorlib}/openwsman.pm
 %doc AUTHORS COPYING ChangeLog README.md
@@ -256,7 +246,6 @@ rm -f /var/log/wsmand.log
 %files server
 # Don't remove *.so files from the server package.
 # the server fails to start without these files.
-%defattr(-,root,root,-)
 %dir %{_sysconfdir}/openwsman
 %config(noreplace) %{_sysconfdir}/openwsman/openwsman.conf
 %config(noreplace) %{_sysconfdir}/openwsman/ssleay.cnf
@@ -277,13 +266,15 @@ rm -f /var/log/wsmand.log
 %doc AUTHORS COPYING ChangeLog README.md
 
 %files client
-%defattr(-,root,root,-)
 %{_libdir}/libwsman_clientpp.so.*
 %config(noreplace) %{_sysconfdir}/openwsman/openwsman_client.conf
 %doc AUTHORS COPYING ChangeLog README.md
 
 
 %changelog
+* Tue Aug 28 2012 Vitezslav Crhonek <vcrhonek@redhat.com> - 2.3.0-7
+- Fix issues found by fedora-review utility in the spec file
+
 * Thu Aug 23 2012 Vitezslav Crhonek <vcrhonek@redhat.com> - 2.3.0-6
 - Use new systemd-rpm macros
   Resolves: #850405