commit 5240ab5f83f16cee96ae92cd5f701dd65e6c003c Author: Mahesh Salgaonkar Date: Fri Sep 19 22:49:45 2025 +0530 external/opal-prd: remove misleading errno error message While handling memory error opal-prd displays misleading errno error messages even when handler was successfully able to soft/hard offline the requested memory page. opal-prd[49096]: MEM: Memory error: range 0000000eeb445700-0000000eeb445700, type: correctable opal-prd[49096]: MEM: Offlined 0000000eeb445700,0000000eeb455700, type correctable: No such file or directory In above example, an error message 'No such file or directory' was displayed even after successfully offlining memory. This is because printf in success case was using '%m' which prints errno based error message. The value in errno is significant only when the return value of the call indicated an error. The value of errno is never set to zero by any system call or library function. Hence, in success case do not use '%m' in printf to avoid misleading error message Signed-off-by: Mahesh Salgaonkar Signed-off-by: Reza Arbab diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c index da947c827..d85e3e9bd 100644 --- a/external/opal-prd/opal-prd.c +++ b/external/opal-prd/opal-prd.c @@ -721,7 +721,7 @@ static int memory_error_worker(const char *sysfsfile, const char *type, ret = 1; } } - pr_log(LOG_CRIT, "MEM: Offlined %016lx,%016lx, type %s: %m\n", + pr_log(LOG_CRIT, "MEM: Offlined %016lx,%016lx, type %s\n", i_start_addr, addr, type); close(memfd);