From af538fcc1b931afb02aa6b2d961cbf960fad86d1 Mon Sep 17 00:00:00 2001 From: "T.C. Hollingsworth" Date: Wed, 9 Jan 2013 18:01:49 -0700 Subject: [PATCH] make v8 dependency explicit v8 breaks ABI while never bumping SONAME so we need to be strict about it --- nodejs.spec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/nodejs.spec b/nodejs.spec index f2c8177..599b88a 100644 --- a/nodejs.spec +++ b/nodejs.spec @@ -21,7 +21,12 @@ Source6: nodejs-fixdep # binaries with debugging symbols Patch0004: 0004-Build-debugging-symbols-by-default.patch -BuildRequires: v8-devel +# V8 presently breaks ABI at least every x.y release while never bumping SONAME, +# so we need to be more explicit until spot fixes that +%global v8_ge 3.13.7.5 +%global v8_lt 3.14 + +BuildRequires: v8-devel >= %{v8_ge} BuildRequires: http-parser-devel >= 2.0 BuildRequires: libuv-devel BuildRequires: c-ares-devel @@ -29,6 +34,9 @@ BuildRequires: zlib-devel # Node.js requires some features from openssl 1.0.1 for SPDY support BuildRequires: openssl-devel >= 1:1.0.1 +Requires: v8 >= %{v8_ge} +Requires: v8 < %{v8_lt} + #virtual provides for automatic depedency generation Provides: nodejs(engine) = %{version} @@ -161,6 +169,7 @@ cp -p common.gypi %{buildroot}%{_datadir}/node %changelog * Wed Jan 09 2013 T.C. Hollingsworth - 0.9.5-5 - add defines to match libuv (#892601) +- make v8 dependency explicit (and thus more accurate) * Sat Jan 05 2013 T.C. Hollingsworth - 0.9.5-4 - install development headers