From 1827854f11747f8754c871c44a257740dba503ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Stan=C4=9Bk?= <jstanek@redhat.com>
Date: Wed, 26 Apr 2023 15:30:44 +0200
Subject: [PATCH] Replace /usr/etc/npmrc symlink with builtin configuration

We want to have the system-level npmrc located at /etc/npmrc.
By default, npm looks for it in /usr/etc/npmrc,
so we placed a symlink to /etc/npmrc there.
However, we are the only known package that has anything in /usr/etc,
which confuses and/or breaks various tooling (see related bug).

This gets rid of the symlink,
and instead uses "builtin"-level configuration of npm
to cause it to load the system-level configuration from /etc/npmrc.

Related: rhbz#2177776
---
 nodejs20.spec    | 12 +++++-------
 npmrc.builtin.in |  5 +++++
 2 files changed, 10 insertions(+), 7 deletions(-)
 create mode 100644 npmrc.builtin.in

diff --git a/nodejs20.spec b/nodejs20.spec
index 4fcb7d3..70c2ae7 100644
--- a/nodejs20.spec
+++ b/nodejs20.spec
@@ -135,6 +135,7 @@ Source2: btest402.js
 Source3: https://github.com/unicode-org/icu/releases/download/release-%{icu_major}-%{icu_minor}/icu4c-%{icu_major}_%{icu_minor}-data-bin-b.zip
 Source4: https://github.com/unicode-org/icu/releases/download/release-%{icu_major}-%{icu_minor}/icu4c-%{icu_major}_%{icu_minor}-data-bin-l.zip
 Source200: nodejs-sources.sh
+Source201: npmrc.builtin.in
 Source202: nodejs.pc.in
 Source203: v8.pc.in
 
@@ -686,16 +687,14 @@ find %{buildroot}%{nodejs_private_sitelib}/npm \
 chmod 0755 %{buildroot}%{nodejs_private_sitelib}/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node-gyp
 chmod 0755 %{buildroot}%{nodejs_private_sitelib}/npm/node_modules/node-gyp/bin/node-gyp.js
 
+# Drop the NPM builtin configuration in place
+sed -e 's#@SYSCONFDIR@#%{_sysconfdir}#g' \
+    %{SOURCE201} > %{buildroot}%{nodejs_private_sitelib}/npm/npmrc
+
 # Drop the NPM default configuration in place
 %if 0%{?nodejs_default}
 mkdir -p %{buildroot}%{_sysconfdir}
 cp %{SOURCE1} %{buildroot}%{_sysconfdir}/npmrc
-
-# NPM upstream expects it to be in /usr/etc/npmrc, so we'll put a symlink here
-# This is done in the interests of keeping /usr read-only.
-mkdir -p %{buildroot}%{_prefix}/etc
-ln -rsf %{buildroot}%{_sysconfdir}/npmrc \
-        %{buildroot}%{_prefix}/etc/npmrc
 %endif
 
 # Install the full-icu data files
@@ -829,7 +828,6 @@ end
 %if 0%{?nodejs_default}
 %{_bindir}/npm
 %{_bindir}/npx
-%{_prefix}/etc/npmrc
 %config(noreplace) %{_sysconfdir}/npmrc
 %ghost %{_sysconfdir}/npmignore
 
diff --git a/npmrc.builtin.in b/npmrc.builtin.in
new file mode 100644
index 0000000..739a57d
--- /dev/null
+++ b/npmrc.builtin.in
@@ -0,0 +1,5 @@
+# This is the distibution-level configuration file for npm.
+# To configure NPM on a system level, use the globalconfig below (defaults to @SYSCONFDIR@/npmrc).
+# vim:set filetype=dosini:
+
+globalconfig=@SYSCONFDIR@/npmrc