Fix CVE-2026-42945 Buffer overrun in rewrite module via arguments in replacement strings (#10)

Reviewed-on: #10
Co-authored-by: Jonathan Wright <jonathan@almalinux.org>
Co-committed-by: Jonathan Wright <jonathan@almalinux.org>
This commit is contained in:
Jonathan Wright 2026-05-14 15:06:04 +00:00 committed by eabdullin
parent afe6004c88
commit 434d48fb83
2 changed files with 51 additions and 1 deletions

View File

@ -0,0 +1,42 @@
From 524977e7c534e87e5b55739fa74601c9f1102686 Mon Sep 17 00:00:00 2001
From: Roman Arutyunyan <arut@nginx.com>
Date: Wed, 22 Apr 2026 09:39:31 +0400
Subject: [PATCH] Rewrite: fixed escaping and possible buffer overrun
The following code resulted in incorrect escaping of $1 and possible
segfault:
location / {
rewrite ^(.*) /new?c=1;
set $myvar $1;
return 200 $myvar;
}
If there were arguments in a rewrite's replacement string, the is_args flag
was set and incorrectly never cleared. This resulted in escaping applied
to any captures evaluated afterwards in set or if. Additionally buffer was
allocated by ngx_http_script_complex_value_code() without escaping expected,
thus this also resulted in buffer overrun and possible segfault.
A similar issue was fixed in 74d939974d43.
Reported by Leo Lin.
---
src/http/ngx_http_script.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/http/ngx_http_script.c b/src/http/ngx_http_script.c
index a2b9f1b7bf..2ea6113735 100644
--- a/src/http/ngx_http_script.c
+++ b/src/http/ngx_http_script.c
@@ -1202,6 +1202,7 @@ ngx_http_script_regex_end_code(ngx_http_script_engine_t *e)
r = e->request;
+ e->is_args = 0;
e->quote = 0;
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
--
2.53.0

View File

@ -56,7 +56,7 @@
Name: nginx
Epoch: 1
Version: 1.22.1
Release: 8%{?dist}.1.alma.1
Release: 8%{?dist}.1.alma.2
Summary: A high performance web server and reverse proxy server
# BSD License (two clause)
@ -123,6 +123,10 @@ Patch9: 0011-Optimized-chain-link-usage.patch
# upstream patch - https://bugzilla.redhat.com/show_bug.cgi?id=2304966
Patch10: 0012-CVE-2024-7347-Buffer-overread-in-the-mp4-module.patch
# CVE-2026-42945
# upstream patch - https://github.com/nginx/nginx/commit/524977e7c534e87e5b55739fa74601c9f1102686
Patch11: 0013-Rewrite-fixed-escaping-and-possible-buffer-overrun.patch
BuildRequires: make
BuildRequires: gcc
BuildRequires: gnupg2
@ -635,6 +639,10 @@ fi
%changelog
* Thu May 14 2026 Jonathan Wright <jonathan@almalinux.org> - 1:1.22.1-8.1.alma.2
- Fix CVE-2026-42945 nginx: NGINX: Buffer overrun in rewrite module via
arguments in replacement strings
* Fri Mar 28 2025 Eduard Abdullin <eabdullin@almalinux.org> - 1:1.22.1-8.1.alma.1
- Debrand for AlmaLinux