63fbb66589
* Tue Jun 30 2026 Phil Sutter <psutter@redhat.com> [1.0.9-8.el9]
- parser_json: fix map/set type confusion crash in map statement parser (Phil Sutter) [RHEL-190549]
- parser_json: bail out on malformed statement in set (Phil Sutter) [RHEL-190549]
- parser_json: allow statement stateful statement only in set elements (Phil Sutter) [RHEL-190549]
- parser_json: fix crash in json_parse_set_stmt_list (Phil Sutter) [RHEL-190549]
- cache: honor -c/--check for reset commands (Phil Sutter) [RHEL-190549]
- mnl: Fix ordering of hooks in 'list hooks' output (Phil Sutter) [RHEL-190549]
- segtree: Fix for variable-sized object may not be initialized (Phil Sutter) [RHEL-190549]
- cache: Filter for table when listing flowtables (Phil Sutter) [RHEL-190549]
- cache: Filter for table when listing sets or maps (Phil Sutter) [RHEL-190549]
- cache: Relax chain_cache_dump filter application (Phil Sutter) [RHEL-190549]
- cache: Respect family in all list commands (Phil Sutter) [RHEL-190549]
- json: complete multi-statement set element support (Phil Sutter) [RHEL-190549]
- mergesort: Align concatenation sort order with Big Endian (Phil Sutter) [RHEL-190549]
- optimize: expand expression list when merging into concatenation (Phil Sutter) [RHEL-190549]
- mergesort: Fix sorting of string values (Phil Sutter) [RHEL-190549]
- segtree: Fix range aggregation on Big Endian (Phil Sutter) [RHEL-190549]
- monitor: fix memleak in setelem cb (Phil Sutter) [RHEL-190549]
- tests: json_echo: Drop rule handle before multi-add (Phil Sutter) [RHEL-190549]
- rule: skip CMD_OBJ_SETELEMS with no elements after set flush (Phil Sutter) [RHEL-190549]
- doc: libnftables-json: Describe RULESET object (Phil Sutter) [RHEL-190549]
- doc: don't suggest to disable GSO (Phil Sutter) [RHEL-190549]
- tests: py: inet/osf.t: Fix element ordering in JSON equivalents (Phil Sutter) [RHEL-190549]
- tests: py: any/ct.t.json.output: Drop leftover entry (Phil Sutter) [RHEL-190549]
- optimize: Fix verdict expression comparison (Phil Sutter) [RHEL-190549]
- datatype: Fix boolean type on Big Endian (Phil Sutter) [RHEL-190549]
- datatype: clamp boolean value to 0 and 1 (Phil Sutter) [RHEL-190549]
- src: parser_json: fix format string bugs (Phil Sutter) [RHEL-190549]
- doc: fix tcpdump example (Phil Sutter) [RHEL-190549]
- fib: Fix for existence check on Big Endian (Phil Sutter) [RHEL-190549]
- monitor: Inform JSON printer when reporting an object delete event (Phil Sutter) [RHEL-190549]
- tests: monitor: Fix regex collecting expected echo output (Phil Sutter) [RHEL-190549]
- monitor: Quote device names in chain declarations, too (Phil Sutter) [RHEL-190549]
- mnl: continue on ENOBUFS errors when processing batch (Phil Sutter) [RHEL-190549]
- mnl: silence compiler warning (Phil Sutter) [RHEL-190549]
- fib: restore JSON output for relational expressions (Phil Sutter) [RHEL-190549]
- json: Do not reduce single-item arrays on output (Phil Sutter) [RHEL-190549]
- src: ensure chain policy evaluation when specified (Phil Sutter) [RHEL-190549]
- segtree: incorrect type when aggregating concatenated set ranges (Phil Sutter) [RHEL-190549]
- tests: py: Fix tests added for 'icmpv6 taddr' support (Phil Sutter) [RHEL-190549]
- tests: py: Drop stale entry from ip/snat.t.payload (Phil Sutter) [RHEL-190549]
- tests: py: Drop stale entries from ip6/{ct,meta}.t.json (Phil Sutter) [RHEL-190549]
- tests: py: Drop stale entry from ip/snat.t.json (Phil Sutter) [RHEL-190549]
- tests: py: Drop duplicate test from inet/vxlan.t (Phil Sutter) [RHEL-190549]
- tests: py: Drop stale entry from inet/tcp.t.json (Phil Sutter) [RHEL-190549]
- tests: py: Drop duplicate test from inet/gretap.t (Phil Sutter) [RHEL-190549]
- tests: py: Drop duplicate test from inet/gre.t (Phil Sutter) [RHEL-190549]
- tests: py: Drop duplicate test from inet/geneve.t (Phil Sutter) [RHEL-190549]
- tests: py: Drop stale entries since redundant test case removal (Phil Sutter) [RHEL-190549]
- src: netlink: netlink_delinearize_table() may return NULL (Phil Sutter) [RHEL-190549]
- doc: nft.8: Minor NAT STATEMENTS section review (Phil Sutter) [RHEL-190549]
- mnl: Call mnl_attr_nest_end() just once (Phil Sutter) [RHEL-190549]
- evaluate: validate set expression type before accessing flags (Phil Sutter) [RHEL-190549]
- rule: print chain and flowtable devices in quotes (Phil Sutter) [RHEL-190549]
- tests: shell: skip if kernel does not support flowtable counter (Phil Sutter) [RHEL-190549]
- tests: shell: adjust add-after-delete flowtable for older kernels (Phil Sutter) [RHEL-190549]
- tests/shell: cover long interface name in "0042chain_variable_0" test (Phil Sutter) [RHEL-190549]
- tests: py: re-enables nft-test.py to load the local nftables.py (Phil Sutter) [RHEL-190549]
- fib: allow to use it in set statements (Phil Sutter) [RHEL-190549]
- fib: allow to check if route exists in maps (Phil Sutter) [RHEL-190549]
- tests: py: fix json single-flag output for fib & synproxy (Phil Sutter) [RHEL-190549]
- parser_json: Introduce parse_flags_array() (Phil Sutter) [RHEL-190549]
- json: work around fuzzer-induced assert crashes (Phil Sutter) [RHEL-190549]
- json: Introduce json_add_array_new() (Phil Sutter) [RHEL-190549]
- json: Print single synproxy flags as non-array (Phil Sutter) [RHEL-190549]
- json: Print single fib flag as non-array (Phil Sutter) [RHEL-190549]
- json: fix use after free in table_flags_json() (Phil Sutter) [RHEL-190549]
- doc: extend description of fib expression (Phil Sutter) [RHEL-190549]
- json: reject too long interface names (Phil Sutter) [RHEL-190549]
- parser_bison: allow delete command with map via handle (Phil Sutter) [RHEL-190549]
- parser_bison: only reset by name is supported by now (Phil Sutter) [RHEL-190549]
- cache: assert name is non-nul when looking up (Phil Sutter) [RHEL-190549]
- rule: skip fuzzy lookup if object name is not available (Phil Sutter) [RHEL-190549]
- src: BASECHAIN flag no longer implies presence of priority expression (Phil Sutter) [RHEL-190549]
- netlink: Avoid crash upon missing NFTNL_OBJ_CT_TIMEOUT_ARRAY attribute (Phil Sutter) [RHEL-190549]
- tests: py: Properly fix JSON equivalents for netdev/reject.t (Phil Sutter) [RHEL-190549]
- tests: monitor: Fix for single flag array avoidance (Phil Sutter) [RHEL-190549]
- json: Support typeof in set and map types (Phil Sutter) [RHEL-190549]
- netlink: Do not allocate a bogus flowtable priority expr (Phil Sutter) [RHEL-190549]
- netlink: Fix for potential crash parsing a flowtable (Phil Sutter) [RHEL-190549]
- json: prevent null deref if chain->policy is not set (Phil Sutter) [RHEL-190549]
- netlink: Catch unknown types when deserializing objects (Phil Sutter) [RHEL-190549]
- netlink: Avoid potential NULL-ptr deref parsing set elem expressions (Phil Sutter) [RHEL-190549]
- json: Print single set flag as non-array (Phil Sutter) [RHEL-190549]
- doc: Fix typo in nat statement 'prefix' description (Phil Sutter) [RHEL-190549]
Resolves: RHEL-190549
233 lines
5.0 KiB
Diff
233 lines
5.0 KiB
Diff
From 1bbd3a42f69d0eaaab66fede7d781013183ef064 Mon Sep 17 00:00:00 2001
|
|
From: Phil Sutter <psutter@redhat.com>
|
|
Date: Tue, 30 Jun 2026 14:25:19 +0200
|
|
Subject: [PATCH] tests: py: Properly fix JSON equivalents for netdev/reject.t
|
|
|
|
JIRA: https://issues.redhat.com/browse/RHEL-190549
|
|
Upstream Status: nftables commit b7a11c691d459d06a801a28ae9a52bc564584a1a
|
|
|
|
commit b7a11c691d459d06a801a28ae9a52bc564584a1a
|
|
Author: Phil Sutter <phil@nwl.cc>
|
|
Date: Thu Jun 12 12:59:29 2025 +0200
|
|
|
|
tests: py: Properly fix JSON equivalents for netdev/reject.t
|
|
|
|
Revert commit d1a7b9e19fe65 ("tests: py: update netdev reject test
|
|
file"), the stored JSON equivalents were correct in that they matched
|
|
the standard syntax input.
|
|
|
|
In fact, we missed a .json.output file recording the expected deviation
|
|
in JSON output.
|
|
|
|
Fixes: d1a7b9e19fe65 ("tests: py: update netdev reject test file")
|
|
Fixes: 7ca3368cd7575 ("reject: Unify inet, netdev and bridge delinearization")
|
|
Signed-off-by: Phil Sutter <phil@nwl.cc>
|
|
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
|
|
Signed-off-by: Phil Sutter <psutter@redhat.com>
|
|
---
|
|
tests/py/netdev/reject.t.json | 66 +++++++++++++++--------
|
|
tests/py/netdev/reject.t.json.output | 81 ++++++++++++++++++++++++++++
|
|
2 files changed, 126 insertions(+), 21 deletions(-)
|
|
create mode 100644 tests/py/netdev/reject.t.json.output
|
|
|
|
diff --git a/tests/py/netdev/reject.t.json b/tests/py/netdev/reject.t.json
|
|
index 9968aaf..b80db03 100644
|
|
--- a/tests/py/netdev/reject.t.json
|
|
+++ b/tests/py/netdev/reject.t.json
|
|
@@ -130,17 +130,6 @@
|
|
|
|
# mark 12345 reject with tcp reset
|
|
[
|
|
- {
|
|
- "match": {
|
|
- "left": {
|
|
- "meta": {
|
|
- "key": "l4proto"
|
|
- }
|
|
- },
|
|
- "op": "==",
|
|
- "right": 6
|
|
- }
|
|
- },
|
|
{
|
|
"match": {
|
|
"left": {
|
|
@@ -162,30 +151,43 @@
|
|
# reject
|
|
[
|
|
{
|
|
- "reject": {
|
|
- "expr": "port-unreachable",
|
|
- "type": "icmpx"
|
|
- }
|
|
+ "reject": null
|
|
}
|
|
]
|
|
|
|
# meta protocol ip reject
|
|
[
|
|
{
|
|
- "reject": {
|
|
- "expr": "port-unreachable",
|
|
- "type": "icmp"
|
|
+ "match": {
|
|
+ "left": {
|
|
+ "meta": {
|
|
+ "key": "protocol"
|
|
+ }
|
|
+ },
|
|
+ "op": "==",
|
|
+ "right": "ip"
|
|
}
|
|
+ },
|
|
+ {
|
|
+ "reject": null
|
|
}
|
|
]
|
|
|
|
# meta protocol ip6 reject
|
|
[
|
|
{
|
|
- "reject": {
|
|
- "expr": "port-unreachable",
|
|
- "type": "icmpv6"
|
|
+ "match": {
|
|
+ "left": {
|
|
+ "meta": {
|
|
+ "key": "protocol"
|
|
+ }
|
|
+ },
|
|
+ "op": "==",
|
|
+ "right": "ip6"
|
|
}
|
|
+ },
|
|
+ {
|
|
+ "reject": null
|
|
}
|
|
]
|
|
|
|
@@ -231,6 +233,17 @@
|
|
|
|
# meta protocol ip reject with icmp host-unreachable
|
|
[
|
|
+ {
|
|
+ "match": {
|
|
+ "left": {
|
|
+ "meta": {
|
|
+ "key": "protocol"
|
|
+ }
|
|
+ },
|
|
+ "op": "==",
|
|
+ "right": "ip"
|
|
+ }
|
|
+ },
|
|
{
|
|
"reject": {
|
|
"expr": "host-unreachable",
|
|
@@ -241,6 +254,17 @@
|
|
|
|
# meta protocol ip6 reject with icmpv6 no-route
|
|
[
|
|
+ {
|
|
+ "match": {
|
|
+ "left": {
|
|
+ "meta": {
|
|
+ "key": "protocol"
|
|
+ }
|
|
+ },
|
|
+ "op": "==",
|
|
+ "right": "ip6"
|
|
+ }
|
|
+ },
|
|
{
|
|
"reject": {
|
|
"expr": "no-route",
|
|
diff --git a/tests/py/netdev/reject.t.json.output b/tests/py/netdev/reject.t.json.output
|
|
new file mode 100644
|
|
index 0000000..cbd7310
|
|
--- /dev/null
|
|
+++ b/tests/py/netdev/reject.t.json.output
|
|
@@ -0,0 +1,81 @@
|
|
+# mark 12345 reject with tcp reset
|
|
+[
|
|
+ {
|
|
+ "match": {
|
|
+ "left": {
|
|
+ "meta": {
|
|
+ "key": "l4proto"
|
|
+ }
|
|
+ },
|
|
+ "op": "==",
|
|
+ "right": 6
|
|
+ }
|
|
+ },
|
|
+ {
|
|
+ "match": {
|
|
+ "left": {
|
|
+ "meta": {
|
|
+ "key": "mark"
|
|
+ }
|
|
+ },
|
|
+ "op": "==",
|
|
+ "right": 12345
|
|
+ }
|
|
+ },
|
|
+ {
|
|
+ "reject": {
|
|
+ "type": "tcp reset"
|
|
+ }
|
|
+ }
|
|
+]
|
|
+
|
|
+# reject
|
|
+[
|
|
+ {
|
|
+ "reject": {
|
|
+ "expr": "port-unreachable",
|
|
+ "type": "icmpx"
|
|
+ }
|
|
+ }
|
|
+]
|
|
+
|
|
+# meta protocol ip reject
|
|
+[
|
|
+ {
|
|
+ "reject": {
|
|
+ "expr": "port-unreachable",
|
|
+ "type": "icmp"
|
|
+ }
|
|
+ }
|
|
+]
|
|
+
|
|
+# meta protocol ip6 reject
|
|
+[
|
|
+ {
|
|
+ "reject": {
|
|
+ "expr": "port-unreachable",
|
|
+ "type": "icmpv6"
|
|
+ }
|
|
+ }
|
|
+]
|
|
+
|
|
+# meta protocol ip reject with icmp host-unreachable
|
|
+[
|
|
+ {
|
|
+ "reject": {
|
|
+ "expr": "host-unreachable",
|
|
+ "type": "icmp"
|
|
+ }
|
|
+ }
|
|
+]
|
|
+
|
|
+# meta protocol ip6 reject with icmpv6 no-route
|
|
+[
|
|
+ {
|
|
+ "reject": {
|
|
+ "expr": "no-route",
|
|
+ "type": "icmpv6"
|
|
+ }
|
|
+ }
|
|
+]
|
|
+
|