Fixed a I/0 problem in rpc.idmapd (bz 684308)

Signed-off-by: Steve Dickson <steved@redhat.com>
This commit is contained in:
Steve Dickson 2011-10-04 13:41:08 -04:00
parent cd65c75329
commit 855dc13683
2 changed files with 33 additions and 0 deletions

View File

@ -0,0 +1,30 @@
commit 8f065a26d49eabebc3995b8f6966b15ef7553b3e
Author: Luca Giuzzi <luca.giuzzi@gmail.com>
Date: Tue Oct 4 13:35:06 2011 -0400
rpc.idmapd: Dies with 'I/O possible'
We have had problems on some of our machines (all Fedora 14), where
rpc.idmapd used to die with an `I/O possible' message at (basically)
random times. A strace suggested the issue being in nfsopen() where a
signal type is reset before notification is disabled; a signal at just
the right time might be the cause of the problem; see
https://bugzilla.redhat.com/show_bug.cgi?id=684308
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
index 19d9114..e80efb4 100644
--- a/utils/idmapd/idmapd.c
+++ b/utils/idmapd/idmapd.c
@@ -778,8 +778,8 @@ nfsopen(struct idmap_client *ic)
} else {
event_set(&ic->ic_event, ic->ic_fd, EV_READ, nfscb, ic);
event_add(&ic->ic_event, NULL);
- fcntl(ic->ic_dirfd, F_SETSIG, 0);
fcntl(ic->ic_dirfd, F_NOTIFY, 0);
+ fcntl(ic->ic_dirfd, F_SETSIG, 0);
if (verbose > 0)
xlog_warn("Opened %s", ic->ic_path);
}

View File

@ -31,6 +31,7 @@ Source52: nfs-server.postconfig
Patch001: nfs-utils-1.2.6-rc1.patch Patch001: nfs-utils-1.2.6-rc1.patch
Patch002: nfs-utils-1.2.4-mountshortcut.patch Patch002: nfs-utils-1.2.4-mountshortcut.patch
Patch003: nfs-utils-1.2.5-manpage-typos.patch Patch003: nfs-utils-1.2.5-manpage-typos.patch
Patch004: nfs-utils-1.2.5-idmapd-ioerror.patch
Patch100: nfs-utils-1.2.1-statdpath-man.patch Patch100: nfs-utils-1.2.1-statdpath-man.patch
Patch101: nfs-utils-1.2.1-exp-subtree-warn-off.patch Patch101: nfs-utils-1.2.1-exp-subtree-warn-off.patch
@ -89,6 +90,7 @@ This package also contains the mount.nfs and umount.nfs program.
%patch001 -p1 %patch001 -p1
%patch002 -p1 %patch002 -p1
%patch003 -p1 %patch003 -p1
%patch004 -p1
%patch100 -p1 %patch100 -p1
%patch101 -p1 %patch101 -p1
@ -279,6 +281,7 @@ fi
* Tue Oct 4 2011 Steve Dickson <steved@redhat.com> 1.2.5-2 * Tue Oct 4 2011 Steve Dickson <steved@redhat.com> 1.2.5-2
- Removed SUID bigs on mount commands (bz 528498) - Removed SUID bigs on mount commands (bz 528498)
- Fixed a few typos in a couple man pages (bz 668124, 673818, 664330) - Fixed a few typos in a couple man pages (bz 668124, 673818, 664330)
- Fixed a I/0 problem in rpc.idmapd (bz 684308)
* Mon Oct 3 2011 Steve Dickson <steved@redhat.com> 1.2.5-1 * Mon Oct 3 2011 Steve Dickson <steved@redhat.com> 1.2.5-1
- Update to upstream RC release: nfs-utils-1.2.6-rc1 - Update to upstream RC release: nfs-utils-1.2.6-rc1