From 09a0c9005fb72102bf4f4499b28282f823e3e526 Mon Sep 17 00:00:00 2001 From: Josef Ridky Date: Wed, 18 Nov 2020 20:54:34 -0800 Subject: [PATCH] net-snmp-create-v3-user: Handle empty passphrases correctly See also https://github.com/net-snmp/net-snmp/issues/86. Fixes: e5ad10de8e17 ("Quote provided encryption key in createUser line") Reported-by: Chris Cheney --- net-snmp-create-v3-user.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net-snmp-create-v3-user.in b/net-snmp-create-v3-user.in index 452c2699d..31b4c58c1 100644 --- a/net-snmp-create-v3-user.in +++ b/net-snmp-create-v3-user.in @@ -120,7 +120,11 @@ fi fi outdir="@PERSISTENT_DIRECTORY@" outfile="$outdir/snmpd.conf" -line="createUser $user $Aalgorithm \"$apassphrase\" $Xalgorithm \"$xpassphrase\"" +if test "x$xpassphrase" = "x" ; then + line="createUser $user $Aalgorithm \"$apassphrase\" $Xalgorithm" +else + line="createUser $user $Aalgorithm \"$apassphrase\" $Xalgorithm \"$xpassphrase\"" +fi echo "adding the following line to $outfile:" echo " " $line # in case it hasn't ever been started yet, start it.