From d5947881c2918196d61d7795adba0abb881a86b9 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Tue, 19 May 2020 15:29:55 +0100 Subject: [PATCH 18/19] sh: Don't need to cast parameter of ascii_is* to (unsigned char). Our replacements for these functions are not undefined for negative values. Thanks: Eric Blake Fixes: commit 9f34db74786fdc92b290a7d47e4b003bd84fec69. (cherry picked from commit 06a79b8bb8cfd97a272223c967601d8858acb817) --- plugins/sh/call.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sh/call.c b/plugins/sh/call.c index ae0cc0ac..ba9f055f 100644 --- a/plugins/sh/call.c +++ b/plugins/sh/call.c @@ -392,7 +392,7 @@ handle_script_error (const char *argv0, char *ebuf, size_t len) } if (skip && ebuf[skip]) { - if (!ascii_isspace ((unsigned char) ebuf[skip])) { + if (!ascii_isspace (ebuf[skip])) { /* Treat 'EINVALID' as EIO, not EINVAL */ err = EIO; skip = 0; @@ -400,7 +400,7 @@ handle_script_error (const char *argv0, char *ebuf, size_t len) else do skip++; - while (ascii_isspace ((unsigned char) ebuf[skip])); + while (ascii_isspace (ebuf[skip])); } while (len > 0 && ebuf[len-1] == '\n') -- 2.18.2