From ae9a7cf9167bc35aa7278f55af1049ea4aa871e6 Mon Sep 17 00:00:00 2001 From: Mykola Ivanets Date: Wed, 29 Oct 2025 23:53:03 +0200 Subject: [PATCH] Fix mke2fs command line Man page says: The file system size is specified by fs-size. If fs-size does not have a suffix, it is interpreted as power-of-two kilobytes, unless the -b blocksize option is specified, in which case fs-size is interpreted as the number of blocksize blocks. If the fs-size is suffixed by 'k', 'm', 'g', 't' (either upper-case or lower-case), then it is interpreted in power-of-two kilobytes, megabytes, gigabytes, terabytes, etc. If fs-size is omitted, mke2fs will create the file system based on the device size. We could add '-b 1' parameter and specify fs-size, or just remove fs-size parameter, in this case mke2fs will create the file system based on device size. I prefer later option just because it will avoid duplicating fs-size specification twice (in the previous 'truncate' command and in 'mke2fs'). --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 53cc00d1..2a7e9623 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1895,7 +1895,7 @@ ext2.img: disk test-ext2-exportname.sh cp $< ext2.img.d/disks/disk.img echo /disks/disk.img > ext2.img.d/manifest $(TRUNCATE) -s 2147483648 $@-t - mke2fs -q -F -t ext4 -d ext2.img.d $@-t 2147483648 + mke2fs -q -F -t ext4 -d ext2.img.d $@-t rm -r ext2.img.d mv $@-t $@ -- 2.47.3