Seems we need to raise STACK_MIN_SIZE again too.

This commit is contained in:
Tom Lane 2008-01-08 04:47:12 +00:00 committed by Michal Schorm
parent 6699c49255
commit bd5697ac43
2 changed files with 3 additions and 1 deletions

View File

@ -2,6 +2,7 @@ Talk about silly byte-shaving ... the "stock" value does not work on s390x,
and probably not on some other platforms either. Knock it up to twice the
pre-5.0.33 value to have some margin for future changes in compiler, glibc,
etc. Suspect this number if "execution_constants" regression test fails.
As of 5.0.45 and F9, it seems 16384 isn't enough either.
diff -Naur mysql-5.0.38.orig/sql/mysql_priv.h mysql-5.0.38/sql/mysql_priv.h
@ -12,7 +13,7 @@ diff -Naur mysql-5.0.38.orig/sql/mysql_priv.h mysql-5.0.38/sql/mysql_priv.h
"execution_constants" test to pass.
*/
-#define STACK_MIN_SIZE 12000 // Abort if less stack during eval.
+#define STACK_MIN_SIZE 16384 // Abort if less stack during eval.
+#define STACK_MIN_SIZE 32768 // Abort if less stack during eval.
#define STACK_MIN_SIZE_FOR_OPEN 1024*80
#define STACK_BUFF_ALLOC 256 // For stack overrun checks

View File

@ -485,6 +485,7 @@ fi
* Mon Jan 7 2008 Tom Lane <tgl@redhat.com> 5.0.45-7
- Unbelievable ... upstream still thinks that it's a good idea to have a
regression test that is guaranteed to begin failing come January 1.
- ... and it seems we need to raise STACK_MIN_SIZE again too.
* Thu Dec 13 2007 Tom Lane <tgl@redhat.com> 5.0.45-6
- Back-port upstream fixes for CVE-2007-5925, CVE-2007-5969, CVE-2007-6303.