mysql8.4/community-mysql-pluginerrmsg.patch

In MySQL 5.5, the InnoDB Plugin is the default version and it's compiled in.
In this case, the plugin cannot be uninstalled and we get error when trying
to do so:

mysql> uninstall plugin innodb;
ERROR 1305 (42000): PLUGIN innodb does not exist

But the error message is misleading. The plugin does exist, it just cannot
be installed because it's not dynamically loaded.

MySQL bug report: http://bugs.mysql.com/bug.php?id=51771
MariaDB bug report: https://mariadb.atlassian.net/browse/MDEV-4573
MariaDB fix: http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/3802

diff -up mysql-5.5.33/include/mysql.h.p30 mysql-5.5.33/include/mysql.h
--- mysql-5.5.33/include/mysql.h.p30	2013-07-15 14:01:50.000000000 +0200
+++ mysql-5.5.33/include/mysql.h	2013-08-20 17:26:56.745334059 +0200
@@ -134,6 +134,7 @@ typedef unsigned long long my_ulonglong;
 
 /* backward compatibility define - to be removed eventually */
 #define ER_WARN_DATA_TRUNCATED WARN_DATA_TRUNCATED
+#define WARN_PLUGIN_DELETE_BUILTIN ER_PLUGIN_DELETE_BUILTIN
 
 typedef struct st_mysql_rows {
   struct st_mysql_rows *next;		/* list of rows */
diff -up mysql-5.5.33/mysql-test/r/plugin.result.p30 mysql-5.5.33/mysql-test/r/plugin.result
--- mysql-5.5.33/mysql-test/r/plugin.result.p30	2013-07-15 14:01:49.000000000 +0200
+++ mysql-5.5.33/mysql-test/r/plugin.result	2013-08-20 17:26:56.746334059 +0200
@@ -143,3 +143,5 @@ SELECT @@SESSION.example_double_thdvar;
 @@SESSION.example_double_thdvar
 1000.500000
 UNINSTALL PLUGIN example;
+UNINSTALL PLUGIN MyISAM;
+ERROR HY000: Built-in plugins cannot be deleted
diff -up mysql-5.5.33/mysql-test/t/plugin.test.p30 mysql-5.5.33/mysql-test/t/plugin.test
--- mysql-5.5.33/mysql-test/t/plugin.test.p30	2013-07-15 14:01:49.000000000 +0200
+++ mysql-5.5.33/mysql-test/t/plugin.test	2013-08-20 17:26:56.746334059 +0200
@@ -137,3 +137,10 @@ SET SESSION example_double_thdvar = 1000
 SELECT @@SESSION.example_double_thdvar;
 
 UNINSTALL PLUGIN example;
+
+#
+# MDEV-4573 UNINSTALL PLUGIN misleading error message for non-dynamic plugins
+#
+--error ER_PLUGIN_DELETE_BUILTIN
+UNINSTALL PLUGIN MyISAM;
+
diff -up mysql-5.5.33/sql/share/errmsg-utf8.txt.p30 mysql-5.5.33/sql/share/errmsg-utf8.txt
--- mysql-5.5.33/sql/share/errmsg-utf8.txt.p30	2013-07-15 14:01:50.000000000 +0200
+++ mysql-5.5.33/sql/share/errmsg-utf8.txt	2013-08-20 17:26:56.750334057 +0200
@@ -6161,7 +6161,7 @@ WARN_NO_MASTER_INFO
 WARN_OPTION_IGNORED
   eng "<%-.64s> option ignored"
   ger "Option <%-.64s> ignoriert"
-WARN_PLUGIN_DELETE_BUILTIN
+ER_PLUGIN_DELETE_BUILTIN
   eng "Built-in plugins cannot be deleted"
   ger "Eingebaute Plugins können nicht gelöscht werden"
 WARN_PLUGIN_BUSY
diff -up mysql-5.5.33/sql/sql_plugin.cc.p30 mysql-5.5.33/sql/sql_plugin.cc
--- mysql-5.5.33/sql/sql_plugin.cc.p30	2013-08-20 17:26:56.640334104 +0200
+++ mysql-5.5.33/sql/sql_plugin.cc	2013-08-20 17:26:56.752334057 +0200
@@ -1909,9 +1909,7 @@ bool mysql_uninstall_plugin(THD *thd, co
   }
   if (!plugin->plugin_dl)
   {
-    push_warning(thd, MYSQL_ERROR::WARN_LEVEL_WARN,
-                 WARN_PLUGIN_DELETE_BUILTIN, ER(WARN_PLUGIN_DELETE_BUILTIN));
-    my_error(ER_SP_DOES_NOT_EXIST, MYF(0), "PLUGIN", name->str);
+    my_error(ER_PLUGIN_DELETE_BUILTIN, MYF(0));
     goto err;
   }
   if (plugin->load_option == PLUGIN_FORCE_PLUS_PERMANENT)