From 73cc16785bc0a9a337f8046a701d2ddb82121a1d Mon Sep 17 00:00:00 2001 From: Michal Schorm Date: Wed, 1 May 2019 15:52:14 +0200 Subject: [PATCH] Update RPMLint whitelist --- community-mysql.rpmlintrc | 37 ++++++++++++++++++++++++++++++ mysql-5.6.10-rpmlintrc | 48 --------------------------------------- 2 files changed, 37 insertions(+), 48 deletions(-) create mode 100644 community-mysql.rpmlintrc delete mode 100644 mysql-5.6.10-rpmlintrc diff --git a/community-mysql.rpmlintrc b/community-mysql.rpmlintrc new file mode 100644 index 0000000..605529e --- /dev/null +++ b/community-mysql.rpmlintrc @@ -0,0 +1,37 @@ +# THIS FILE SERVES FOR WHITELISTING RPMLINT ERRORS AND WARNINGS IN TASKOTRON +# https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint#Whitelisting_errors + +# (same file in python3 package served as a great example) + + + +# Spelling errors +addFilter(r'spelling-error .* en_US (cnf|mysqld|subpackage) ') + +# Debug symlinks +addFilter(r'dangling-relative-symlink /usr/lib/.build-id') + +# Testsuite +# Some expected tests results are zero-length files +addFilter(r'(zero-length|pem-certificate|hidden-file-or-dir) /usr/share/mysql-test/*') + +# Chroot function +# False positive; checked by upstream +addFilter(r'missing-call-to-chdir-with-chroot') + +# Missing documentation +# I don't think that's on the upstream priority list +addFilter(r'no-documentation') +addFilter(r'no-manual-page-for-binary') + +# Cluster is gone +addFilter("W: obsolete-not-provided mysql-cluster") +addFilter("W: obsolete-not-provided mysql-bench") +addFilter("W: obsolete-not-provided community-mysql-bench") + +# Config file without noreplace flag +# Don't replace logs that may contain old entries +addFilter(r'conffile-without-noreplace-flag /var/log/mariadb/mariadb.log') + +# Seems pretty standard to me ... +addFilter(r'non-standard-dir-perm /var/log/mysql 750') diff --git a/mysql-5.6.10-rpmlintrc b/mysql-5.6.10-rpmlintrc deleted file mode 100644 index dfcdf39..0000000 --- a/mysql-5.6.10-rpmlintrc +++ /dev/null @@ -1,48 +0,0 @@ -# Filtered out until upstream fixes them -# Upstream bug: http://bugs.mysql.com/68518 -addFilter("incorrect-fsf-address") - -# Done to avoid _prefix/lib64/tmpfiles.d -addFilter("E: hardcoded-library-path in %\{_prefix\}/lib/tmpfiles.d") - -# Keeping the old summary for now -addFilter("W: name-repeated-in-summary C MySQL") - -# Spellchecked -addFilter("W: spelling-error %description -l en_US multi -> mulch, mufti") -addFilter("W: spelling-error %description -l en_US benchmarking -> bench marking, bench-marking, benchmark") -addFilter("W: spelling-error Summary(en_US) embeddable -> embedded") -addFilter("W: spelling-error.*embeddable -> embedded") - -# As long as the manual is part of the original tarball, we have do to -# this -addFilter("mysql.src: W: invalid-url Source0: mysql-5.6.[0-9]+-nodocs.tar.gz") - -# Leave the logfile where it is for now -addFilter("E: non-root-user-log-file /var/log/mysqld.log mysql") -addFilter("E: non-root-group-log-file /var/log/mysqld.log mysql") -addFilter("E: non-ghost-file /var/log/mysqld.log") -addFilter("E: zero-length /var/log/mysqld.log") - -addFilter("E: incoherent-logrotate-file /etc/logrotate.d/mysqld") - -# Hidden files and zero lenght files is normal for some tests -addFilter("W: hidden-file-or-dir /usr/share/mysql-test/std_data/.mylogin.cnf") -addFilter("E: zero-length /usr/share/mysql-test/suite/parts/t/disabled.def") -addFilter("E: zero-length /usr/share/mysql-test/std_data/bug37631.MYD") -addFilter("E: zero-length /usr/share/mysql-test/std_data/cluster_7022_table.MYD") -addFilter("E: zero-length /usr/share/mysql-test/collections/disabled-weekly.list") -addFilter("E: zero-length /usr/share/mysql-test/collections/disabled-daily.list") - -# debuginfo bug? -addFilter("E: non-standard-dir-perm /usr/src/debug/tmp 01777") - -# mysql-config *script* in lib -addFilter("W: only-non-binary-in-usr-lib") - -# missing -addFilter("W: no-manual-page-for-binary my_safe_process") - -# cluster is gone -addFilter("W: obsolete-not-provided mysql-cluster") -