mtr/mtr-gtk-pkexec-wrapper.sh

#!/bin/sh

error_message="You are trying to run mtr-gtk in a Wayland session, however mtr-gtk requires root privileges and such graphical applications are not allowed to run on Wayland by default.\n\nSee https://fedoraproject.org/wiki/Common_F25_bugs\#wayland-root-apps for more details and possible workarounds.\n"

if [ "$XDG_SESSION_TYPE" = wayland ]; then
    zenity --error --title "mtr-gtk on Wayland" --text "$error_message" --width=600 2>/dev/null || printf "$error_message" >&2
    exit 1
fi

/usr/bin/pkexec /usr/bin/xmtr.bin
Rebase to latest upstream Resolves: #1365128 2017-02-28 08:53:13 +00:00			`#!/bin/sh`

Inform user about the problem with running GUI apps under root on Wayland 2017-02-28 16:16:57 +00:00			`error_message="You are trying to run mtr-gtk in a Wayland session, however mtr-gtk requires root privileges and such graphical applications are not allowed to run on Wayland by default.\n\nSee https://fedoraproject.org/wiki/Common_F25_bugs\#wayland-root-apps for more details and possible workarounds.\n"`

			`if [ "$XDG_SESSION_TYPE" = wayland ]; then`
			`zenity --error --title "mtr-gtk on Wayland" --text "$error_message" --width=600 2>/dev/null \|\| printf "$error_message" >&2`
			`exit 1`
			`fi`

Make shell parent of pkexec In case when mtr-gtk is started from gnome-shell we need to make sure that parent process of pkexec is not systemd. This is because pkexec exits with error if it detects that its parent is PID 1 [1]. Execing pkexec was fine before F22, because previously gnome-shell was reaping processes it spawned. Since F22 gnome-shell doesn't do that and it calls g_spawn_async w/o G_SPAWN_DO_NOT_REAP_CHILD flag in which case glib really doesn't bother with reaping child processes properly and instead it does double fork(). Intermediate child process goes away and grand-child is then reparented to PID 1 that will reap it. [2] [1] https://cgit.freedesktop.org/polkit/commit/src/programs/pkexec.c?id=3b12cfac29dddd27f1f166a7574d8374cc1dccf2 [2] https://git.gnome.org/browse/gnome-shell/commit/?id=01c6392c1373cf23786a0dad1b670a511107349c 2017-02-28 13:20:33 +00:00			`/usr/bin/pkexec /usr/bin/xmtr.bin`