81 lines
3.5 KiB
Diff
81 lines
3.5 KiB
Diff
diff -rupN --no-dereference openssl-3.0.5/crypto/ec/ec_lib.c openssl-3.0.5-new/crypto/ec/ec_lib.c
|
|
--- openssl-3.0.5/crypto/ec/ec_lib.c 2022-07-05 10:57:04.000000000 +0200
|
|
+++ openssl-3.0.5-new/crypto/ec/ec_lib.c 2022-07-08 10:09:54.040097982 +0200
|
|
@@ -1458,7 +1458,7 @@ static EC_GROUP *ec_group_explicit_to_na
|
|
goto err;
|
|
}
|
|
} else {
|
|
- ret_group = (EC_GROUP *)group;
|
|
+ goto err;
|
|
}
|
|
EC_GROUP_free(dup);
|
|
return ret_group;
|
|
diff -rupN --no-dereference openssl-3.0.5/providers/common/securitycheck.c openssl-3.0.5-new/providers/common/securitycheck.c
|
|
--- openssl-3.0.5/providers/common/securitycheck.c 2022-07-05 10:57:04.000000000 +0200
|
|
+++ openssl-3.0.5-new/providers/common/securitycheck.c 2022-07-08 10:09:54.041097982 +0200
|
|
@@ -92,22 +92,22 @@ int ossl_rsa_check_key(OSSL_LIB_CTX *ctx
|
|
int ossl_ec_check_key(OSSL_LIB_CTX *ctx, const EC_KEY *ec, int protect)
|
|
{
|
|
# if !defined(OPENSSL_NO_FIPS_SECURITYCHECKS)
|
|
- if (ossl_securitycheck_enabled(ctx)) {
|
|
- int nid, strength;
|
|
- const char *curve_name;
|
|
- const EC_GROUP *group = EC_KEY_get0_group(ec);
|
|
+ int nid, strength;
|
|
+ const char *curve_name;
|
|
+ const EC_GROUP *group = EC_KEY_get0_group(ec);
|
|
|
|
- if (group == NULL) {
|
|
- ERR_raise_data(ERR_LIB_PROV, PROV_R_INVALID_CURVE, "No group");
|
|
- return 0;
|
|
- }
|
|
- nid = EC_GROUP_get_curve_name(group);
|
|
- if (nid == NID_undef) {
|
|
- ERR_raise_data(ERR_LIB_PROV, PROV_R_INVALID_CURVE,
|
|
- "Explicit curves are not allowed in fips mode");
|
|
- return 0;
|
|
- }
|
|
+ if (group == NULL) {
|
|
+ ERR_raise_data(ERR_LIB_PROV, PROV_R_INVALID_CURVE, "No group");
|
|
+ return 0;
|
|
+ }
|
|
+ nid = EC_GROUP_get_curve_name(group);
|
|
+ if (nid == NID_undef) {
|
|
+ ERR_raise_data(ERR_LIB_PROV, PROV_R_INVALID_CURVE,
|
|
+ "Explicit curves are not allowed in this build");
|
|
+ return 0;
|
|
+ }
|
|
|
|
+ if (ossl_securitycheck_enabled(ctx)) {
|
|
curve_name = EC_curve_nid2nist(nid);
|
|
if (curve_name == NULL) {
|
|
ERR_raise_data(ERR_LIB_PROV, PROV_R_INVALID_CURVE,
|
|
diff -rupN --no-dereference openssl-3.0.5/providers/implementations/keymgmt/ec_kmgmt.c openssl-3.0.5-new/providers/implementations/keymgmt/ec_kmgmt.c
|
|
--- openssl-3.0.5/providers/implementations/keymgmt/ec_kmgmt.c 2022-07-05 10:57:04.000000000 +0200
|
|
+++ openssl-3.0.5-new/providers/implementations/keymgmt/ec_kmgmt.c 2022-07-08 10:09:54.041097982 +0200
|
|
@@ -937,11 +937,8 @@ int ec_validate(const void *keydata, int
|
|
if ((selection & OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS) != 0) {
|
|
int flags = EC_KEY_get_flags(eck);
|
|
|
|
- if ((flags & EC_FLAG_CHECK_NAMED_GROUP) != 0)
|
|
- ok = ok && EC_GROUP_check_named_curve(EC_KEY_get0_group(eck),
|
|
- (flags & EC_FLAG_CHECK_NAMED_GROUP_NIST) != 0, ctx);
|
|
- else
|
|
- ok = ok && EC_GROUP_check(EC_KEY_get0_group(eck), ctx);
|
|
+ ok = ok && EC_GROUP_check_named_curve(EC_KEY_get0_group(eck),
|
|
+ (flags & EC_FLAG_CHECK_NAMED_GROUP_NIST) != 0, ctx);
|
|
}
|
|
|
|
if ((selection & OSSL_KEYMGMT_SELECT_PUBLIC_KEY) != 0) {
|
|
@@ -1218,6 +1215,10 @@ static int ec_gen_assign_group(EC_KEY *e
|
|
ERR_raise(ERR_LIB_PROV, PROV_R_NO_PARAMETERS_SET);
|
|
return 0;
|
|
}
|
|
+ if (EC_GROUP_get_curve_name(group) == NID_undef) {
|
|
+ ERR_raise(ERR_LIB_PROV, PROV_R_INVALID_CURVE);
|
|
+ return 0;
|
|
+ }
|
|
return EC_KEY_set_group(ec, group) > 0;
|
|
}
|
|
|