From 46643e1ad5ece5f1257b2d827e36231df44929a2 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Tue, 29 Jul 2014 13:37:42 +1000 Subject: [PATCH] Grow: improve error message is "--grow -n2" used on Linear arrays. Linear arrays don't respond to setting raid-disks, only to adding a device. Reported-by: mulhern Reported-by: Jes Sorensen Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1122146 Signed-off-by: NeilBrown --- Grow.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Grow.c b/Grow.c index af59347..a9c8589 100644 --- a/Grow.c +++ b/Grow.c @@ -1028,7 +1028,12 @@ char *analyse_change(char *devname, struct mdinfo *info, struct reshape *re) switch (info->array.level) { default: - return "Cannot understand this RAID level"; + return "No reshape is possibly for this RAID level"; + case LEVEL_LINEAR: + if (info->delta_disks != UnSet) + return "Only --add is supported for LINEAR, setting --raid-disks is not needed"; + else + return "Only --add is supported for LINEAR, other --grow options are not meaningful"; case 1: /* RAID1 can convert to RAID1 with different disks, or * raid5 with 2 disks, or -- 1.9.3