From 793527ec8541bccae84ab8f47a8a08388c78d64e Mon Sep 17 00:00:00 2001
From: Zuzana Miklankova <zmiklank@redhat.com>
Date: Wed, 24 Nov 2021 09:23:20 +0100
Subject: [PATCH] Disable badfunct rpinspect CI check for /usr/bin/resolveip

Resolveip binary is only used in mysql_install_db.sh script,
and only in non-"--rpm" mode [1]. However, we call this script with
"--rpm" option enabled, and thus the resolveip is not used [2],
and its badfuncs check can be disabled. [3]

Resolves: #1973194

[1] https://gitlab.com/redhat/centos-stream/rpms/mariadb/-/blob/c9s/mariadb-prepare-db-dir.sh#L100
[2] https://github.com/MariaDB/server/blob/5566cbadb03856aba9c236b131f544490cd2bee4/scripts/mysql_install_db.sh#L425-L441
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1973194#c4
---
 rpminspect.yaml | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/rpminspect.yaml b/rpminspect.yaml
index 178f73a..9e84eeb 100644
--- a/rpminspect.yaml
+++ b/rpminspect.yaml
@@ -6,7 +6,6 @@
 # Index.xml file.
 #
 # CI picks up the rpmlimspect.yaml for specific package in the dist-git repo.
-
 xml:
   ignore:
     - /usr/share/mysql-test/std_data/loadxml.dat
@@ -14,3 +13,27 @@ xml:
     - /usr/share/mysql-test/std_data/ldml/Index.xml
     - /usr/share/mysql-test/plugin/sphinx/sphinx/testdata.xml
     - /usr/share/mysql-test/plugin/connect/connect/std_data/nocs.xml
+
+# ignore bad functions in resolveip binary, based on BZ1973194
+# all forbidden functions listed in main rpminspect config
+# have to be mentioned also here, else it would not be checked for them
+badfuncs:
+    - gethostbyname
+    - gethostbyname2
+    - gethostbyaddr
+    - inet_addr
+    - inet_aton
+    - inet_nsap_addr
+    - inet_ntoa
+    - inet_nsap_ntoa
+    - inet_makeaddr
+    - inet_netof
+    - inet_network
+    - inet_neta
+    - inet_net_ntop
+    - inet_net_pton
+    - rcmd
+    - rexec
+    - rresvport
+    ignore:
+        - /usr/bin/resolveip